[GitHub] [parquet-mr] Fokko commented on a change in pull request #884: PARQUET-2005: Upgrade thrift to 0.14.1

[GitBox <gi...@apache.org>]

Fokko commented on a change in pull request #884:
URL: https://github.com/apache/parquet-mr/pull/884#discussion_r608112657



##########
File path: README.md
##########
@@ -35,19 +35,19 @@ Parquet-MR uses Maven to build and depends on the thrift compiler (protoc is now
 To build and install the thrift compiler, run:
 
 ```
-wget -nv http://archive.apache.org/dist/thrift/0.13.0/thrift-0.13.0.tar.gz
-tar xzf thrift-0.13.0.tar.gz
-cd thrift-0.13.0
+wget -nv http://archive.apache.org/dist/thrift/0.14.1/thrift-0.14.1.tar.gz
+tar xzf thrift-0.14.1.tar.gz
+cd thrift-0.14.1
 chmod +x ./configure
 ./configure --disable-libs
 sudo make install
 ```
 
-If you're on OSX and use homebrew, you can instead install Thrift 0.13.0 with `brew` and ensure that it comes first in your `PATH`.
+If you're on OSX and use homebrew, you can instead install Thrift 0.14.1 with `brew` and ensure that it comes first in your `PATH`.
 
 ```
 brew install thrift@0.13

Review comment:
       ```suggestion
   brew install thrift
   ```
   
   Just. checked, and 0.14.1 is the latest version:
   ```
   fokkodriesprong@MacBook-Pro parquet-mr % brew install thrift
   Warning: thrift 0.14.1 is already installed and up-to-date.
   To reinstall 0.14.1, run:
     brew reinstall thrift
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org