You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by te...@apache.org on 2018/01/02 14:26:35 UTC
hbase git commit: HBASE-19676 CleanerChore logging improvements
(BELUGA BEHR)
Repository: hbase
Updated Branches:
refs/heads/master 9ac95419d -> 9c2a35542
HBASE-19676 CleanerChore logging improvements (BELUGA BEHR)
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/9c2a3554
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/9c2a3554
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/9c2a3554
Branch: refs/heads/master
Commit: 9c2a35542f3434ea8b4f278bb4e4bf7dcd1db604
Parents: 9ac9541
Author: tedyu <yu...@gmail.com>
Authored: Tue Jan 2 06:26:29 2018 -0800
Committer: tedyu <yu...@gmail.com>
Committed: Tue Jan 2 06:26:29 2018 -0800
----------------------------------------------------------------------
.../hadoop/hbase/master/cleaner/CleanerChore.java | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/9c2a3554/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
index 15d0005..944db10 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
@@ -53,7 +53,7 @@ import org.slf4j.LoggerFactory;
public abstract class CleanerChore<T extends FileCleanerDelegate> extends ScheduledChore
implements ConfigurationObserver {
- private static final Logger LOG = LoggerFactory.getLogger(CleanerChore.class.getName());
+ private static final Logger LOG = LoggerFactory.getLogger(CleanerChore.class);
private static final int AVAIL_PROCESSORS = Runtime.getRuntime().availableProcessors();
/**
@@ -110,7 +110,7 @@ public abstract class CleanerChore<T extends FileCleanerDelegate> extends Schedu
chorePoolSize = chorePoolSize == 0 ?
calculatePoolSize(DEFAULT_CHORE_POOL_SIZE) : chorePoolSize;
this.chorePool = new ForkJoinPool(chorePoolSize);
- LOG.info("Cleaner pool size is " + chorePoolSize);
+ LOG.info("Cleaner pool size is {}", chorePoolSize);
}
}
@@ -125,7 +125,7 @@ public abstract class CleanerChore<T extends FileCleanerDelegate> extends Schedu
// but upmost to the number of available processors.
int size = Math.min(Integer.valueOf(poolSize), AVAIL_PROCESSORS);
if (size == AVAIL_PROCESSORS) {
- LOG.warn("Use full core processors to scan dir, size={}" + size);
+ LOG.warn("Use full core processors to scan dir, size={}", size);
}
return size;
} else if (poolSize.matches("0.[0-9]+|1.0")) {
@@ -157,7 +157,7 @@ public abstract class CleanerChore<T extends FileCleanerDelegate> extends Schedu
for (String className : logCleaners) {
T logCleaner = newFileCleaner(className, conf);
if (logCleaner != null) {
- LOG.debug("Initialize cleaner=" + className);
+ LOG.debug("Initialize cleaner={}", className);
this.cleanersChain.add(logCleaner);
}
}
@@ -216,7 +216,7 @@ public abstract class CleanerChore<T extends FileCleanerDelegate> extends Schedu
if (runCleaner()) {
LOG.debug("Cleaned old files/dirs under {} successfully", oldFileDir);
} else {
- LOG.warn("Failed to fully clean old files/dirs under " + oldFileDir + ".");
+ LOG.warn("Failed to fully clean old files/dirs under {}", oldFileDir);
}
// After each clean chore, checks if receives reconfigure notification while cleaning
if (reconfig.compareAndSet(true, false)) {
@@ -268,7 +268,7 @@ public abstract class CleanerChore<T extends FileCleanerDelegate> extends Schedu
directorySpaces.put(f, space);
return space;
} catch (IOException e) {
- LOG.trace("Failed to get space consumed by path={}", f.getPath(), e);
+ LOG.trace("Failed to get space consumed by path={}", f, e);
return -1;
}
}