[GitHub] [cordova-plugin-inappbrowser] NiklasMerz commented on issue #503: (android) Defensive code to prevent NULL reference exceptions for async

[GitBox <gi...@apache.org>]

NiklasMerz commented on issue #503: (android) Defensive code to prevent NULL reference exceptions for async
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/503#issuecomment-570308115
 
 
   I like to live dangerous and rebased this PR and did the suggested changes. I hope I did not mess anything up. A backup  is in my fork [here](https://github.com/apache/cordova-plugin-inappbrowser/compare/master...NiklasMerz:pr503)
   
   That's what I did:
   * rebased the PR to latest master
   * did an interactive rebase to squash the two relevant commits and drop the reverted changes
   * changed the author to @alexyazvinsky and pushed this as a signed commit since I did this
   * Did the suggested changes seperately
   
   I hope that makes this PR better to read and follows the Apache guidelines. We should merge this and **not squash merge** to make the authors and history clear.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org