You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jakarta.apache.org by bu...@apache.org on 2011/01/27 13:23:22 UTC

DO NOT REPLY [Bug 50666] JMS support for durable subscriptions

https://issues.apache.org/bugzilla/show_bug.cgi?id=50666

--- Comment #1 from Sebb <se...@apache.org> 2011-01-27 07:23:19 EST ---
Thanks!

Patch looks generally OK from a visual inspection. 

It would be helpful to also have a patch for the documentation, i.e.
component_reference.xml, which explains what the new field does.

BTW, the getProperty() and setProperty() methods have versions which provide
defaults. The get default can be used to ensure the value is not null.
The set default is useful to ensure that the property is not added to JMX files
if it is empty. Obviously the same defaults must be used!

We try to use this for new properties, otherwise the JMX files keep growing.

No need to update the patch - that can be fixed later.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org