You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/05/19 20:16:39 UTC
[GitHub] [lucene] dnhatn commented on a change in pull request #147: LUCENE-9827: Update backward codec in Lucene 9.0
dnhatn commented on a change in pull request #147:
URL: https://github.com/apache/lucene/pull/147#discussion_r635554782
##########
File path: lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene50/compressing/Lucene50CompressingStoredFieldsReader.java
##########
@@ -231,14 +238,45 @@ public Lucene50CompressingStoredFieldsReader(
this.maxPointer = maxPointer;
this.indexReader = indexReader;
- if (version >= VERSION_META) {
+ if (version >= VERSION_NUM_CHUNKS) {
+ numChunks = metaIn.readVLong();
numDirtyChunks = metaIn.readVLong();
numDirtyDocs = metaIn.readVLong();
Review comment:
We are still using bulk merges in StoredField/TermVectors [writers](https://github.com/apache/lucene/pull/147/files#diff-6effde18170f5ffa4be913fc312b5852cb86c000a26aaac1e7076eef4e729f54L672-L673) in tests. I have removed the optimized merges from these writers in https://github.com/apache/lucene/pull/147/commits/150c1c16bfbd7d26043e523047c290f224aafd14. I think we just need to keep bare writers to verify the corresponding readers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org