[GitHub] [calcite] rubenada commented on a change in pull request #1246: [CALCITE-2968] New AntiJoin relational expression

[GitBox <gi...@apache.org>]

rubenada commented on a change in pull request #1246: [CALCITE-2968] New AntiJoin relational expression
URL: https://github.com/apache/calcite/pull/1246#discussion_r291069724
 
 

 ##########
 File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java
 ##########
 @@ -1322,9 +1351,10 @@ private void closeInner() {
       final Enumerable<TSource> outer, final Enumerable<TInner> inner,
       final Predicate2<TSource, TInner> predicate,
       Function2<TSource, TInner, TResult> resultSelector,
-      final boolean generateNullsOnLeft,
-      final boolean generateNullsOnRight) {
+      final JoinType joinType) {
 
 Review comment:
   To be on the safe side, we could keep the old method as deprecated, I'm not against it.
   However, considering that this method was already renamed as part of [[CALCITE-2969] Improve design of join-like relational expressions](https://issues.apache.org/jira/browse/CALCITE-2969) (previously it was named thetaJoin), I think we have already "broken" many things for 1.20, so I guess one more little change little will not be that relevant.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services