[GitHub] [dubbo] AlbumenJ commented on a change in pull request #8683: [master] fix destroy NPE and doOverrideIfNecessary IllegalStateException

[GitBox <gi...@apache.org>]

AlbumenJ commented on a change in pull request #8683:
URL: https://github.com/apache/dubbo/pull/8683#discussion_r704031605



##########
File path: dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/integration/RegistryProtocol.java
##########
@@ -688,7 +693,8 @@ public synchronized void doOverrideIfNecessary() {
                 return;
             }
             //The current, may have been merged many times
-            URL currentUrl = exporter.getInvoker().getUrl();
+            Invoker<?> exporterInvoker = exporter.getInvoker();

Review comment:
       exporterInvoker should not be null here when calling `doOverrideIfNecessary`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org