You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@clerezza.apache.org by re...@apache.org on 2010/01/05 10:23:44 UTC

svn commit: r895956 - /incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.webapp.parent/org.apache.clerezza.platform.scripting.scriptmanager/src/main/java/org/apache/clerezza/platform/scripting/scriptmanager/ScriptManager.java

Author: reto
Date: Tue Jan  5 09:23:42 2010
New Revision: 895956

URL: http://svn.apache.org/viewvc?rev=895956&view=rev
Log:
more comprehensive error message with stack trace

Modified:
    incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.webapp.parent/org.apache.clerezza.platform.scripting.scriptmanager/src/main/java/org/apache/clerezza/platform/scripting/scriptmanager/ScriptManager.java

Modified: incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.webapp.parent/org.apache.clerezza.platform.scripting.scriptmanager/src/main/java/org/apache/clerezza/platform/scripting/scriptmanager/ScriptManager.java
URL: http://svn.apache.org/viewvc/incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.webapp.parent/org.apache.clerezza.platform.scripting.scriptmanager/src/main/java/org/apache/clerezza/platform/scripting/scriptmanager/ScriptManager.java?rev=895956&r1=895955&r2=895956&view=diff
==============================================================================
--- incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.webapp.parent/org.apache.clerezza.platform.scripting.scriptmanager/src/main/java/org/apache/clerezza/platform/scripting/scriptmanager/ScriptManager.java (original)
+++ incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.webapp.parent/org.apache.clerezza.platform.scripting.scriptmanager/src/main/java/org/apache/clerezza/platform/scripting/scriptmanager/ScriptManager.java Tue Jan  5 09:23:42 2010
@@ -19,6 +19,8 @@
 package org.apache.clerezza.platform.scripting.scriptmanager;
 
 import java.io.IOException;
+import java.io.PrintWriter;
+import java.io.StringWriter;
 import java.net.URI;
 import java.net.URISyntaxException;
 import java.net.URL;
@@ -779,13 +781,17 @@
 		} catch (NoEngineException ex) {
 			throw new WebApplicationException(ex);
 		} catch (ScriptException ex) {
-			StringBuilder sb = new StringBuilder();
+			StringWriter sw = new StringWriter();
+			PrintWriter pw = new PrintWriter(sw);
+			pw.println("Exception executing script: ");
 			if (ex.getLineNumber() != -1 || ex.getColumnNumber() != -1) {
-				sb.append("at line number" + ex.getLineNumber() + " ");
-				sb.append("at column number" + ex.getColumnNumber() + ": ");
+				pw.print("at line number" + ex.getLineNumber() + " ");
+				pw.print("at column number" + ex.getColumnNumber() + ": ");
 			}
-			sb.append(ex.getMessage() + "\n");
-			return sb.toString();
+			pw.println(ex.getMessage());
+			ex.printStackTrace(pw);
+			pw.flush();
+			return sw.toString();
 		} 
 	}