You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2016/10/03 09:12:56 UTC

Re: Review Request 51363: LENS-1287: Create command in cli to create schema taking parent directory where schema is stored

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51363/
-----------------------------------------------------------

(Updated Oct. 3, 2016, 2:42 p.m.)


Review request for lens.


Bugs: LENS-1287
    https://issues.apache.org/jira/browse/LENS-1287


Repository: lens


Description
-------


Diffs (updated)
-----

  lens-cli/src/main/java/org/apache/lens/cli/commands/LensDatabaseCommands.java 05108f0158b655653f0665da80a2d10b24f33233 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 7df5c7ca1c7f557409ed36a4be7f4b050260f159 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 6457bceef143ce08e6a57726cb1e54dcf3288b0c 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java PRE-CREATION 
  lens-cli/src/test/java/org/apache/lens/cli/LensCLITest.java PRE-CREATION 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java c20766c26c42918e7ab33c32c0b4218ddfa5ee81 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 9687c6089125b4eb9dc2a96fd7d4a140c81eb66c 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a3f01c38d1c94857f0cdfdd7a457b402754c30a6 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 5d6d7682d75793897cc6d2fee0bb23ce7f467ab9 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java b4cbf344c46faa40074bc79fa0227312e027dfb6 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 24f9279b24de98ed1e7304ec2e2010c17df9f8d8 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java e75fc0ef19d9d9b288bdb677bfdf499aa088e6ee 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensSchemaCommands.java PRE-CREATION 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensSegmentationCommands.java e6d4bc5354bbcae9ea6d1f06ec2be6e2ff885cf6 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java c4ab6140c573d8bb4d2048969be14786d2371d6d 
  lens-cli/src/test/java/org/apache/lens/cli/doc/TestGenerateCLIUserDoc.java 95e6b4e205128a19d1099f0a14638a8eb2d19c7c 
  lens-cli/src/test/resources/cube_with_no_weight_facts.xml 4673ca416758c35bf50616896f084360a1b5bb89 
  lens-cli/src/test/resources/dim_table.xml eb4ddfcc49c9cfdc152df35fe863176986016d95 
  lens-cli/src/test/resources/dim_table2.xml 8440e28b59cdcc567bac00e4c1e2367ef2ebda0c 
  lens-cli/src/test/resources/fact1.xml b18a39313bff9850c720cb3f0492bc6b7a650f78 
  lens-cli/src/test/resources/fact_without_weight.xml 0c124b2aba88a9efcc164b3b4de96479c164cd6a 
  lens-cli/src/test/resources/local-storage.xml 65513757f5dc2a19fea88cde4f4fa8736f814091 
  lens-cli/src/test/resources/sample-cube.xml 2d6bc3469466cee6245f8f503af956dcc92cffb5 
  lens-cli/src/test/resources/schema/cubes/base/cube_with_no_weight_facts.xml PRE-CREATION 
  lens-cli/src/test/resources/schema/cubes/base/sample-cube.xml PRE-CREATION 
  lens-cli/src/test/resources/schema/dimensions/test-detail.xml PRE-CREATION 
  lens-cli/src/test/resources/schema/dimensions/test-dimension.xml PRE-CREATION 
  lens-cli/src/test/resources/schema/dimtables/dim_table.xml PRE-CREATION 
  lens-cli/src/test/resources/schema/dimtables/dim_table2.xml PRE-CREATION 
  lens-cli/src/test/resources/schema/facts/fact1.xml PRE-CREATION 
  lens-cli/src/test/resources/schema/facts/fact_without_weight.xml PRE-CREATION 
  lens-cli/src/test/resources/schema/segmentations/seg1.xml PRE-CREATION 
  lens-cli/src/test/resources/schema/storages/local-storage.xml PRE-CREATION 
  lens-cli/src/test/resources/seg1.xml 8a3991514633bcb25ded0e305bdd50192149773c 
  lens-cli/src/test/resources/test-detail.xml b51c1888d88436302a7e43ef12d3643fe99b0267 
  lens-cli/src/test/resources/test-dimension.xml 01de8e69bce7536768bd99d765af3d07f70914a4 
  src/site/apt/user/cli.apt 2522e03fc80b12bcd64f6df155cd862e4e53e2c2 

Diff: https://reviews.apache.org/r/51363/diff/


Testing
-------


Thanks,

Rajat Khandelwal


Re: Review Request 51363: LENS-1287: Create command in cli to create schema taking parent directory where schema is stored

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51363/#review151157
-----------------------------------------------------------


Ship it!




Ship It!

- Amareshwari Sriramadasu


On Oct. 3, 2016, 9:12 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51363/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2016, 9:12 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1287
>     https://issues.apache.org/jira/browse/LENS-1287
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> 
> Diffs
> -----
> 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensDatabaseCommands.java 05108f0158b655653f0665da80a2d10b24f33233 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 7df5c7ca1c7f557409ed36a4be7f4b050260f159 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 6457bceef143ce08e6a57726cb1e54dcf3288b0c 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java PRE-CREATION 
>   lens-cli/src/test/java/org/apache/lens/cli/LensCLITest.java PRE-CREATION 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java c20766c26c42918e7ab33c32c0b4218ddfa5ee81 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 9687c6089125b4eb9dc2a96fd7d4a140c81eb66c 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a3f01c38d1c94857f0cdfdd7a457b402754c30a6 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 5d6d7682d75793897cc6d2fee0bb23ce7f467ab9 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java b4cbf344c46faa40074bc79fa0227312e027dfb6 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 24f9279b24de98ed1e7304ec2e2010c17df9f8d8 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java e75fc0ef19d9d9b288bdb677bfdf499aa088e6ee 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensSchemaCommands.java PRE-CREATION 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensSegmentationCommands.java e6d4bc5354bbcae9ea6d1f06ec2be6e2ff885cf6 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java c4ab6140c573d8bb4d2048969be14786d2371d6d 
>   lens-cli/src/test/java/org/apache/lens/cli/doc/TestGenerateCLIUserDoc.java 95e6b4e205128a19d1099f0a14638a8eb2d19c7c 
>   lens-cli/src/test/resources/cube_with_no_weight_facts.xml 4673ca416758c35bf50616896f084360a1b5bb89 
>   lens-cli/src/test/resources/dim_table.xml eb4ddfcc49c9cfdc152df35fe863176986016d95 
>   lens-cli/src/test/resources/dim_table2.xml 8440e28b59cdcc567bac00e4c1e2367ef2ebda0c 
>   lens-cli/src/test/resources/fact1.xml b18a39313bff9850c720cb3f0492bc6b7a650f78 
>   lens-cli/src/test/resources/fact_without_weight.xml 0c124b2aba88a9efcc164b3b4de96479c164cd6a 
>   lens-cli/src/test/resources/local-storage.xml 65513757f5dc2a19fea88cde4f4fa8736f814091 
>   lens-cli/src/test/resources/sample-cube.xml 2d6bc3469466cee6245f8f503af956dcc92cffb5 
>   lens-cli/src/test/resources/schema/cubes/base/cube_with_no_weight_facts.xml PRE-CREATION 
>   lens-cli/src/test/resources/schema/cubes/base/sample-cube.xml PRE-CREATION 
>   lens-cli/src/test/resources/schema/dimensions/test-detail.xml PRE-CREATION 
>   lens-cli/src/test/resources/schema/dimensions/test-dimension.xml PRE-CREATION 
>   lens-cli/src/test/resources/schema/dimtables/dim_table.xml PRE-CREATION 
>   lens-cli/src/test/resources/schema/dimtables/dim_table2.xml PRE-CREATION 
>   lens-cli/src/test/resources/schema/facts/fact1.xml PRE-CREATION 
>   lens-cli/src/test/resources/schema/facts/fact_without_weight.xml PRE-CREATION 
>   lens-cli/src/test/resources/schema/segmentations/seg1.xml PRE-CREATION 
>   lens-cli/src/test/resources/schema/storages/local-storage.xml PRE-CREATION 
>   lens-cli/src/test/resources/seg1.xml 8a3991514633bcb25ded0e305bdd50192149773c 
>   lens-cli/src/test/resources/test-detail.xml b51c1888d88436302a7e43ef12d3643fe99b0267 
>   lens-cli/src/test/resources/test-dimension.xml 01de8e69bce7536768bd99d765af3d07f70914a4 
>   src/site/apt/user/cli.apt 2522e03fc80b12bcd64f6df155cd862e4e53e2c2 
> 
> Diff: https://reviews.apache.org/r/51363/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>


Re: Review Request 51363: LENS-1287: Create command in cli to create schema taking parent directory where schema is stored

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51363/
-----------------------------------------------------------

(Updated Oct. 5, 2016, 2:40 p.m.)


Review request for lens.


Bugs: LENS-1287
    https://issues.apache.org/jira/browse/LENS-1287


Repository: lens


Description
-------


Diffs (updated)
-----

  lens-cli/src/main/java/org/apache/lens/cli/commands/LensDatabaseCommands.java 05108f0158b655653f0665da80a2d10b24f33233 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 7df5c7ca1c7f557409ed36a4be7f4b050260f159 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 6457bceef143ce08e6a57726cb1e54dcf3288b0c 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java PRE-CREATION 
  lens-cli/src/test/java/org/apache/lens/cli/LensCLITest.java PRE-CREATION 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java c20766c26c42918e7ab33c32c0b4218ddfa5ee81 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 9687c6089125b4eb9dc2a96fd7d4a140c81eb66c 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a3f01c38d1c94857f0cdfdd7a457b402754c30a6 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 5d6d7682d75793897cc6d2fee0bb23ce7f467ab9 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java b4cbf344c46faa40074bc79fa0227312e027dfb6 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 24f9279b24de98ed1e7304ec2e2010c17df9f8d8 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java e75fc0ef19d9d9b288bdb677bfdf499aa088e6ee 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensSchemaCommands.java PRE-CREATION 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensSegmentationCommands.java e6d4bc5354bbcae9ea6d1f06ec2be6e2ff885cf6 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java c4ab6140c573d8bb4d2048969be14786d2371d6d 
  lens-cli/src/test/java/org/apache/lens/cli/doc/TestGenerateCLIUserDoc.java 95e6b4e205128a19d1099f0a14638a8eb2d19c7c 
  lens-cli/src/test/resources/cube_with_no_weight_facts.xml 4673ca416758c35bf50616896f084360a1b5bb89 
  lens-cli/src/test/resources/dim_table.xml eb4ddfcc49c9cfdc152df35fe863176986016d95 
  lens-cli/src/test/resources/dim_table2.xml 8440e28b59cdcc567bac00e4c1e2367ef2ebda0c 
  lens-cli/src/test/resources/fact1.xml b18a39313bff9850c720cb3f0492bc6b7a650f78 
  lens-cli/src/test/resources/fact_without_weight.xml 0c124b2aba88a9efcc164b3b4de96479c164cd6a 
  lens-cli/src/test/resources/local-storage.xml 65513757f5dc2a19fea88cde4f4fa8736f814091 
  lens-cli/src/test/resources/sample-cube.xml 2d6bc3469466cee6245f8f503af956dcc92cffb5 
  lens-cli/src/test/resources/schema/cubes/base/cube_with_no_weight_facts.xml PRE-CREATION 
  lens-cli/src/test/resources/schema/cubes/base/sample-cube.xml PRE-CREATION 
  lens-cli/src/test/resources/schema/dimensions/test-detail.xml PRE-CREATION 
  lens-cli/src/test/resources/schema/dimensions/test-dimension.xml PRE-CREATION 
  lens-cli/src/test/resources/schema/dimtables/dim_table.xml PRE-CREATION 
  lens-cli/src/test/resources/schema/dimtables/dim_table2.xml PRE-CREATION 
  lens-cli/src/test/resources/schema/facts/fact1.xml PRE-CREATION 
  lens-cli/src/test/resources/schema/facts/fact_without_weight.xml PRE-CREATION 
  lens-cli/src/test/resources/schema/segmentations/seg1.xml PRE-CREATION 
  lens-cli/src/test/resources/schema/storages/local-storage.xml PRE-CREATION 
  lens-cli/src/test/resources/seg1.xml 8a3991514633bcb25ded0e305bdd50192149773c 
  lens-cli/src/test/resources/test-detail.xml b51c1888d88436302a7e43ef12d3643fe99b0267 
  lens-cli/src/test/resources/test-dimension.xml 01de8e69bce7536768bd99d765af3d07f70914a4 
  src/site/apt/user/cli.apt 2522e03fc80b12bcd64f6df155cd862e4e53e2c2 

Diff: https://reviews.apache.org/r/51363/diff/


Testing
-------


Thanks,

Rajat Khandelwal