You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/10/20 00:02:25 UTC

[GitHub] azai91 commented on a change in pull request #12884: adding unittest for MKLDNN softmax operator

azai91 commented on a change in pull request #12884: adding unittest for MKLDNN softmax operator
URL: https://github.com/apache/incubator-mxnet/pull/12884#discussion_r226807278
 
 

 ##########
 File path: tests/cpp/operator/mkldnn.cc
 ##########
 @@ -1306,6 +1326,97 @@ void TestOpEx(const OpAttrs &forward_attrs, const OpAttrs &backwards_attrs) {
   }
 }
 
+// compares output of fcompute with fcomputex
+void TestSoftmaxOp(const OpAttrs &forward_attrs) {
 
 Review comment:
   cant' we just reuse TestOpEx but make the backwards_op optional? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services