You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Damodar Reddy Talakanti <da...@citrix.com> on 2013/10/11 12:07:54 UTC
Review Request 14591: Fixng the issue of wrong netmask value is allowed in
public traffic wizard while creating a zone
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14591/
-----------------------------------------------------------
Review request for cloudstack, Abhinandan Prateek, Jayapal Reddy, and Murali Reddy.
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-4811
Repository: cloudstack-git
Description
-------
The UI Wizard was allowing Invalid CIDR in public traffic page while creating a zone and back end was also not checking the correctness of the CIDR before creating a zone.
Diffs
-----
server/src/com/cloud/configuration/ConfigurationManagerImpl.java b09b8ca
utils/pom.xml f4ac12b
utils/src/com/cloud/utils/net/NetUtils.java 05b485b
Diff: https://reviews.apache.org/r/14591/diff/
Testing
-------
Testing is done through UI
For Example : Given wrong NetMask value 255.255.25.0 which is wrong net mask value
Given Gateway as 10.147.30.1 and NetMask as 255.255.255.192 and public IP Range as 10.147.30.150-10.147.30.159..which is a wrong ip range for the given gateway and net mask values.
Thanks,
Damodar Reddy Talakanti
Re: Review Request 14591: Fixng the issue of wrong netmask value is allowed
in public traffic wizard while creating a zone
Posted by Damodar Reddy Talakanti <da...@citrix.com>.
> On Oct. 17, 2013, 12:55 p.m., Jayapal Reddy wrote:
> > utils/src/com/cloud/utils/net/NetUtils.java, line 38
> > <https://reviews.apache.org/r/14591/diff/3/?file=363781#file363781line38>
> >
> > This patch is failed to apply on master.
uploaded separate patch for master please use newly uploaded file
> On Oct. 17, 2013, 12:55 p.m., Jayapal Reddy wrote:
> > utils/src/com/cloud/utils/net/NetUtils.java, line 1417
> > <https://reviews.apache.org/r/14591/diff/3/?file=363781#file363781line1417>
> >
> > Please remove the tabs here
uploaded separate patch for master please use newly uploaded file
- Damodar Reddy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14591/#review27122
-----------------------------------------------------------
On Oct. 11, 2013, 10:53 a.m., Damodar Reddy Talakanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14591/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2013, 10:53 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Jayapal Reddy, and Murali Reddy.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-4811
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-4811
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The UI Wizard was allowing Invalid CIDR in public traffic page while creating a zone and back end was also not checking the correctness of the CIDR before creating a zone.
>
>
> Diffs
> -----
>
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java b09b8ca
> utils/pom.xml f4ac12b
> utils/src/com/cloud/utils/net/NetUtils.java 05b485b
>
> Diff: https://reviews.apache.org/r/14591/diff/
>
>
> Testing
> -------
>
> Testing is done through UI
> For Example : Given wrong NetMask value 255.255.25.0 which is wrong net mask value
> Given Gateway as 10.147.30.1 and NetMask as 255.255.255.192 and public IP Range as 10.147.30.150-10.147.30.159..which is a wrong ip range for the given gateway and net mask values.
>
>
> Thanks,
>
> Damodar Reddy Talakanti
>
>
Re: Review Request 14591: Fixng the issue of wrong netmask value is allowed
in public traffic wizard while creating a zone
Posted by Jayapal Reddy <ja...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14591/#review27122
-----------------------------------------------------------
utils/src/com/cloud/utils/net/NetUtils.java
<https://reviews.apache.org/r/14591/#comment52770>
This patch is failed to apply on master.
utils/src/com/cloud/utils/net/NetUtils.java
<https://reviews.apache.org/r/14591/#comment52771>
Please remove the tabs here
- Jayapal Reddy
On Oct. 11, 2013, 10:53 a.m., Damodar Reddy Talakanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14591/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2013, 10:53 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Jayapal Reddy, and Murali Reddy.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-4811
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-4811
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The UI Wizard was allowing Invalid CIDR in public traffic page while creating a zone and back end was also not checking the correctness of the CIDR before creating a zone.
>
>
> Diffs
> -----
>
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java b09b8ca
> utils/pom.xml f4ac12b
> utils/src/com/cloud/utils/net/NetUtils.java 05b485b
>
> Diff: https://reviews.apache.org/r/14591/diff/
>
>
> Testing
> -------
>
> Testing is done through UI
> For Example : Given wrong NetMask value 255.255.25.0 which is wrong net mask value
> Given Gateway as 10.147.30.1 and NetMask as 255.255.255.192 and public IP Range as 10.147.30.150-10.147.30.159..which is a wrong ip range for the given gateway and net mask values.
>
>
> Thanks,
>
> Damodar Reddy Talakanti
>
>
Re: Review Request 14591: Fixng the issue of wrong netmask value is allowed
in public traffic wizard while creating a zone
Posted by Jayapal Reddy <ja...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14591/#review27182
-----------------------------------------------------------
Ship it!
Ship It!
- Jayapal Reddy
On Oct. 18, 2013, 9:49 a.m., Damodar Reddy Talakanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14591/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2013, 9:49 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Jayapal Reddy, and Murali Reddy.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-4811
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-4811
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The UI Wizard was allowing Invalid CIDR in public traffic page while creating a zone and back end was also not checking the correctness of the CIDR before creating a zone.
>
>
> Diffs
> -----
>
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 4fda3b1
> utils/pom.xml 35012b2
> utils/src/com/cloud/utils/net/NetUtils.java e64af4c
>
> Diff: https://reviews.apache.org/r/14591/diff/
>
>
> Testing
> -------
>
> Testing is done through UI
> For Example : Given wrong NetMask value 255.255.25.0 which is wrong net mask value
> Given Gateway as 10.147.30.1 and NetMask as 255.255.255.192 and public IP Range as 10.147.30.150-10.147.30.159..which is a wrong ip range for the given gateway and net mask values.
>
>
> Thanks,
>
> Damodar Reddy Talakanti
>
>
Re: Review Request 14591: Fixng the issue of wrong netmask value is allowed
in public traffic wizard while creating a zone
Posted by Damodar Reddy Talakanti <da...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14591/
-----------------------------------------------------------
(Updated Oct. 18, 2013, 9:49 a.m.)
Review request for cloudstack, Abhinandan Prateek, Jayapal Reddy, and Murali Reddy.
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-4811
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-4811
Repository: cloudstack-git
Description
-------
The UI Wizard was allowing Invalid CIDR in public traffic page while creating a zone and back end was also not checking the correctness of the CIDR before creating a zone.
Diffs (updated)
-----
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 4fda3b1
utils/pom.xml 35012b2
utils/src/com/cloud/utils/net/NetUtils.java e64af4c
Diff: https://reviews.apache.org/r/14591/diff/
Testing
-------
Testing is done through UI
For Example : Given wrong NetMask value 255.255.25.0 which is wrong net mask value
Given Gateway as 10.147.30.1 and NetMask as 255.255.255.192 and public IP Range as 10.147.30.150-10.147.30.159..which is a wrong ip range for the given gateway and net mask values.
Thanks,
Damodar Reddy Talakanti
Re: Review Request 14591: Fixng the issue of wrong netmask value is allowed
in public traffic wizard while creating a zone
Posted by Damodar Reddy Talakanti <da...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14591/
-----------------------------------------------------------
(Updated Oct. 18, 2013, 8:36 a.m.)
Review request for cloudstack, Abhinandan Prateek, Jayapal Reddy, and Murali Reddy.
Changes
-------
fixing the tab issues those were causing issue while applying on master
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-4811
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-4811
Repository: cloudstack-git
Description
-------
The UI Wizard was allowing Invalid CIDR in public traffic page while creating a zone and back end was also not checking the correctness of the CIDR before creating a zone.
Diffs (updated)
-----
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 4fda3b1
utils/pom.xml 35012b2
utils/src/com/cloud/utils/net/NetUtils.java e64af4c
Diff: https://reviews.apache.org/r/14591/diff/
Testing
-------
Testing is done through UI
For Example : Given wrong NetMask value 255.255.25.0 which is wrong net mask value
Given Gateway as 10.147.30.1 and NetMask as 255.255.255.192 and public IP Range as 10.147.30.150-10.147.30.159..which is a wrong ip range for the given gateway and net mask values.
Thanks,
Damodar Reddy Talakanti
Re: Review Request 14591: Fixng the issue of wrong netmask value is allowed
in public traffic wizard while creating a zone
Posted by Damodar Reddy Talakanti <da...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14591/
-----------------------------------------------------------
(Updated Oct. 11, 2013, 10:53 a.m.)
Review request for cloudstack, Abhinandan Prateek, Jayapal Reddy, and Murali Reddy.
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-4811
Repository: cloudstack-git
Description
-------
The UI Wizard was allowing Invalid CIDR in public traffic page while creating a zone and back end was also not checking the correctness of the CIDR before creating a zone.
Diffs (updated)
-----
server/src/com/cloud/configuration/ConfigurationManagerImpl.java b09b8ca
utils/pom.xml f4ac12b
utils/src/com/cloud/utils/net/NetUtils.java 05b485b
Diff: https://reviews.apache.org/r/14591/diff/
Testing
-------
Testing is done through UI
For Example : Given wrong NetMask value 255.255.25.0 which is wrong net mask value
Given Gateway as 10.147.30.1 and NetMask as 255.255.255.192 and public IP Range as 10.147.30.150-10.147.30.159..which is a wrong ip range for the given gateway and net mask values.
Thanks,
Damodar Reddy Talakanti
Re: Review Request 14591: Fixng the issue of wrong netmask value is allowed
in public traffic wizard while creating a zone
Posted by Damodar Reddy Talakanti <da...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14591/
-----------------------------------------------------------
(Updated Oct. 11, 2013, 10:48 a.m.)
Review request for cloudstack, Abhinandan Prateek, Jayapal Reddy, and Murali Reddy.
Changes
-------
Remvoed the extra spaces in new line
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-4811
Repository: cloudstack-git
Description
-------
The UI Wizard was allowing Invalid CIDR in public traffic page while creating a zone and back end was also not checking the correctness of the CIDR before creating a zone.
Diffs (updated)
-----
server/src/com/cloud/configuration/ConfigurationManagerImpl.java b09b8ca
utils/pom.xml f4ac12b
utils/src/com/cloud/utils/net/NetUtils.java 05b485b
Diff: https://reviews.apache.org/r/14591/diff/
Testing
-------
Testing is done through UI
For Example : Given wrong NetMask value 255.255.25.0 which is wrong net mask value
Given Gateway as 10.147.30.1 and NetMask as 255.255.255.192 and public IP Range as 10.147.30.150-10.147.30.159..which is a wrong ip range for the given gateway and net mask values.
Thanks,
Damodar Reddy Talakanti
Re: Review Request 14591: Fixng the issue of wrong netmask value is allowed
in public traffic wizard while creating a zone
Posted by Jayapal Reddy <ja...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14591/#review26926
-----------------------------------------------------------
server/src/com/cloud/configuration/ConfigurationManagerImpl.java
<https://reviews.apache.org/r/14591/#comment52441>
Please remove white spaces
utils/src/com/cloud/utils/net/NetUtils.java
<https://reviews.apache.org/r/14591/#comment52442>
Please remove white spaces
- Jayapal Reddy
On Oct. 11, 2013, 10:07 a.m., Damodar Reddy Talakanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14591/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2013, 10:07 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek, Jayapal Reddy, and Murali Reddy.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-4811
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The UI Wizard was allowing Invalid CIDR in public traffic page while creating a zone and back end was also not checking the correctness of the CIDR before creating a zone.
>
>
> Diffs
> -----
>
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java b09b8ca
> utils/pom.xml f4ac12b
> utils/src/com/cloud/utils/net/NetUtils.java 05b485b
>
> Diff: https://reviews.apache.org/r/14591/diff/
>
>
> Testing
> -------
>
> Testing is done through UI
> For Example : Given wrong NetMask value 255.255.25.0 which is wrong net mask value
> Given Gateway as 10.147.30.1 and NetMask as 255.255.255.192 and public IP Range as 10.147.30.150-10.147.30.159..which is a wrong ip range for the given gateway and net mask values.
>
>
> Thanks,
>
> Damodar Reddy Talakanti
>
>