You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Zsombor Gegesy <zs...@apache.org> on 2019/01/02 22:52:48 UTC
Review Request 69655: RANGER-2317 : make Ranger buildable on newer
JDKs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69655/
-----------------------------------------------------------
Review request for ranger.
Bugs: RANGER-2317
https://issues.apache.org/jira/browse/RANGER-2317
Repository: ranger
Description
-------
Upgrade librarias to become compatible with JDK11, and JAXB and other librarias to the modules, and exclude jdk.tools.
(These modules was previously part of the JDK, now they are independent).
Add JDK10/11 to the travis build - with excluding the Hive tests, as we can't even start the Hive tests on JDK 9 - because internal Hive code cast the system classloader to URLClassLoader.
Removed one empty test class file, which triggered test failures with newer mockito version.
Diffs
-----
.travis.yml b38b892bd21287b21d575aba862d93fd46952ac6
hbase-agent/pom.xml c044ef0c30f348cd82d3ef37089677c8d83b5db8
kms/pom.xml 043c67fde4eb6617c7e3b8d852f0aa471e032161
knox-agent/pom.xml 0c45c84baae8afb50f7c130f611ccaa00dda4406
plugin-solr/pom.xml 619cc9ebdbac883fb3e981843b82bd0c35f8508c
pom.xml 2a2540a0d578911a9f84cffcd861d37767cc156f
ranger-hbase-plugin-shim/pom.xml 9ed0aebe8e80a63817f0ba0d18039f5e15a6bab2
ranger-solr-plugin-shim/pom.xml 46b78218a8c2c7ec142da159e867a2d38390e630
security-admin/pom.xml c67860115f55719c244cd82ed823a471a6f25114
security-admin/src/test/java/org/apache/ranger/plugin/store/RangerDBStore.java cd5bb384e4e8f2e51ec59e0dff6134990fa192ff
ugsync/src/test/java/org/apache/ranger/unixusersync/process/TestUnixUserGroupBuilder.java 2118c8430d885252590d7bcde4216ce9505ae7bc
Diff: https://reviews.apache.org/r/69655/diff/1/
Testing
-------
Tested resulting binaries locally on JDK 8, to stay the same as previously. All the dependency change was either in test code, or in Maven plugin config, or has 'provided' scope.
Tested on Travis that build is succesfull in 4 JVMs - oraclejdk8/oraclejdk11/openjdk10/openjdk11:
https://travis-ci.org/gzsombor/ranger/builds/474559352
Thanks,
Zsombor Gegesy
Re: Review Request 69655: RANGER-2317 : make Ranger buildable on
newer JDKs
Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69655/#review213014
-----------------------------------------------------------
Tested Ranger installation in OpenJDK 10, 11 and Oracle JDK-11.
Observations: Below mentioned java arguments needs to be removed from the ranger-admin-services.sh file for the successful start of ranger admin service as they are deprecated.
UseGCLogFileRotation
NumberOfGCLogFiles=10
GCLogFileSize=1m
PrintHeapAtGC
PrintGCDateStamps
- Pradeep Agrawal
On Jan. 7, 2019, 8:30 p.m., Zsombor Gegesy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69655/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2019, 8:30 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-2317
> https://issues.apache.org/jira/browse/RANGER-2317
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Upgrade librarias to become compatible with JDK11, and JAXB and other librarias to the modules, and exclude jdk.tools.
> (These modules was previously part of the JDK, now they are independent).
> Add JDK10/11 to the travis build - with excluding the Hive tests, as we can't even start the Hive tests on JDK 9 - because internal Hive code cast the system classloader to URLClassLoader.
> Removed one empty test class file, which triggered test failures with newer mockito version.
>
>
> Diffs
> -----
>
> .travis.yml b38b892bd
> enunciate.xml f64af1a56
> hbase-agent/pom.xml c044ef0c3
> kms/pom.xml 043c67fde
> knox-agent/pom.xml 0c45c84ba
> plugin-solr/pom.xml 619cc9ebd
> pom.xml 2a2540a0d
> ranger-hbase-plugin-shim/pom.xml 9ed0aebe8
> ranger-solr-plugin-shim/pom.xml 46b78218a
> security-admin/pom.xml 14cafb4b2
> security-admin/src/test/java/org/apache/ranger/plugin/store/RangerDBStore.java cd5bb384e
> ugsync/src/test/java/org/apache/ranger/unixusersync/process/TestUnixUserGroupBuilder.java 2118c8430
>
>
> Diff: https://reviews.apache.org/r/69655/diff/2/
>
>
> Testing
> -------
>
> Tested resulting binaries locally on JDK 8, to stay the same as previously. All the dependency change was either in test code, or in Maven plugin config, or has 'provided' scope.
>
> Tested on Travis that build is succesfull in 4 JVMs - oraclejdk8/oraclejdk11/openjdk10/openjdk11:
> https://travis-ci.org/gzsombor/ranger/builds/474559352
>
>
> Thanks,
>
> Zsombor Gegesy
>
>
Re: Review Request 69655: RANGER-2317 : make Ranger buildable on
newer JDKs
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69655/#review213536
-----------------------------------------------------------
hbase-agent/pom.xml
Line 36 (original), 36 (patched)
<https://reviews.apache.org/r/69655/#comment299487>
Could you please rebase this patch? Thanks.
- Velmurugan Periasamy
On Feb. 22, 2019, 8:51 a.m., Zsombor Gegesy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69655/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2019, 8:51 a.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-2317
> https://issues.apache.org/jira/browse/RANGER-2317
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Upgrade librarias to become compatible with JDK11, and JAXB and other librarias to the modules, and exclude jdk.tools.
> (These modules was previously part of the JDK, now they are independent).
> Add JDK10/11 to the travis build - with excluding the Hive tests, as we can't even start the Hive tests on JDK 9 - because internal Hive code cast the system classloader to URLClassLoader.
> Removed one empty test class file, which triggered test failures with newer mockito version.
>
>
> Diffs
> -----
>
> .travis.yml b38b892bd
> embeddedwebserver/scripts/ranger-admin-services.sh c04e1fc72
> enunciate.xml f64af1a56
> hbase-agent/pom.xml c044ef0c3
> kms/pom.xml 043c67fde
> knox-agent/pom.xml 0c45c84ba
> plugin-solr/pom.xml 619cc9ebd
> pom.xml 2a2540a0d
> ranger-hbase-plugin-shim/pom.xml 9ed0aebe8
> ranger-solr-plugin-shim/pom.xml 46b78218a
> security-admin/pom.xml 479f46d05
> security-admin/src/test/java/org/apache/ranger/plugin/store/RangerDBStore.java cd5bb384e
> ugsync/src/test/java/org/apache/ranger/unixusersync/process/TestUnixUserGroupBuilder.java 2118c8430
>
>
> Diff: https://reviews.apache.org/r/69655/diff/3/
>
>
> Testing
> -------
>
> Tested resulting binaries locally on JDK 8, to stay the same as previously. All the dependency change was either in test code, or in Maven plugin config, or has 'provided' scope.
>
> Tested on Travis that build is succesfull in 4 JVMs - oraclejdk8/oraclejdk11/openjdk10/openjdk11:
> https://travis-ci.org/gzsombor/ranger/builds/474559352
>
>
> Thanks,
>
> Zsombor Gegesy
>
>
Re: Review Request 69655: RANGER-2317 : make Ranger buildable on
newer JDKs
Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69655/#review213616
-----------------------------------------------------------
Ship it!
Ship It!
- Pradeep Agrawal
On March 11, 2019, 7:10 p.m., Zsombor Gegesy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69655/
> -----------------------------------------------------------
>
> (Updated March 11, 2019, 7:10 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-2317
> https://issues.apache.org/jira/browse/RANGER-2317
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Upgrade librarias to become compatible with JDK11, and JAXB and other librarias to the modules, and exclude jdk.tools.
> (These modules was previously part of the JDK, now they are independent).
> Add JDK10/11 to the travis build - with excluding the Hive tests, as we can't even start the Hive tests on JDK 9 - because internal Hive code cast the system classloader to URLClassLoader.
> Removed one empty test class file, which triggered test failures with newer mockito version.
>
>
> Diffs
> -----
>
> .travis.yml b38b892bd
> embeddedwebserver/scripts/ranger-admin-services.sh c04e1fc72
> enunciate.xml f64af1a56
> hbase-agent/pom.xml 6b3763f22
> kms/pom.xml 59dd2761f
> knox-agent/pom.xml bd68221cc
> plugin-solr/pom.xml 619cc9ebd
> pom.xml d5c4e924a
> ranger-hbase-plugin-shim/pom.xml 9ed0aebe8
> ranger-solr-plugin-shim/pom.xml 46b78218a
> security-admin/pom.xml 2c587605b
> security-admin/src/test/java/org/apache/ranger/plugin/store/RangerDBStore.java cd5bb384e
> ugsync/src/test/java/org/apache/ranger/unixusersync/process/TestUnixUserGroupBuilder.java 2118c8430
>
>
> Diff: https://reviews.apache.org/r/69655/diff/4/
>
>
> Testing
> -------
>
> Tested resulting binaries locally on JDK 8, to stay the same as previously. All the dependency change was either in test code, or in Maven plugin config, or has 'provided' scope.
>
> Tested on Travis that build is succesfull in 4 JVMs - oraclejdk8/oraclejdk11/openjdk10/openjdk11:
> https://travis-ci.org/gzsombor/ranger/builds/474559352
>
>
> Thanks,
>
> Zsombor Gegesy
>
>
Re: Review Request 69655: RANGER-2317 : make Ranger buildable on
newer JDKs
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69655/#review213656
-----------------------------------------------------------
Ship it!
Ship It!
- Qiang Zhang
On 三月 11, 2019, 7:10 p.m., Zsombor Gegesy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69655/
> -----------------------------------------------------------
>
> (Updated 三月 11, 2019, 7:10 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-2317
> https://issues.apache.org/jira/browse/RANGER-2317
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Upgrade librarias to become compatible with JDK11, and JAXB and other librarias to the modules, and exclude jdk.tools.
> (These modules was previously part of the JDK, now they are independent).
> Add JDK10/11 to the travis build - with excluding the Hive tests, as we can't even start the Hive tests on JDK 9 - because internal Hive code cast the system classloader to URLClassLoader.
> Removed one empty test class file, which triggered test failures with newer mockito version.
>
>
> Diffs
> -----
>
> .travis.yml b38b892bd
> embeddedwebserver/scripts/ranger-admin-services.sh c04e1fc72
> enunciate.xml f64af1a56
> hbase-agent/pom.xml 6b3763f22
> kms/pom.xml 59dd2761f
> knox-agent/pom.xml bd68221cc
> plugin-solr/pom.xml 619cc9ebd
> pom.xml d5c4e924a
> ranger-hbase-plugin-shim/pom.xml 9ed0aebe8
> ranger-solr-plugin-shim/pom.xml 46b78218a
> security-admin/pom.xml 2c587605b
> security-admin/src/test/java/org/apache/ranger/plugin/store/RangerDBStore.java cd5bb384e
> ugsync/src/test/java/org/apache/ranger/unixusersync/process/TestUnixUserGroupBuilder.java 2118c8430
>
>
> Diff: https://reviews.apache.org/r/69655/diff/4/
>
>
> Testing
> -------
>
> Tested resulting binaries locally on JDK 8, to stay the same as previously. All the dependency change was either in test code, or in Maven plugin config, or has 'provided' scope.
>
> Tested on Travis that build is succesfull in 4 JVMs - oraclejdk8/oraclejdk11/openjdk10/openjdk11:
> https://travis-ci.org/gzsombor/ranger/builds/474559352
>
>
> Thanks,
>
> Zsombor Gegesy
>
>
Re: Review Request 69655: RANGER-2317 : make Ranger buildable on
newer JDKs
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69655/#review213646
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On March 11, 2019, 7:10 p.m., Zsombor Gegesy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69655/
> -----------------------------------------------------------
>
> (Updated March 11, 2019, 7:10 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-2317
> https://issues.apache.org/jira/browse/RANGER-2317
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Upgrade librarias to become compatible with JDK11, and JAXB and other librarias to the modules, and exclude jdk.tools.
> (These modules was previously part of the JDK, now they are independent).
> Add JDK10/11 to the travis build - with excluding the Hive tests, as we can't even start the Hive tests on JDK 9 - because internal Hive code cast the system classloader to URLClassLoader.
> Removed one empty test class file, which triggered test failures with newer mockito version.
>
>
> Diffs
> -----
>
> .travis.yml b38b892bd
> embeddedwebserver/scripts/ranger-admin-services.sh c04e1fc72
> enunciate.xml f64af1a56
> hbase-agent/pom.xml 6b3763f22
> kms/pom.xml 59dd2761f
> knox-agent/pom.xml bd68221cc
> plugin-solr/pom.xml 619cc9ebd
> pom.xml d5c4e924a
> ranger-hbase-plugin-shim/pom.xml 9ed0aebe8
> ranger-solr-plugin-shim/pom.xml 46b78218a
> security-admin/pom.xml 2c587605b
> security-admin/src/test/java/org/apache/ranger/plugin/store/RangerDBStore.java cd5bb384e
> ugsync/src/test/java/org/apache/ranger/unixusersync/process/TestUnixUserGroupBuilder.java 2118c8430
>
>
> Diff: https://reviews.apache.org/r/69655/diff/4/
>
>
> Testing
> -------
>
> Tested resulting binaries locally on JDK 8, to stay the same as previously. All the dependency change was either in test code, or in Maven plugin config, or has 'provided' scope.
>
> Tested on Travis that build is succesfull in 4 JVMs - oraclejdk8/oraclejdk11/openjdk10/openjdk11:
> https://travis-ci.org/gzsombor/ranger/builds/474559352
>
>
> Thanks,
>
> Zsombor Gegesy
>
>
Re: Review Request 69655: RANGER-2317 : make Ranger buildable on
newer JDKs
Posted by Zsombor Gegesy <zs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69655/
-----------------------------------------------------------
(Updated March 11, 2019, 7:10 p.m.)
Review request for ranger.
Bugs: RANGER-2317
https://issues.apache.org/jira/browse/RANGER-2317
Repository: ranger
Description
-------
Upgrade librarias to become compatible with JDK11, and JAXB and other librarias to the modules, and exclude jdk.tools.
(These modules was previously part of the JDK, now they are independent).
Add JDK10/11 to the travis build - with excluding the Hive tests, as we can't even start the Hive tests on JDK 9 - because internal Hive code cast the system classloader to URLClassLoader.
Removed one empty test class file, which triggered test failures with newer mockito version.
Diffs (updated)
-----
.travis.yml b38b892bd
embeddedwebserver/scripts/ranger-admin-services.sh c04e1fc72
enunciate.xml f64af1a56
hbase-agent/pom.xml 6b3763f22
kms/pom.xml 59dd2761f
knox-agent/pom.xml bd68221cc
plugin-solr/pom.xml 619cc9ebd
pom.xml d5c4e924a
ranger-hbase-plugin-shim/pom.xml 9ed0aebe8
ranger-solr-plugin-shim/pom.xml 46b78218a
security-admin/pom.xml 2c587605b
security-admin/src/test/java/org/apache/ranger/plugin/store/RangerDBStore.java cd5bb384e
ugsync/src/test/java/org/apache/ranger/unixusersync/process/TestUnixUserGroupBuilder.java 2118c8430
Diff: https://reviews.apache.org/r/69655/diff/4/
Changes: https://reviews.apache.org/r/69655/diff/3-4/
Testing
-------
Tested resulting binaries locally on JDK 8, to stay the same as previously. All the dependency change was either in test code, or in Maven plugin config, or has 'provided' scope.
Tested on Travis that build is succesfull in 4 JVMs - oraclejdk8/oraclejdk11/openjdk10/openjdk11:
https://travis-ci.org/gzsombor/ranger/builds/474559352
Thanks,
Zsombor Gegesy
Re: Review Request 69655: RANGER-2317 : make Ranger buildable on
newer JDKs
Posted by Zsombor Gegesy <zs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69655/
-----------------------------------------------------------
(Updated Feb. 22, 2019, 8:51 a.m.)
Review request for ranger.
Changes
-------
Incorporate review feedback
Bugs: RANGER-2317
https://issues.apache.org/jira/browse/RANGER-2317
Repository: ranger
Description
-------
Upgrade librarias to become compatible with JDK11, and JAXB and other librarias to the modules, and exclude jdk.tools.
(These modules was previously part of the JDK, now they are independent).
Add JDK10/11 to the travis build - with excluding the Hive tests, as we can't even start the Hive tests on JDK 9 - because internal Hive code cast the system classloader to URLClassLoader.
Removed one empty test class file, which triggered test failures with newer mockito version.
Diffs (updated)
-----
.travis.yml b38b892bd
embeddedwebserver/scripts/ranger-admin-services.sh c04e1fc72
enunciate.xml f64af1a56
hbase-agent/pom.xml c044ef0c3
kms/pom.xml 043c67fde
knox-agent/pom.xml 0c45c84ba
plugin-solr/pom.xml 619cc9ebd
pom.xml 2a2540a0d
ranger-hbase-plugin-shim/pom.xml 9ed0aebe8
ranger-solr-plugin-shim/pom.xml 46b78218a
security-admin/pom.xml 479f46d05
security-admin/src/test/java/org/apache/ranger/plugin/store/RangerDBStore.java cd5bb384e
ugsync/src/test/java/org/apache/ranger/unixusersync/process/TestUnixUserGroupBuilder.java 2118c8430
Diff: https://reviews.apache.org/r/69655/diff/3/
Changes: https://reviews.apache.org/r/69655/diff/2-3/
Testing
-------
Tested resulting binaries locally on JDK 8, to stay the same as previously. All the dependency change was either in test code, or in Maven plugin config, or has 'provided' scope.
Tested on Travis that build is succesfull in 4 JVMs - oraclejdk8/oraclejdk11/openjdk10/openjdk11:
https://travis-ci.org/gzsombor/ranger/builds/474559352
Thanks,
Zsombor Gegesy
Re: Review Request 69655: RANGER-2317 : make Ranger buildable on
newer JDKs
Posted by Zsombor Gegesy <zs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69655/
-----------------------------------------------------------
(Updated Jan. 7, 2019, 8:30 p.m.)
Review request for ranger.
Changes
-------
Fix enunciate documentation generation
Bugs: RANGER-2317
https://issues.apache.org/jira/browse/RANGER-2317
Repository: ranger
Description
-------
Upgrade librarias to become compatible with JDK11, and JAXB and other librarias to the modules, and exclude jdk.tools.
(These modules was previously part of the JDK, now they are independent).
Add JDK10/11 to the travis build - with excluding the Hive tests, as we can't even start the Hive tests on JDK 9 - because internal Hive code cast the system classloader to URLClassLoader.
Removed one empty test class file, which triggered test failures with newer mockito version.
Diffs (updated)
-----
.travis.yml b38b892bd
enunciate.xml f64af1a56
hbase-agent/pom.xml c044ef0c3
kms/pom.xml 043c67fde
knox-agent/pom.xml 0c45c84ba
plugin-solr/pom.xml 619cc9ebd
pom.xml 2a2540a0d
ranger-hbase-plugin-shim/pom.xml 9ed0aebe8
ranger-solr-plugin-shim/pom.xml 46b78218a
security-admin/pom.xml 14cafb4b2
security-admin/src/test/java/org/apache/ranger/plugin/store/RangerDBStore.java cd5bb384e
ugsync/src/test/java/org/apache/ranger/unixusersync/process/TestUnixUserGroupBuilder.java 2118c8430
Diff: https://reviews.apache.org/r/69655/diff/2/
Changes: https://reviews.apache.org/r/69655/diff/1-2/
Testing
-------
Tested resulting binaries locally on JDK 8, to stay the same as previously. All the dependency change was either in test code, or in Maven plugin config, or has 'provided' scope.
Tested on Travis that build is succesfull in 4 JVMs - oraclejdk8/oraclejdk11/openjdk10/openjdk11:
https://travis-ci.org/gzsombor/ranger/builds/474559352
Thanks,
Zsombor Gegesy