You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/10/20 11:09:47 UTC
[GitHub] [cordova-android] anasofiagribeiro opened a new pull request #1104: Improve energy efficiency by applying Reduce Size Energy Pattern
anasofiagribeiro opened a new pull request #1104:
URL: https://github.com/apache/cordova-android/pull/1104
This improves the energy efficiency of cordova-android by applying the Reduce Size Energy Pattern for mobile applications.
The energy pattern was applied in CordovaResourceApi.java. The general idea is when receiving data from an URLConnection or subclasses, if possible, receive the data compressed by GZIP scheme. In this specific case, when receiving data from the conn variable, request for the data to be compressed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu merged pull request #1104: feat: support gzip encoding requests & use GZIPInputStream
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #1104:
URL: https://github.com/apache/cordova-android/pull/1104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on pull request #1104: Improve energy efficiency by applying Reduce Size Energy Pattern
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1104:
URL: https://github.com/apache/cordova-android/pull/1104#issuecomment-712776068
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1104?src=pr&el=h1) Report
> Merging [#1104](https://codecov.io/gh/apache/cordova-android/pull/1104?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/335b0f2575bdcb432583132f17b5f141c64e7c0b?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/1104?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1104 +/- ##
=======================================
Coverage 69.71% 69.71%
=======================================
Files 20 20
Lines 1806 1806
=======================================
Hits 1259 1259
Misses 547 547
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1104?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1104?src=pr&el=footer). Last update [335b0f2...c9a71d4](https://codecov.io/gh/apache/cordova-android/pull/1104?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on pull request #1104: Improve energy efficiency by applying Reduce Size Energy Pattern
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1104:
URL: https://github.com/apache/cordova-android/pull/1104#issuecomment-712776068
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1104?src=pr&el=h1) Report
> Merging [#1104](https://codecov.io/gh/apache/cordova-android/pull/1104?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/335b0f2575bdcb432583132f17b5f141c64e7c0b?el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/1104?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1104 +/- ##
==========================================
- Coverage 69.71% 69.65% -0.06%
==========================================
Files 20 20
Lines 1806 1806
==========================================
- Hits 1259 1258 -1
- Misses 547 548 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1104?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1104/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `58.49% <0.00%> (-0.48%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1104?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1104?src=pr&el=footer). Last update [335b0f2...c9a71d4](https://codecov.io/gh/apache/cordova-android/pull/1104?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu commented on pull request #1104: feat: support gzip encoding requests & use GZIPInputStream
Posted by GitBox <gi...@apache.org>.
erisu commented on pull request #1104:
URL: https://github.com/apache/cordova-android/pull/1104#issuecomment-815447263
> @erisu already made a declaration for 9.1 so I think master should remain frozen.
If this PR can fit in the minor release, then it is still acceptable to be merged into the master branch, at this time.
When a discussion thread is made for a release, PRs can still be merged into the master branch as long as the PRs are fitting for that target release.
Only when a vote thread is created is when the master branch is completely frozen and no PRs should be merged in temporarily. This is so that if the vote fails for any reason, it can be easily corrected and resubmitted. (Even after a vote failure, more PRs could be merged in for the targeted release. hehe)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] timbru31 commented on pull request #1104: feat: support gzip encoding requests & use GZIPInputStream
Posted by GitBox <gi...@apache.org>.
timbru31 commented on pull request #1104:
URL: https://github.com/apache/cordova-android/pull/1104#issuecomment-814973980
IMHO this could fit into the 9.1.0 release, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek commented on pull request #1104: feat: support gzip encoding requests & use GZIPInputStream
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #1104:
URL: https://github.com/apache/cordova-android/pull/1104#issuecomment-815028320
> IMHO this could fit into the 9.1.0 release, too.
While I think this is okay to be in a minor release, @erisu already made a declaration for 9.1 so I think master should remain frozen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on pull request #1104: Improve energy efficiency by applying Reduce Size Energy Pattern
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1104:
URL: https://github.com/apache/cordova-android/pull/1104#issuecomment-712776068
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1104?src=pr&el=h1) Report
> Merging [#1104](https://codecov.io/gh/apache/cordova-android/pull/1104?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/335b0f2575bdcb432583132f17b5f141c64e7c0b?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/1104?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1104 +/- ##
=======================================
Coverage 69.71% 69.71%
=======================================
Files 20 20
Lines 1806 1806
=======================================
Hits 1259 1259
Misses 547 547
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1104?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1104?src=pr&el=footer). Last update [335b0f2...c9a71d4](https://codecov.io/gh/apache/cordova-android/pull/1104?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io commented on pull request #1104: Improve energy efficiency by applying Reduce Size Energy Pattern
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1104:
URL: https://github.com/apache/cordova-android/pull/1104#issuecomment-712776068
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1104?src=pr&el=h1) Report
> Merging [#1104](https://codecov.io/gh/apache/cordova-android/pull/1104?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/335b0f2575bdcb432583132f17b5f141c64e7c0b?el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/1104?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1104 +/- ##
==========================================
- Coverage 69.71% 69.65% -0.06%
==========================================
Files 20 20
Lines 1806 1806
==========================================
- Hits 1259 1258 -1
- Misses 547 548 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1104?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1104/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `58.49% <0.00%> (-0.48%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1104?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1104?src=pr&el=footer). Last update [335b0f2...c9a71d4](https://codecov.io/gh/apache/cordova-android/pull/1104?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org