You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/08/18 09:44:14 UTC

[GitHub] [camel-k] orpiske opened a new pull request #2580: Reworked logging trait dependencies

orpiske opened a new pull request #2580:
URL: https://github.com/apache/camel-k/pull/2580


   As part of GH issue apache/camel-k#2541, moved the dependency to the runtime to ensure it's always present, even with custom base images or other customizations. This also allow us to manage the dependencies on a single place instead of spreading them over the codebase.
   
   Depends on apache/camel-k-runtime#731
   
   
   <!-- Description -->
   
   
   
   
   <!--
   Enter your extended release note in the below block. If the PR requires
   additional action from users switching to the new release, include the string
   "action required". If no release note is required, write "NONE". 
   
   You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
   the text is added to the right section of the release notes. 
   -->
   
   **Release Note**
   ```release-note
   NONE
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] orpiske merged pull request #2580: Reworked logging trait dependencies

Posted by GitBox <gi...@apache.org>.
orpiske merged pull request #2580:
URL: https://github.com/apache/camel-k/pull/2580


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti commented on a change in pull request #2580: Reworked logging trait dependencies

Posted by GitBox <gi...@apache.org>.
astefanutti commented on a change in pull request #2580:
URL: https://github.com/apache/camel-k/pull/2580#discussion_r691127728



##########
File path: pkg/trait/logging.go
##########
@@ -68,17 +66,6 @@ func (l loggingTrait) Configure(environment *Environment) (bool, error) {
 }
 
 func (l loggingTrait) Apply(environment *Environment) error {
-	if environment.IntegrationInPhase(v1.IntegrationPhaseInitialization) {

Review comment:
       I think running the trait during the `IntegrationPhaseInitialization` phase is not needed anymore :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] orpiske commented on pull request #2580: Reworked logging trait dependencies

Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #2580:
URL: https://github.com/apache/camel-k/pull/2580#issuecomment-900974522


   Added bonus of this is that the container does not required a rebuild if the `logging.json` trait is turned on or off. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] orpiske merged pull request #2580: Reworked logging trait dependencies

Posted by GitBox <gi...@apache.org>.
orpiske merged pull request #2580:
URL: https://github.com/apache/camel-k/pull/2580


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] orpiske commented on pull request #2580: Reworked logging trait dependencies

Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #2580:
URL: https://github.com/apache/camel-k/pull/2580#issuecomment-900974522






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] orpiske commented on a change in pull request #2580: Reworked logging trait dependencies

Posted by GitBox <gi...@apache.org>.
orpiske commented on a change in pull request #2580:
URL: https://github.com/apache/camel-k/pull/2580#discussion_r691122715



##########
File path: pkg/trait/logging.go
##########
@@ -73,7 +71,6 @@ func (l loggingTrait) Apply(environment *Environment) error {
 			if environment.Integration.Status.Dependencies == nil {
 				environment.Integration.Status.Dependencies = make([]string, 0)
 			}
-			util.StringSliceUniqueAdd(&environment.Integration.Status.Dependencies, depQuarkusLoggingJson)

Review comment:
       Thanks! Yes it can be removed. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] orpiske commented on a change in pull request #2580: Reworked logging trait dependencies

Posted by GitBox <gi...@apache.org>.
orpiske commented on a change in pull request #2580:
URL: https://github.com/apache/camel-k/pull/2580#discussion_r691131435



##########
File path: pkg/trait/logging.go
##########
@@ -68,17 +66,6 @@ func (l loggingTrait) Configure(environment *Environment) (bool, error) {
 }
 
 func (l loggingTrait) Apply(environment *Environment) error {
-	if environment.IntegrationInPhase(v1.IntegrationPhaseInitialization) {

Review comment:
       ... and it's gone! :D 
   
   Thanks!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti commented on a change in pull request #2580: Reworked logging trait dependencies

Posted by GitBox <gi...@apache.org>.
astefanutti commented on a change in pull request #2580:
URL: https://github.com/apache/camel-k/pull/2580#discussion_r691099225



##########
File path: pkg/trait/logging.go
##########
@@ -73,7 +71,6 @@ func (l loggingTrait) Apply(environment *Environment) error {
 			if environment.Integration.Status.Dependencies == nil {
 				environment.Integration.Status.Dependencies = make([]string, 0)
 			}
-			util.StringSliceUniqueAdd(&environment.Integration.Status.Dependencies, depQuarkusLoggingJson)

Review comment:
       It seems like the whole code block can be removed?

##########
File path: pkg/trait/logging.go
##########
@@ -68,17 +66,6 @@ func (l loggingTrait) Configure(environment *Environment) (bool, error) {
 }
 
 func (l loggingTrait) Apply(environment *Environment) error {
-	if environment.IntegrationInPhase(v1.IntegrationPhaseInitialization) {

Review comment:
       I think running the trait during the `IntegrationPhaseInitialization` phase is not needed anymore :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti commented on a change in pull request #2580: Reworked logging trait dependencies

Posted by GitBox <gi...@apache.org>.
astefanutti commented on a change in pull request #2580:
URL: https://github.com/apache/camel-k/pull/2580#discussion_r691099225



##########
File path: pkg/trait/logging.go
##########
@@ -73,7 +71,6 @@ func (l loggingTrait) Apply(environment *Environment) error {
 			if environment.Integration.Status.Dependencies == nil {
 				environment.Integration.Status.Dependencies = make([]string, 0)
 			}
-			util.StringSliceUniqueAdd(&environment.Integration.Status.Dependencies, depQuarkusLoggingJson)

Review comment:
       It seems like the whole code block can be removed?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] orpiske commented on a change in pull request #2580: Reworked logging trait dependencies

Posted by GitBox <gi...@apache.org>.
orpiske commented on a change in pull request #2580:
URL: https://github.com/apache/camel-k/pull/2580#discussion_r691122715



##########
File path: pkg/trait/logging.go
##########
@@ -73,7 +71,6 @@ func (l loggingTrait) Apply(environment *Environment) error {
 			if environment.Integration.Status.Dependencies == nil {
 				environment.Integration.Status.Dependencies = make([]string, 0)
 			}
-			util.StringSliceUniqueAdd(&environment.Integration.Status.Dependencies, depQuarkusLoggingJson)

Review comment:
       Thanks! Yes it can be removed. 

##########
File path: pkg/trait/logging.go
##########
@@ -68,17 +66,6 @@ func (l loggingTrait) Configure(environment *Environment) (bool, error) {
 }
 
 func (l loggingTrait) Apply(environment *Environment) error {
-	if environment.IntegrationInPhase(v1.IntegrationPhaseInitialization) {

Review comment:
       ... and it's gone! :D 
   
   Thanks!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org