You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by tdas <gi...@git.apache.org> on 2015/09/24 03:41:18 UTC
[GitHub] spark pull request: [Spark-10692][Streaming] Expose failureReasons...
GitHub user tdas opened a pull request:
https://github.com/apache/spark/pull/8892
[Spark-10692][Streaming] Expose failureReasons in BatchInfo for streaming UI to clear failed batches
Slightly modified version of #8818, all credit goes to @zsxwing
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tdas/spark SPARK-10692
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/8892.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #8892
----
commit 30aa83ab791cd3bb3856d5b71322e66981054008
Author: zsxwing <zs...@gmail.com>
Date: 2015-09-18T13:46:23Z
Report the batch error to StreamingListener.onBatchCompleted
commit e87a1ca63f026a2af08a2d7aa26a40bfb907f451
Author: zsxwing <zs...@gmail.com>
Date: 2015-09-23T07:48:46Z
Expose failureReasons in BatchInfo
commit 5e4ab1f06bb70bd5a3142d4b369c9db362a89d93
Author: zsxwing <zs...@gmail.com>
Date: 2015-09-23T07:57:12Z
Merge branch 'master' into SPARK-10692
commit 693ff74da410ec14954774e75445a42980951bc8
Author: zsxwing <zs...@gmail.com>
Date: 2015-09-23T08:15:15Z
case Success(_) -> case _
commit a1439e0d87755c80b0f6b756ec8a76345c1f1453
Author: zsxwing <zs...@gmail.com>
Date: 2015-09-23T08:37:36Z
Keep failureReasons private[streaming]
commit f33cd9c6d529ced98dc16c75210db49c595e1ee3
Author: zsxwing <zs...@gmail.com>
Date: 2015-09-23T08:39:48Z
Fix the code style
commit fdf39eed9a745ced40fd36fccd3351e2f449ff4a
Author: zsxwing <zs...@gmail.com>
Date: 2015-09-23T08:46:12Z
Add constructor and apply for binary compatibility
commit af6562f41a45e682d61eb9b7abffdd5708d11a82
Author: zsxwing <zs...@gmail.com>
Date: 2015-09-23T09:09:50Z
Refactor unit tests to eliminate duplicate codes
commit fef3a0dd22ea6e30998feedb89a4b5bdb3768411
Author: Tathagata Das <ta...@gmail.com>
Date: 2015-09-24T01:38:34Z
Addressed TD's comments
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Spark-10692][Streaming] Expose failureReasons...
Posted by tdas <gi...@git.apache.org>.
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/8892#issuecomment-142788927
Merging this master and 1.5
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Spark-10692][Streaming] Expose failureReasons...
Posted by tdas <gi...@git.apache.org>.
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/8892#issuecomment-142782295
@harishreedharan I took over the PR that @zsxwing was doing to speed up the process... 1.5.1 to be cut any time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Spark-10692][Streaming] Expose failureReasons...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/8892#issuecomment-142788937
I've merged this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Spark-10692][Streaming] Expose failureReasons...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8892#issuecomment-142790329
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Spark-10692][Streaming] Expose failureReasons...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8892#issuecomment-142779917
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Spark-10692][Streaming] Expose failureReasons...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8892#issuecomment-142779931
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Spark-10692][Streaming] Expose failureReasons...
Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/8892#issuecomment-142780326
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Spark-10692][Streaming] Expose failureReasons...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8892
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Spark-10692][Streaming] Expose failureReasons...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8892#issuecomment-142790333
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42948/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Spark-10692][Streaming] Expose failureReasons...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8892#issuecomment-142780584
[Test build #42948 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42948/consoleFull) for PR 8892 at commit [`fef3a0d`](https://github.com/apache/spark/commit/fef3a0dd22ea6e30998feedb89a4b5bdb3768411).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Spark-10692][Streaming] Expose failureReasons...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8892#issuecomment-142789630
[Test build #42948 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42948/console) for PR 8892 at commit [`fef3a0d`](https://github.com/apache/spark/commit/fef3a0dd22ea6e30998feedb89a4b5bdb3768411).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [Spark-10692][Streaming] Expose failureReasons...
Posted by harishreedharan <gi...@git.apache.org>.
Github user harishreedharan commented on the pull request:
https://github.com/apache/spark/pull/8892#issuecomment-142781672
Is this for a different branch? Why a new PR for the same thing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org