[jira] [Commented] (HADOOP-11819) HttpServerFunctionalTest#prepareTestWebapp should create web app directory if it does not exist.

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-11819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487282#comment-14487282 ] 

Hadoop QA commented on HADOOP-11819:
------------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12724203/0001-HADOOP-11819.patch
  against trunk revision 6495940.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-common.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6085//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6085//console

This message is automatically generated.

> HttpServerFunctionalTest#prepareTestWebapp should create web app directory if it does not exist.
> ------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-11819
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11819
>             Project: Hadoop Common
>          Issue Type: Test
>            Reporter: Rohith
>            Assignee: Rohith
>         Attachments: 0001-HADOOP-11819.patch
>
>
> Test fails if directory does not exist. Ideally Test should create the non existent directory and execute.
> {noformat}
> java.lang.AssertionError: Test webapp dir D:\Hadoop\hadoop-common-project\hadoop-common\build\test\webapps\test can not be created
> 	at org.junit.Assert.fail(Assert.java:88)
> 	at org.apache.hadoop.http.HttpServerFunctionalTest.prepareTestWebapp(HttpServerFunctionalTest.java:127)
> 	at org.apache.hadoop.http.HttpServerFunctionalTest.createTestServer(HttpServerFunctionalTest.java:91)
> 	at org.apache.hadoop.http.TestHttpServer.setup(TestHttpServer.java:138)
> {noformat}
> And in the {{HttpServerFunctionalTest#prepareTestWebapp}} java doc says that fail if directory can not be created but test is failing if directory does not exist.
> {code}
> /**
>    * Prepare the test webapp by creating the directory from the test properties
>    * fail if the directory cannot be created.
>    * @throws AssertionError if a condition was not met
>    */
>   protected static void prepareTestWebapp() {
> // some code
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)