You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/24 08:10:03 UTC
[GitHub] [airflow] blag opened a new pull request, #24628: Rewrite the 'celery' command to use Click
blag opened a new pull request, #24628:
URL: https://github.com/apache/airflow/pull/24628
This is part of a series of PRs breaking up #22613 into smaller, more reviewable chunks. The end result will be rewriting the existing `airflow` CLI to use Click instead of argparse. For motivation, please see #22708.
This PR adds the `celery` subcommand to the `airflow-ng` command. It's exactly the same as the `airflow celery` command, it's just implemented with Click. This PR also includes an additional, separate test file for the Click `celery` subcommand. The intent there is to simply remove the test files for the old commands once the Click-based `airflow-ng` command supersedes and replaces the argparse-based `airflow` command.
For comparison to the modules this supersedes:
* [`airflow/cli/commands/celery_command.py`](https://github.com/apache/airflow/blob/main/airflow/cli/commands/celery_command.py)
* [`tests/cli/commands/test_celery_command.py`](https://github.com/apache/airflow/blob/main/tests/cli/commands/test_celery_command.py)
Original author: @hankehly astronomer/airflow#1495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] blag commented on pull request #24628: Rewrite the 'celery' command to use Click
Posted by GitBox <gi...@apache.org>.
blag commented on PR #24628:
URL: https://github.com/apache/airflow/pull/24628#issuecomment-1172731665
From [this discussion](https://github.com/apache/airflow/pull/24591#pullrequestreview-1019268731), there is more groundwork and research necessary before we can evaluate rewriting the CLI with Click.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] blag closed pull request #24628: Rewrite the 'celery' command to use Click
Posted by GitBox <gi...@apache.org>.
blag closed pull request #24628: Rewrite the 'celery' command to use Click
URL: https://github.com/apache/airflow/pull/24628
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] blag commented on pull request #24628: Rewrite the 'celery' command to use Click
Posted by GitBox <gi...@apache.org>.
blag commented on PR #24628:
URL: https://github.com/apache/airflow/pull/24628#issuecomment-1165744092
@hankehly Can I get your :+1: on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org