You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "Aitema-gmbh (via GitHub)" <gi...@apache.org> on 2026/04/09 19:03:33 UTC
[PR] fix(a11y): WCAG 3.2.3 — add aria-labels to navigation landmarks [superset]
Aitema-gmbh opened a new pull request, #39244:
URL: https://github.com/apache/superset/pull/39244
### SUMMARY
Implements WCAG 2.1 criterion 3.2.3 (Consistent Navigation, Level AA).
- Add `aria-label="Main navigation"` to the primary header navigation (`Menu.tsx`)
- Add `aria-label="Page navigation"` to the page-level sub-navigation (`SubMenu.tsx`)
- Screen readers can now distinguish between navigation regions
### TESTING INSTRUCTIONS
1. Open any page with a screen reader
2. Navigate by landmarks → "Main navigation" and "Page navigation" should be announced as distinct regions
3. Verify both labels are present on all pages
### ADDITIONAL INFORMATION
- [x] Changes UI
Part of a series of 16 individual WCAG 2.1 accessibility PRs. See also #38342.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(a11y): WCAG 3.2.3 — add aria-labels to navigation landmarks [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #39244:
URL: https://github.com/apache/superset/pull/39244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(a11y): WCAG 3.2.3 — add aria-labels to navigation landmarks [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #39244:
URL: https://github.com/apache/superset/pull/39244#issuecomment-4283447800
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/39244?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 64.37%. Comparing base ([`5815665`](https://app.codecov.io/gh/apache/superset/commit/5815665cc6249d4a665aef9e080eee76da3d9934?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1360c8c`](https://app.codecov.io/gh/apache/superset/commit/1360c8c3df63f1b75ec0ce8a08b3c174ccbaa7a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 112 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #39244 +/- ##
==========================================
- Coverage 64.37% 64.37% -0.01%
==========================================
Files 2550 2550
Lines 132180 132180
Branches 30661 30661
==========================================
- Hits 85096 85092 -4
- Misses 45599 45603 +4
Partials 1485 1485
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/39244/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/39244/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `65.90% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/39244?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(a11y): WCAG 3.2.3 — add aria-labels to navigation landmarks [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #39244:
URL: https://github.com/apache/superset/pull/39244#issuecomment-4217240430
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(a11y): WCAG 3.2.3 — add aria-labels to navigation landmarks [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #39244:
URL: https://github.com/apache/superset/pull/39244#issuecomment-4216783404
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(a11y): WCAG 3.2.3 — add aria-labels to navigation landmarks [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #39244:
URL: https://github.com/apache/superset/pull/39244#discussion_r3060093518
##########
superset-frontend/src/features/home/SubMenu.tsx:
##########
@@ -210,7 +210,7 @@ const SubMenuComponent: FunctionComponent<SubMenuProps> = props => {
return (
<StyledHeader backgroundColor={props.backgroundColor}>
- <Row className="menu" role="navigation">
+ <Row className="menu" role="navigation" aria-label="Page navigation">
Review Comment:
**Suggestion:** The new `aria-label` is hardcoded in English, so it bypasses the app's i18n system and will be announced in the wrong language for non-English users. Wrap the label with the translation helper to keep accessibility text localized like other `aria-label` values in the codebase. [logic error]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ❌ Home page sub-navigation landmark announced in English only.
- ⚠️ Inconsistent i18n for accessibility labels across UI.
```
</details>
```suggestion
<Row
className="menu"
role="navigation"
aria-label={t('Page navigation')}
>
```
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. Configure a non-English locale in Superset so that localized UI strings are used; the
top navigation language controls are built from `useLanguageMenuItems` in
`superset-frontend/src/features/home/RightMenu.tsx:66-120`, which pulls labels from
`useLanguageMenuItems` in `superset-frontend/src/features/home/LanguagePicker.tsx:60-27`
where the aria-label itself is localized via `aria-label={t('Languages')}` at line 18.
2. Navigate to the Welcome (home) page rendered by
`superset-frontend/src/pages/Home/index.tsx:360-79`; this page renders the "Recents",
"Dashboards", "Charts", and "Saved queries" sections whose contents include the `SubMenu`
component.
3. Expand, for example, the "Dashboards" section so that `DashboardTable` mounts; in
`superset-frontend/src/features/home/DashboardTable.tsx:188-223` the component renders
`<SubMenu ... />`, which resolves to `SubMenuComponent` in
`superset-frontend/src/features/home/SubMenu.tsx:171-213`.
4. With a screen reader, navigate by landmarks on the loaded Home page: when the
navigation row rendered at `superset-frontend/src/features/home/SubMenu.tsx:213` (`<Row
className="menu" role="navigation" aria-label="Page navigation">`) is reached, the screen
reader announces the landmark as "Page navigation" in English, even though the surrounding
labels (e.g., tab labels localized with `t('Edited')`, `t('Created')` in
`ActivityTable.tsx:143-159`) respect the current locale; this contrast, along with other
localized aria-labels like `aria-label={t('Select color scheme')}` in
`plugins/plugin-chart-word-cloud/src/plugin/controls/ColorSchemeControl/index.tsx:318` and
`aria-label={t('Languages')}` in `LanguagePicker.tsx:18`, shows that this hardcoded
aria-label bypasses the established i18n pattern.
```
</details>
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/features/home/SubMenu.tsx
**Line:** 213:213
**Comment:**
*Logic Error: The new `aria-label` is hardcoded in English, so it bypasses the app's i18n system and will be announced in the wrong language for non-English users. Wrap the label with the translation helper to keep accessibility text localized like other `aria-label` values in the codebase.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39244&comment_hash=a73439341febd3f97fe87e6ce2b71fb7674ef5ae93dee24a23f06f781bc2dfe6&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39244&comment_hash=a73439341febd3f97fe87e6ce2b71fb7674ef5ae93dee24a23f06f781bc2dfe6&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org