You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2016/12/07 05:07:08 UTC

[kudu-CR] [build] Update syntax of gen version info.py 

Will Berkeley has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5396

Change subject: [build] Update syntax of gen_version_info.py
......................................................................

[build] Update syntax of gen_version_info.py

Got bit by a SyntaxError here while accidentally building Kudu with a
Python3 distro that didn't have the sha module.

Change-Id: Ib37c8438f8bebbf07560224480543c64eb94cd39
---
M build-support/gen_version_info.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/5396/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib37c8438f8bebbf07560224480543c64eb94cd39
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>

[kudu-CR] [build] Update syntax of gen version info.py

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.

Change subject: [build] Update syntax of gen_version_info.py
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib37c8438f8bebbf07560224480543c64eb94cd39
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] [build] Update syntax of gen version info.py

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has submitted this change and it was merged.

Change subject: [build] Update syntax of gen_version_info.py
......................................................................


[build] Update syntax of gen_version_info.py

Got bit by a SyntaxError here while accidentally building Kudu with a
Python3 distro that didn't have the sha module.

Change-Id: Ib37c8438f8bebbf07560224480543c64eb94cd39
Reviewed-on: http://gerrit.cloudera.org:8080/5396
Tested-by: Kudu Jenkins
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
---
M build-support/gen_version_info.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jean-Daniel Cryans: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib37c8438f8bebbf07560224480543c64eb94cd39
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins