You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/01/13 22:39:12 UTC
[GitHub] [tvm] driazati opened a new pull request #9931: Add action to label mergeable PRs
driazati opened a new pull request #9931:
URL: https://github.com/apache/tvm/pull/9931
Developers often have to ping a committer once their PRs are both passing in CI and are approved. This helps facilitate this process by marking such PRs with a label `ready-for-merge` so committers can easily filter for outstanding PRs that need attention.
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati edited a comment on pull request #9931: Add action to label mergeable PRs
Posted by GitBox <gi...@apache.org>.
driazati edited a comment on pull request #9931:
URL: https://github.com/apache/tvm/pull/9931#issuecomment-1013559797
Reverting back to draft since I'm not sure this is workable since when GitHub reports a status (i.e. when Jenkins is done) I don't see any way to get the original pull request when the PR comes from a forked repo, so the main use case (approval happens, then Jenkins completes hours later) doesn't work. ~~We might just need to push this out of GHA to run at the end of Jenkins once everything is complete for status events~~ this was annoying to implement so I re-worked it to run as a cron (there might be a delay in when the label gets added but it shouldn't be too bad at ~15 min)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jroesch commented on pull request #9931: Add action to label mergeable PRs
Posted by GitBox <gi...@apache.org>.
jroesch commented on pull request #9931:
URL: https://github.com/apache/tvm/pull/9931#issuecomment-1012834475
This looks great to me, lmk when this is "ready for ~merge~ review" 😆
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati closed pull request #9931: Add action to label mergeable PRs
Posted by GitBox <gi...@apache.org>.
driazati closed pull request #9931:
URL: https://github.com/apache/tvm/pull/9931
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on pull request #9931: Add action to label mergeable PRs
Posted by GitBox <gi...@apache.org>.
driazati commented on pull request #9931:
URL: https://github.com/apache/tvm/pull/9931#issuecomment-1013559797
Reverting back to draft since I'm not sure this is workable since when GitHub reports a status (i.e. when Jenkins is done) I don't see any way to get the original pull request when the PR comes from a forked repo, so the main use case (approval happens, then Jenkins completes hours later) doesn't work. We might just need to push this out of GHA to run at the end of Jenkins once everything is complete for status events
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on pull request #9931: Add action to label mergeable PRs
Posted by GitBox <gi...@apache.org>.
driazati commented on pull request #9931:
URL: https://github.com/apache/tvm/pull/9931#issuecomment-1054901720
closing this to keep it from languishing anymore, an RFC will be coming soon that should address the underlying issue of merging PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] github-actions[bot] commented on pull request #9931: Add action to label mergeable PRs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9931:
URL: https://github.com/apache/tvm/pull/9931#issuecomment-1028297509
It has been a while since this PR was updated, @areusch please leave a review or address the outstanding comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] github-actions[bot] commented on pull request #9931: Add action to label mergeable PRs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9931:
URL: https://github.com/apache/tvm/pull/9931#issuecomment-1034131180
It has been a while since this PR was updated, @areusch please leave a review or address the outstanding comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org