You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/05/20 14:26:29 UTC

[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #5943: [IOTDB-3083] DataNode AuthorInfo cache

xingtanzjr commented on code in PR #5943:
URL: https://github.com/apache/iotdb/pull/5943#discussion_r878207389


##########
confignode/src/main/java/org/apache/iotdb/confignode/manager/PermissionManager.java:
##########
@@ -61,11 +97,28 @@ private ConsensusManager getConsensusManager() {
     return configManager.getConsensusManager();
   }
 
-  public TSStatus login(String username, String password) {
+  public TPermissionInfoResp login(String username, String password) {
     return authorInfo.login(username, password);
   }
 
-  public TSStatus checkUserPrivileges(String username, List<String> paths, int permission) {
+  public TPermissionInfoResp checkUserPrivileges(
+      String username, List<String> paths, int permission) {
     return authorInfo.checkUserPrivileges(username, paths, permission);
   }
+
+  /**
+   * When the permission information of a user or role is changed, the permission cache information
+   * of all DataNode is initialized, and only the affected cache is initialized.

Review Comment:
   `all DataNodes` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org