[GitHub] [airflow] dstandish commented on a diff in pull request #28710: Apply "unify bucket and key" before "provide bucket"

[GitBox <gi...@apache.org>]

dstandish commented on code in PR #28710:
URL: https://github.com/apache/airflow/pull/28710#discussion_r1061153019


##########
airflow/providers/amazon/aws/exceptions.py:
##########
@@ -42,3 +44,7 @@ def __init__(self, failures: list, message: str):
 
     def __reduce__(self):
         return EcsOperatorError, (self.failures, self.message)
+
+
+class S3HookUriParseFailure(AirflowException):
+    """When parse_s3_url fails to parse URL, this error is thrown."""

Review Comment:
   it could, but i chose to do this because it was previously raising airflowexception  ... basically... backcompat...  anything that was previously catching will still catch.  if we change, it won't



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org