You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/03/09 14:29:38 UTC
[GitHub] [incubator-yunikorn-k8shim] pbacsko commented on a change in pull request #380: [YUNIKORN-1090] remove common.Node from the shim
pbacsko commented on a change in pull request #380:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/380#discussion_r822706725
##########
File path: pkg/cache/nodes.go
##########
@@ -213,21 +212,22 @@ func (nc *schedulerNodes) updateNode(oldNode, newNode *v1.Node) {
return
}
- if schedulerNode, ok := nc.nodesMap[newNode.Name]; ok {
- schedulerNode.ready = common.HasReadyCondition(newNode)
+ schedulerNode, ok := nc.nodesMap[newNode.Name]
+ if ok {
+ schedulerNode.ready = hasReadyCondition(newNode)
Review comment:
The logic here changed slightly. We only send out the update to the proxy if the node is found in the `nodesMap`. I don't think it has substantial effects, just wondering if this is better?
cc @wilfred-s
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org