[GitHub] [iceberg] openinx commented on a change in pull request #3001: Flink: add monitoring metrics to Flink Iceberg sink

[GitBox <gi...@apache.org>]

openinx commented on a change in pull request #3001:
URL: https://github.com/apache/iceberg/pull/3001#discussion_r700687876



##########
File path: build.gradle
##########
@@ -320,6 +320,8 @@ project(':iceberg-flink') {
     compile project(':iceberg-parquet')
     compile project(':iceberg-hive-metastore')
 
+    // for dropwizard histogram metrics implementation
+    compileOnly "org.apache.flink:flink-metrics-dropwizard"

Review comment:
       I downloaded the  [flink-1.13.2](https://flink.apache.org/downloads.html#apache-flink-1132) from the apache flink official website.  And checked the `dropwizard` related class: 
   
   ```bash
   ➜  flink-1.13.2 grep -R DropwizardMeterWrapper . 
   Binary file ./plugins/metrics-graphite/flink-metrics-graphite-1.13.2.jar matches
   ```
   
   Looks like the jar was included in the `metrics-graphite` plugins,  which means we could not load the classes from flink dist binary by default, unless we enable the metrics-graphite plugin.  The means we couldn't run the iceberg flink sink successfully unless we enable the metrics-graphite plugin,  that's quite unfriendly for the quickstart. 
   
   If we really need the dropwizad jar , then I will suggest to include into the iceberg-flink-runtime.jar, so that we could get rid of the above issue. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org