You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Pradeep Agrawal <pr...@freestoneinfotech.com> on 2016/04/04 17:07:28 UTC
Review Request 45682: Improve db and java patches execution logic to
make that more robust
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45682/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-910
https://issues.apache.org/jira/browse/RANGER-910
Repository: ranger
Description
-------
**Problem Statement:** Ranger installation process should not allow concurrent execution of DB or java patches as concurrent execution of patches can lead to inconsistent state of data and application.
**Proposed Solution :** Before executing db or java patch; installation process will insert patch status in x_db_version_h table with active='N' value, If patch will get executed successfully then status of patch will be set to 'Y'; otherwise patch status row from x_db_version_h will be deleted. If patch is being executed then active column will have value 'N' and no other process will be allowed to execute that patch.
Diffs
-----
security-admin/db/postgres/patches/019-create-indexes.sql 22b3dc8
security-admin/scripts/db_setup.py 9732442
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 02925c0
security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 571265c
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 63c36da
security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java bae0924
Diff: https://reviews.apache.org/r/45682/diff/
Testing
-------
**Steps Performed (With Patch) :**
1. After configuring values in install.properties file, called setup.sh from different terminals.
** Result Behaviour : **
Ranger Was installed successfully and was able to login in Ranger Admin UI.
Note: Patch has been tested for all DB flavors.
Thanks,
Pradeep Agrawal
Re: Review Request 45682: Improve db and java patches execution logic
to make that more robust
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45682/#review127022
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On April 5, 2016, 1:30 a.m., Pradeep Agrawal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45682/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 1:30 a.m.)
>
>
> Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-910
> https://issues.apache.org/jira/browse/RANGER-910
>
>
> Repository: ranger
>
>
> Description
> -------
>
> **Problem Statement:** Ranger installation process should not allow concurrent execution of DB or java patches as concurrent execution of patches can lead to inconsistent state of data and application.
>
> **Proposed Solution :** Before executing db or java patch; installation process will insert patch status in x_db_version_h table with active='N' value, If patch will get executed successfully then status of patch will be set to 'Y'; otherwise patch status row from x_db_version_h will be deleted. If patch is being executed then active column will have value 'N' and no other process will be allowed to execute that patch.
>
>
> Diffs
> -----
>
> security-admin/db/postgres/patches/019-create-indexes.sql 22b3dc8
> security-admin/scripts/db_setup.py 9732442
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 02925c0
> security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 571265c
> security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 63c36da
> security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java bae0924
>
> Diff: https://reviews.apache.org/r/45682/diff/
>
>
> Testing
> -------
>
> **Steps Performed (With Patch) :**
>
> 1. After configuring values in install.properties file, called setup.sh from different terminals.
>
> ** Result Behaviour : **
> Ranger Was installed successfully and was able to login in Ranger Admin UI.
>
> Note: Patch has been tested for all DB flavors.
>
>
> Thanks,
>
> Pradeep Agrawal
>
>
Re: Review Request 45682: Improve db and java patches execution logic
to make that more robust
Posted by Pradeep Agrawal <pr...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45682/
-----------------------------------------------------------
(Updated April 5, 2016, 1:30 a.m.)
Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Changes
-------
Changed branch info to 0.5
Bugs: RANGER-910
https://issues.apache.org/jira/browse/RANGER-910
Repository: ranger
Description
-------
**Problem Statement:** Ranger installation process should not allow concurrent execution of DB or java patches as concurrent execution of patches can lead to inconsistent state of data and application.
**Proposed Solution :** Before executing db or java patch; installation process will insert patch status in x_db_version_h table with active='N' value, If patch will get executed successfully then status of patch will be set to 'Y'; otherwise patch status row from x_db_version_h will be deleted. If patch is being executed then active column will have value 'N' and no other process will be allowed to execute that patch.
Diffs
-----
security-admin/db/postgres/patches/019-create-indexes.sql 22b3dc8
security-admin/scripts/db_setup.py 9732442
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 02925c0
security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 571265c
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 63c36da
security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java bae0924
Diff: https://reviews.apache.org/r/45682/diff/
Testing
-------
**Steps Performed (With Patch) :**
1. After configuring values in install.properties file, called setup.sh from different terminals.
** Result Behaviour : **
Ranger Was installed successfully and was able to login in Ranger Admin UI.
Note: Patch has been tested for all DB flavors.
Thanks,
Pradeep Agrawal