You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by gg...@apache.org on 2014/09/22 07:29:50 UTC
[2/2] git commit: Javadoc: Replace @doubt with TODO tags. Custom @'s
in Javadoc 8 are not allowed unpackaged and then must exist,
and we do not have them,
so just use a "TODO" tag which can then be picked up with the Maven tag report
if we want to add th
Javadoc: Replace @doubt with TODO tags. Custom @'s in Javadoc 8 are not
allowed unpackaged and then must exist, and we do not have them, so just
use a "TODO" tag which can then be picked up with the Maven tag report
if we want to add that to the reports.
Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/e43b5019
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/e43b5019
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/e43b5019
Branch: refs/heads/master
Commit: e43b5019651fec8f2c424db6f40b455bcb46315a
Parents: bcea11f
Author: Gary Gregory <ga...@gmail.com>
Authored: Mon Sep 22 01:29:45 2014 -0400
Committer: Gary Gregory <ga...@gmail.com>
Committed: Mon Sep 22 01:29:45 2014 -0400
----------------------------------------------------------------------
.../java/org/apache/logging/log4j/Logger.java | 18 +++++++++---------
.../org/apache/logging/log4j/message/Message.java | 4 ++--
.../apache/logging/log4j/core/ErrorHandler.java | 2 +-
.../org/apache/logging/log4j/core/Layout.java | 4 ++--
.../org/apache/logging/log4j/core/LogEvent.java | 2 +-
.../logging/log4j/core/LogEventListener.java | 2 +-
.../org/apache/logging/log4j/core/Logger.java | 2 +-
.../log4j/core/appender/ConsoleAppender.java | 2 +-
.../logging/log4j/core/lookup/Interpolator.java | 1 +
9 files changed, 19 insertions(+), 18 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e43b5019/log4j-api/src/main/java/org/apache/logging/log4j/Logger.java
----------------------------------------------------------------------
diff --git a/log4j-api/src/main/java/org/apache/logging/log4j/Logger.java b/log4j-api/src/main/java/org/apache/logging/log4j/Logger.java
index 8e57f4b..a9b7254 100644
--- a/log4j-api/src/main/java/org/apache/logging/log4j/Logger.java
+++ b/log4j-api/src/main/java/org/apache/logging/log4j/Logger.java
@@ -200,7 +200,7 @@ public interface Logger {
* bytecode manipulation tools. It can be rather tedious (and messy) to use this type of method manually.</p>
*
* @param params The parameters to the method.
- * @doubt Use of varargs results in array creation which can be a substantial portion of no-op case. LogMF/LogSF
+ * TODO Use of varargs results in array creation which can be a substantial portion of no-op case. LogMF/LogSF
* provides several overrides to avoid vararg except in edge cases. (RG) LogMF and LogSF implement these in
* LogXF which calls logger.callAppenders. callAppenders is part of the implementation and cannot be used by
* the API. Adding more methods here and in AbstractLogger is sufficient.
@@ -258,7 +258,7 @@ public interface Logger {
* @param params parameters to the message.
* @see #getMessageFactory()
*
- * @doubt Likely to misinterpret existing log4j client code that intended to call info(Object,Throwable). Incurs
+ * TODO Likely to misinterpret existing log4j client code that intended to call info(Object,Throwable). Incurs
* array creation expense on every call. (RG) I assume you meant error, not info. It isn't possible to be
* misinterpreted as the previous method is for that signature. Methods should be added to avoid varargs for
* 1, 2 or 3 parameters.
@@ -320,7 +320,7 @@ public interface Logger {
* @param params parameters to the message.
* @see #getMessageFactory()
*
- * @doubt Likely to misinterpret existing log4j client code that intended to call info(Object,Throwable). Incurs
+ * TODO Likely to misinterpret existing log4j client code that intended to call info(Object,Throwable). Incurs
* array creation expense on every call. (RG) I assume you meant error, not info. It isn't possible to be
* misinterpreted as the previous method is for that signature. Methods should be added to avoid varargs for
* 1, 2 or 3 parameters.
@@ -404,7 +404,7 @@ public interface Logger {
* @param params parameters to the message.
* @see #getMessageFactory()
*
- * @doubt Likely to misinterpret existing log4j client code that intended to call info(Object,Throwable). Incurs
+ * TODO Likely to misinterpret existing log4j client code that intended to call info(Object,Throwable). Incurs
* array creation expense on every call.(RG) I assume you meant fatal, not info. It isn't possible to be
* misinterpreted as the previous method is for that signature. Methods should be added to avoid varargs for
* 1, 2 or 3 parameters.
@@ -466,7 +466,7 @@ public interface Logger {
* @param params parameters to the message.
* @see #getMessageFactory()
*
- * @doubt Likely to misinterpret existing log4j client code that intended to call info(Object,Throwable). Incurs
+ * TODO Likely to misinterpret existing log4j client code that intended to call info(Object,Throwable). Incurs
* array creation expense on every call.(RG) I assume you meant fatal, not info. It isn't possible to be
* misinterpreted as the previous method is for that signature. Methods should be added to avoid varargs for
* 1, 2 or 3 parameters.
@@ -554,7 +554,7 @@ public interface Logger {
* @param params parameters to the message.
* @see #getMessageFactory()
*
- * @doubt Likely to misinterpret existing log4j client code that intended to call info(Object,Throwable). Incurs
+ * TODO Likely to misinterpret existing log4j client code that intended to call info(Object,Throwable). Incurs
* array creation expense on every call. (RG) It isn't possible to be misinterpreted as the previous method
* is for that signature. Methods should be added to avoid varargs for 1, 2 or 3 parameters.
*/
@@ -615,7 +615,7 @@ public interface Logger {
* @param params parameters to the message.
* @see #getMessageFactory()
*
- * @doubt Likely to misinterpret existing log4j client code that intended to call info(Object,Throwable). Incurs
+ * TODO Likely to misinterpret existing log4j client code that intended to call info(Object,Throwable). Incurs
* array creation expense on every call. (RG) It isn't possible to be misinterpreted as the previous method
* is for that signature. Methods should be added to avoid varargs for 1, 2 or 3 parameters.
*/
@@ -1098,7 +1098,7 @@ public interface Logger {
* @param params parameters to the message.
* @see #getMessageFactory()
*
- * @doubt Likely to misinterpret existing log4j client code that intended to call info(Object,Throwable). Incurs
+ * TODO Likely to misinterpret existing log4j client code that intended to call info(Object,Throwable). Incurs
* array creation expense on every call. (RG) I assume you meant warn, not info. It isn't possible to be
* misinterpreted as the previous method is for that signature.Methods should be added to avoid varargs for
* 1, 2 or 3 parameters.
@@ -1160,7 +1160,7 @@ public interface Logger {
* @param params parameters to the message.
* @see #getMessageFactory()
*
- * @doubt Likely to misinterpret existing log4j client code that intended to call info(Object,Throwable). Incurs
+ * TODO Likely to misinterpret existing log4j client code that intended to call info(Object,Throwable). Incurs
* array creation expense on every call. (RG) I assume you meant warn, not info. It isn't possible to be
* misinterpreted as the previous method is for that signature.Methods should be added to avoid varargs for
* 1, 2 or 3 parameters.
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e43b5019/log4j-api/src/main/java/org/apache/logging/log4j/message/Message.java
----------------------------------------------------------------------
diff --git a/log4j-api/src/main/java/org/apache/logging/log4j/message/Message.java b/log4j-api/src/main/java/org/apache/logging/log4j/message/Message.java
index b1b7f74..d947999 100644
--- a/log4j-api/src/main/java/org/apache/logging/log4j/message/Message.java
+++ b/log4j-api/src/main/java/org/apache/logging/log4j/message/Message.java
@@ -30,7 +30,7 @@ import java.io.Serializable;
* Message object by an application should by avoided after the Message has been passed as a parameter on
* a Logger method.
* </p>
- * @doubt Interfaces should rarely extend Serializable according to Effective Java 2nd Ed pg 291.
+ * TODO Interfaces should rarely extend Serializable according to Effective Java 2nd Ed pg 291.
* (RG) That section also says "If a class or interface exists primarily to participate in a framework that
* requires all participants to implement Serializable, then it makes perfect sense for the class or
* interface to implement or extend Serializable". Such is the case here as the LogEvent must be Serializable.
@@ -51,7 +51,7 @@ public interface Message extends Serializable {
*
* @return The message format. Some implementations, such as ParameterizedMessage, will use this as
* the message "pattern". Other Messages may simply return an empty String.
- * @doubt Do all messages have a format? What syntax? Using a Formatter object could be cleaner.
+ * TODO Do all messages have a format? What syntax? Using a Formatter object could be cleaner.
* (RG) In SimpleMessage the format is identical to the formatted message. In ParameterizedMessage and
* StructuredDataMessage it is not. It is up to the Message implementer to determine what this
* method will return. A Formatter is inappropriate as this is very specific to the Message
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e43b5019/log4j-core/src/main/java/org/apache/logging/log4j/core/ErrorHandler.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/ErrorHandler.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/ErrorHandler.java
index bec0a20..a6c97c1 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/ErrorHandler.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/ErrorHandler.java
@@ -18,7 +18,7 @@ package org.apache.logging.log4j.core;
/**
* Appenders may delegate their error handling to <code>ErrorHandlers</code>.
- * @doubt if the appender interface is simplified, then error handling could just be done by wrapping
+ * TODO if the appender interface is simplified, then error handling could just be done by wrapping
* a nested appender. (RG) Please look at DefaultErrorHandler. It's purpose is to make sure the console
* or error log isn't flooded with messages. I'm still considering the Appender refactoring.
*/
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e43b5019/log4j-core/src/main/java/org/apache/logging/log4j/core/Layout.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/Layout.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/Layout.java
index 07fdb23..78ad558 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/Layout.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/Layout.java
@@ -37,7 +37,7 @@ import java.util.Map;
* @param <T>
* The {@link Serializable} type returned by {@link #toSerializable(LogEvent)}
*
- * @doubt There is still a need for a character-based layout for character based event sinks (databases, etc). Would
+ * TODO There is still a need for a character-based layout for character based event sinks (databases, etc). Would
* introduce an EventEncoder, EventRenderer or something similar for the logging event to byte encoding. (RG) A layout
* can be configured with a Charset and then Strings can be converted to byte arrays. OTOH, it isn't possible to write
* byte arrays as character streams.
@@ -60,7 +60,7 @@ public interface Layout<T extends Serializable> {
*
* @param event The Logging Event.
* @return The formatted event.
- * @doubt Likely better to write to a OutputStream instead of return a byte[]. (RG) That limits how the
+ * TODO Likely better to write to a OutputStream instead of return a byte[]. (RG) That limits how the
* Appender can use the Layout. For example, it might concatenate information in front or behind the
* data and then write it all to the OutputStream in one call.
*/
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e43b5019/log4j-core/src/main/java/org/apache/logging/log4j/core/LogEvent.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/LogEvent.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/LogEvent.java
index eab779e..bbae3b5 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/LogEvent.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/LogEvent.java
@@ -109,7 +109,7 @@ public interface LogEvent extends Serializable {
* Gets thread name.
*
* @return thread name, may be null.
- * @doubt guess this could go into a thread context object too. (RG) Why?
+ * TODO guess this could go into a thread context object too. (RG) Why?
*/
String getThreadName();
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e43b5019/log4j-core/src/main/java/org/apache/logging/log4j/core/LogEventListener.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/LogEventListener.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/LogEventListener.java
index cb157ce..07a8c74 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/LogEventListener.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/LogEventListener.java
@@ -22,7 +22,7 @@ import org.apache.logging.log4j.LogManager;
/**
* Base class for server classes that listen to {@link LogEvent}s.
- * @doubt (MS) How is this class any different from Appender?
+ * TODO (MS) How is this class any different from Appender?
*/
public class LogEventListener implements EventListener {
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e43b5019/log4j-core/src/main/java/org/apache/logging/log4j/core/Logger.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/Logger.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/Logger.java
index ef9ffdc..707fceb 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/Logger.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/Logger.java
@@ -41,7 +41,7 @@ import org.apache.logging.log4j.util.Strings;
* underlying objects is provided primarily for use in unit tests or bridging legacy Log4j 1.x code. Future versions
* of this class may or may not include the various methods that are noted as not being part of the public API.
*
- * @doubt All the isEnabled methods could be pushed into a filter interface. Not sure of the utility of having
+ * TODO All the isEnabled methods could be pushed into a filter interface. Not sure of the utility of having
* isEnabled be able to examine the message pattern and parameters. (RG) Moving the isEnabled methods out of
* Logger noticeably impacts performance. The message pattern and parameters are required so that they can be
* used in global filters.
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e43b5019/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/ConsoleAppender.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/ConsoleAppender.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/ConsoleAppender.java
index a117e88..0572666 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/ConsoleAppender.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/ConsoleAppender.java
@@ -41,7 +41,7 @@ import org.apache.logging.log4j.util.PropertiesUtil;
* ConsoleAppender appends log events to <code>System.out</code> or
* <code>System.err</code> using a layout specified by the user. The
* default target is <code>System.out</code>.
- * @doubt accessing System.out or .err as a byte stream instead of a writer
+ * TODO accessing System.out or .err as a byte stream instead of a writer
* bypasses the JVM's knowledge of the proper encoding. (RG) Encoding
* is handled within the Layout. Typically, a Layout will generate a String
* and then call getBytes which may use a configured encoding or the system
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e43b5019/log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/Interpolator.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/Interpolator.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/Interpolator.java
index 0282bd0..c437ea8 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/Interpolator.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/Interpolator.java
@@ -85,6 +85,7 @@ public class Interpolator extends AbstractLookup {
lookups.put("sys", new SystemPropertiesLookup());
lookups.put("env", new EnvironmentLookup());
lookups.put("main", MapLookup.MAIN_SINGLETON);
+ lookups.put("java", new JavaLookup());
// JNDI
try {
// [LOG4J2-703] We might be on Android
Re: [2/2] git commit: Javadoc: Replace @doubt with TODO tags. Custom
@'s in Javadoc 8 are not allowed unpackaged and then must exist, and we do
not have them, so just use a "TODO" tag which can then be picked up with the
Maven tag report if we want to add th
Posted by Gary Gregory <ga...@gmail.com>.
I mean that I cannot get values for "%n" and "%d{UNIX}" in a header or
footer.
I was trying to use %n and it did not work so I tried %d{UNIX} just to see
what would happen and it did not work either.
Looking at the code, this is not surprising since the enhancement
implemented in LOG4J-496 only covered look-ups.
For my narrow case, the workaround is the more verbose
${sys:line.separator}, which is a system property look-up.
I created https://issues.apache.org/jira/browse/LOG4J2-847
Gary
On Mon, Sep 22, 2014 at 11:24 AM, Ralph Goers <ra...@dslextreme.com>
wrote:
> What do you mean “%’s do not”? You mean PatternConverters? I think
> someone asked for that enhancement, but since the header and footer are
> processed before a LogEvent exists their are a whole pile of them that
> won’t work.
>
> Ralph
>
>
> On Sep 22, 2014, at 8:05 AM, Gary Gregory <ga...@gmail.com> wrote:
>
> On Mon, Sep 22, 2014 at 10:26 AM, Ralph Goers <ra...@dslextreme.com>
> wrote:
>
>> I thought Gary recently implemented that.
>>
>
> I had talked about it, and worked it out over the weekend, it's not much
> code actually (as expected).
>
> What was unexpected is that while lookups work in header and footers, %'s
> do not, so you cannot use formatted dates, end-of-lines and such.
>
> Gary
>
>
>> Please read the @doubts. I imagine most of them can be removed at this
>> point.
>>
>> Ralph
>>
>> On Sep 22, 2014, at 2:29 AM, Remko Popma <re...@gmail.com> wrote:
>>
>> > I'm getting a compile error:
>> >
>> > Interpolator now has this line:
>> > + lookups.put("java", new JavaLookup());
>> > But the JavaLookup class does not exist...
>> >
>> >
>> > Sent from my iPhone
>> >
>> >> On 2014/09/22, at 14:29, ggregory@apache.org wrote:
>> >>
>> >> + lookups.put("java", new JavaLookup());
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>> > For additional commands, e-mail: log4j-dev-help@logging.apache.org
>> >
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> <gg...@apache.org>
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [2/2] git commit: Javadoc: Replace @doubt with TODO tags. Custom @'s in Javadoc 8 are not allowed unpackaged and then must exist, and we do not have them, so just use a "TODO" tag which can then be picked up with the Maven tag report if we want to add th
Posted by Ralph Goers <ra...@dslextreme.com>.
What do you mean “%’s do not”? You mean PatternConverters? I think someone asked for that enhancement, but since the header and footer are processed before a LogEvent exists their are a whole pile of them that won’t work.
Ralph
On Sep 22, 2014, at 8:05 AM, Gary Gregory <ga...@gmail.com> wrote:
> On Mon, Sep 22, 2014 at 10:26 AM, Ralph Goers <ra...@dslextreme.com> wrote:
> I thought Gary recently implemented that.
>
> I had talked about it, and worked it out over the weekend, it's not much code actually (as expected).
>
> What was unexpected is that while lookups work in header and footers, %'s do not, so you cannot use formatted dates, end-of-lines and such.
>
> Gary
>
>
> Please read the @doubts. I imagine most of them can be removed at this point.
>
> Ralph
>
> On Sep 22, 2014, at 2:29 AM, Remko Popma <re...@gmail.com> wrote:
>
> > I'm getting a compile error:
> >
> > Interpolator now has this line:
> > + lookups.put("java", new JavaLookup());
> > But the JavaLookup class does not exist...
> >
> >
> > Sent from my iPhone
> >
> >> On 2014/09/22, at 14:29, ggregory@apache.org wrote:
> >>
> >> + lookups.put("java", new JavaLookup());
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> > For additional commands, e-mail: log4j-dev-help@logging.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> JUnit in Action, Second Edition
> Spring Batch in Action
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
Re: [2/2] git commit: Javadoc: Replace @doubt with TODO tags. Custom
@'s in Javadoc 8 are not allowed unpackaged and then must exist, and we do
not have them, so just use a "TODO" tag which can then be picked up with the
Maven tag report if we want to add th
Posted by Gary Gregory <ga...@gmail.com>.
On Mon, Sep 22, 2014 at 10:26 AM, Ralph Goers <ra...@dslextreme.com>
wrote:
> I thought Gary recently implemented that.
>
I had talked about it, and worked it out over the weekend, it's not much
code actually (as expected).
What was unexpected is that while lookups work in header and footers, %'s
do not, so you cannot use formatted dates, end-of-lines and such.
Gary
> Please read the @doubts. I imagine most of them can be removed at this
> point.
>
> Ralph
>
> On Sep 22, 2014, at 2:29 AM, Remko Popma <re...@gmail.com> wrote:
>
> > I'm getting a compile error:
> >
> > Interpolator now has this line:
> > + lookups.put("java", new JavaLookup());
> > But the JavaLookup class does not exist...
> >
> >
> > Sent from my iPhone
> >
> >> On 2014/09/22, at 14:29, ggregory@apache.org wrote:
> >>
> >> + lookups.put("java", new JavaLookup());
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> > For additional commands, e-mail: log4j-dev-help@logging.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [2/2] git commit: Javadoc: Replace @doubt with TODO tags. Custom @'s in Javadoc 8 are not allowed unpackaged and then must exist, and we do not have them, so just use a "TODO" tag which can then be picked up with the Maven tag report if we want to add th
Posted by Ralph Goers <ra...@dslextreme.com>.
I thought Gary recently implemented that.
Please read the @doubts. I imagine most of them can be removed at this point.
Ralph
On Sep 22, 2014, at 2:29 AM, Remko Popma <re...@gmail.com> wrote:
> I'm getting a compile error:
>
> Interpolator now has this line:
> + lookups.put("java", new JavaLookup());
> But the JavaLookup class does not exist...
>
>
> Sent from my iPhone
>
>> On 2014/09/22, at 14:29, ggregory@apache.org wrote:
>>
>> + lookups.put("java", new JavaLookup());
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: [2/2] git commit: Javadoc: Replace @doubt with TODO tags. Custom @'s in Javadoc 8 are not allowed unpackaged and then must exist, and we do not have them, so just use a "TODO" tag which can then be picked up with the Maven tag report if we want to add th
Posted by Remko Popma <re...@gmail.com>.
I'm getting a compile error:
Interpolator now has this line:
+ lookups.put("java", new JavaLookup());
But the JavaLookup class does not exist...
Sent from my iPhone
> On 2014/09/22, at 14:29, ggregory@apache.org wrote:
>
> + lookups.put("java", new JavaLookup());
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org