[GitHub] [hadoop] brumi1024 commented on a diff in pull request #5278: YARN-11408. Add a check of autoQueueCreation is disabled for emitDefaultUserLimitFactor method

["brumi1024 (via GitHub)" <gi...@apache.org>]

brumi1024 commented on code in PR #5278:
URL: https://github.com/apache/hadoop/pull/5278#discussion_r1105904503


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/TestFSConfigToCSConfigConverter.java:
##########
@@ -194,6 +199,10 @@ public void testDefaultUserLimitFactor() throws Exception {
 
     assertNull("root.users user-limit-factor should be null",
             conf.get(PREFIX + "root.users." + USER_LIMIT_FACTOR));
+    assertEquals("root.users auto-queue-creation-v2.enabled", "true",
+            conf.get(PREFIX + "root.users.auto-queue-creation-v2.enabled"));
+    assertNull( "root.users auto-create-child-queue.enabled should be null",
+            conf.get(PREFIX + "root.users.auto-create-child-queue.enabled"));

Review Comment:
   Update: checked the code, because I was under the impression we're automatically adding the auto-create in percentage conversion as well, however it's not the case: [https://github.com/apache/hadoop/blob/d336227e5c63a70db06ac26697994c96ed89d230/had[…]ger/scheduler/fair/converter/FSConfigToCSConfigRuleHandler.java](https://github.com/apache/hadoop/blob/d336227e5c63a70db06ac26697994c96ed89d230/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/FSConfigToCSConfigRuleHandler.java#L192)
   Sorry for that, please disregard my comment, and feel free to remove the original check for this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org