You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2018/07/16 00:27:16 UTC
Review Request 67922: Removed unused `TestStore` mock.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67922/
-----------------------------------------------------------
Review request for mesos and Andrew Schwartzmeyer.
Repository: mesos
Description
-------
Removed unused `TestStore` mock.
Diffs
-----
src/Makefile.am 9c13eaaa8bd62f10539ebbb6ab16c7303dabfcc1
src/tests/containerizer/store.hpp 0589be698d3bf835293fbe7ea817a11a7bb91f67
Diff: https://reviews.apache.org/r/67922/diff/1/
Testing
-------
make check (Fedora 28)
Thanks,
James Peach
Re: Review Request 67922: Removed unused `TestStore` mock.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67922/#review206145
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On July 15, 2018, 5:36 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67922/
> -----------------------------------------------------------
>
> (Updated July 15, 2018, 5:36 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Gilbert Song, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed unused `TestStore` mock.
>
>
> Diffs
> -----
>
> src/Makefile.am 9c13eaaa8bd62f10539ebbb6ab16c7303dabfcc1
> src/tests/containerizer/store.hpp 0589be698d3bf835293fbe7ea817a11a7bb91f67
>
>
> Diff: https://reviews.apache.org/r/67922/diff/1/
>
>
> Testing
> -------
>
> make check (Fedora 28)
>
> `TestStore` usage was removed in [r/52539](https://reviews.apache.org/r/52539).
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 67922: Removed unused `TestStore` mock.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67922/#review206092
-----------------------------------------------------------
PASS: Mesos patch 67922 was successfully built and tested.
Reviews applied: `['67922']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1927/mesos-review-67922
- Mesos Reviewbot Windows
On July 16, 2018, 8:36 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67922/
> -----------------------------------------------------------
>
> (Updated July 16, 2018, 8:36 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Gilbert Song, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed unused `TestStore` mock.
>
>
> Diffs
> -----
>
> src/Makefile.am 9c13eaaa8bd62f10539ebbb6ab16c7303dabfcc1
> src/tests/containerizer/store.hpp 0589be698d3bf835293fbe7ea817a11a7bb91f67
>
>
> Diff: https://reviews.apache.org/r/67922/diff/1/
>
>
> Testing
> -------
>
> make check (Fedora 28)
>
> `TestStore` usage was removed in [r/52539](https://reviews.apache.org/r/52539).
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 67922: Removed unused `TestStore` mock.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67922/#review206123
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Schwartzmeyer
On July 15, 2018, 5:36 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67922/
> -----------------------------------------------------------
>
> (Updated July 15, 2018, 5:36 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Gilbert Song, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed unused `TestStore` mock.
>
>
> Diffs
> -----
>
> src/Makefile.am 9c13eaaa8bd62f10539ebbb6ab16c7303dabfcc1
> src/tests/containerizer/store.hpp 0589be698d3bf835293fbe7ea817a11a7bb91f67
>
>
> Diff: https://reviews.apache.org/r/67922/diff/1/
>
>
> Testing
> -------
>
> make check (Fedora 28)
>
> `TestStore` usage was removed in [r/52539](https://reviews.apache.org/r/52539).
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 67922: Removed unused `TestStore` mock.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67922/
-----------------------------------------------------------
(Updated July 16, 2018, 12:36 a.m.)
Review request for mesos, Andrew Schwartzmeyer, Gilbert Song, and Jie Yu.
Repository: mesos
Description
-------
Removed unused `TestStore` mock.
Diffs
-----
src/Makefile.am 9c13eaaa8bd62f10539ebbb6ab16c7303dabfcc1
src/tests/containerizer/store.hpp 0589be698d3bf835293fbe7ea817a11a7bb91f67
Diff: https://reviews.apache.org/r/67922/diff/1/
Testing (updated)
-------
make check (Fedora 28)
`TestStore` usage was removed in [r/52539](https://reviews.apache.org/r/52539).
Thanks,
James Peach