You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/05/06 06:05:27 UTC
[GitHub] [phoenix] vmeka2020 opened a new pull request #1223: PHOENIX-6397 Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries
vmeka2020 opened a new pull request #1223:
URL: https://github.com/apache/phoenix/pull/1223
PHOENIX-6397 Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1223: PHOENIX-6397 Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1223:
URL: https://github.com/apache/phoenix/pull/1223#issuecomment-835169490
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 30s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 13m 57s | 4.x passed |
| +1 :green_heart: | compile | 1m 3s | 4.x passed |
| +1 :green_heart: | checkstyle | 3m 2s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 47s | 4.x passed |
| +0 :ok: | spotbugs | 3m 7s | phoenix-core in 4.x has 945 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 41s | the patch passed |
| +1 :green_heart: | compile | 1m 1s | the patch passed |
| +1 :green_heart: | javac | 1m 1s | the patch passed |
| -1 :x: | checkstyle | 3m 22s | phoenix-core: The patch generated 709 new + 6124 unchanged - 86 fixed = 6833 total (was 6210) |
| +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 46s | the patch passed |
| -1 :x: | spotbugs | 3m 17s | phoenix-core generated 5 new + 945 unchanged - 0 fixed = 950 total (was 945) |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 140m 41s | phoenix-core in the patch passed. |
| +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. |
| | | 178m 35s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | Load of known null value in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:[line 88] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.options from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 57] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isMetricPublisherEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 69] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isTableLevelMetricsEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 58] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.tableClientMetricsMapping from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 61] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/6/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1223 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 994a97116f92 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 6d6bf9a |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/6/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/6/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/6/testReport/ |
| Max. process+thread count | 5648 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/6/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1223: PHOENIX-6397 Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1223:
URL: https://github.com/apache/phoenix/pull/1223#issuecomment-833998729
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 30s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 13m 56s | 4.x passed |
| +1 :green_heart: | compile | 1m 2s | 4.x passed |
| +1 :green_heart: | checkstyle | 3m 4s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 46s | 4.x passed |
| +0 :ok: | spotbugs | 3m 7s | phoenix-core in 4.x has 945 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 46s | the patch passed |
| +1 :green_heart: | compile | 1m 0s | the patch passed |
| +1 :green_heart: | javac | 1m 0s | the patch passed |
| -1 :x: | checkstyle | 3m 22s | phoenix-core: The patch generated 710 new + 6125 unchanged - 87 fixed = 6835 total (was 6212) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 45s | the patch passed |
| -1 :x: | spotbugs | 3m 16s | phoenix-core generated 5 new + 945 unchanged - 0 fixed = 950 total (was 945) |
||| _ Other Tests _ |
| -1 :x: | unit | 208m 41s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 51s | The patch does not generate ASF License warnings. |
| | | 249m 10s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | Load of known null value in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:[line 88] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.options from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 57] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isMetricPublisherEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 69] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isTableLevelMetricsEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 58] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.tableClientMetricsMapping from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 61] |
| Failed junit tests | phoenix.end2end.AuditLoggingIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/4/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1223 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 0547d3569752 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / ddc3996 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/4/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/4/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/4/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/4/testReport/ |
| Max. process+thread count | 5609 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/4/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] yanxinyi commented on a change in pull request #1223: PHOENIX-6397 Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries
Posted by GitBox <gi...@apache.org>.
yanxinyi commented on a change in pull request #1223:
URL: https://github.com/apache/phoenix/pull/1223#discussion_r631456219
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixTableLevelMetricsIT.java
##########
@@ -0,0 +1,1241 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.monitoring;
+
+import com.google.common.collect.Maps;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.DoNotRetryIOException;
+import org.apache.hadoop.hbase.HBaseConfiguration;
+
+import org.apache.hadoop.hbase.HBaseTestingUtility;
+import org.apache.hadoop.hbase.HRegionLocation;
+import org.apache.hadoop.hbase.client.RetriesExhaustedWithDetailsException;
+import org.apache.phoenix.end2end.BaseUniqueNamesOwnClusterIT;
+import org.apache.phoenix.end2end.NeedsOwnMiniClusterTest;
+import org.apache.phoenix.exception.PhoenixIOException;
+import org.apache.phoenix.exception.SQLExceptionInfo;
+import org.apache.phoenix.execute.CommitException;
+import org.apache.phoenix.jdbc.PhoenixConnection;
+import org.apache.phoenix.jdbc.PhoenixEmbeddedDriver;
+import org.apache.phoenix.jdbc.PhoenixTestDriver;
+import org.apache.phoenix.query.BaseTest;
+import org.apache.phoenix.query.ConfigurationFactory;
+import org.apache.phoenix.query.ConnectionQueryServices;
+import org.apache.phoenix.query.ConnectionQueryServicesImpl;
+import org.apache.phoenix.query.QueryServices;
+import org.apache.phoenix.query.QueryServicesTestImpl;
+import org.apache.phoenix.util.DelayedOrFailingRegionServer;
+import org.apache.phoenix.util.EnvironmentEdge;
+import org.apache.phoenix.util.EnvironmentEdgeManager;
+import org.apache.phoenix.util.InstanceResolver;
+import org.apache.phoenix.util.PhoenixRuntime;
+import org.apache.phoenix.util.ReadOnlyProps;
+
+import org.junit.AfterClass;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.BeforeClass;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+import static org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.SYSTEM_CATALOG_NAME;
Review comment:
unused import
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1223: PHOENIX-6397 Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1223:
URL: https://github.com/apache/phoenix/pull/1223#issuecomment-833363633
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 4m 20s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 14m 18s | 4.x passed |
| +1 :green_heart: | compile | 1m 0s | 4.x passed |
| +1 :green_heart: | checkstyle | 3m 3s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 45s | 4.x passed |
| +0 :ok: | spotbugs | 3m 1s | phoenix-core in 4.x has 945 extant spotbugs warnings. |
| -0 :warning: | patch | 3m 9s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 47s | the patch passed |
| +1 :green_heart: | compile | 1m 0s | the patch passed |
| +1 :green_heart: | javac | 1m 0s | the patch passed |
| -1 :x: | checkstyle | 3m 24s | phoenix-core: The patch generated 709 new + 6124 unchanged - 86 fixed = 6833 total (was 6210) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 45s | the patch passed |
| -1 :x: | spotbugs | 3m 15s | phoenix-core generated 5 new + 945 unchanged - 0 fixed = 950 total (was 945) |
||| _ Other Tests _ |
| -1 :x: | unit | 135m 5s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 51s | The patch does not generate ASF License warnings. |
| | | 179m 39s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | Load of known null value in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:[line 88] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.options from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 57] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isMetricPublisherEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 69] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isTableLevelMetricsEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 58] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.tableClientMetricsMapping from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 61] |
| Failed junit tests | phoenix.monitoring.PhoenixTableLevelMetricsIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1223 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux e1333fd65f78 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / aacab94 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/1/testReport/ |
| Max. process+thread count | 5911 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/1/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] yanxinyi commented on pull request #1223: PHOENIX-6397 Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries
Posted by GitBox <gi...@apache.org>.
yanxinyi commented on pull request #1223:
URL: https://github.com/apache/phoenix/pull/1223#issuecomment-833661657
@vmeka2020 the test failures seem related to your code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1223: PHOENIX-6397 Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1223:
URL: https://github.com/apache/phoenix/pull/1223#issuecomment-834819865
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 31s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 13m 53s | 4.x passed |
| +1 :green_heart: | compile | 1m 0s | 4.x passed |
| +1 :green_heart: | checkstyle | 3m 2s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 46s | 4.x passed |
| +0 :ok: | spotbugs | 3m 1s | phoenix-core in 4.x has 945 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 44s | the patch passed |
| +1 :green_heart: | compile | 1m 2s | the patch passed |
| +1 :green_heart: | javac | 1m 2s | the patch passed |
| -1 :x: | checkstyle | 3m 22s | phoenix-core: The patch generated 753 new + 6080 unchanged - 130 fixed = 6833 total (was 6210) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 46s | the patch passed |
| -1 :x: | spotbugs | 3m 13s | phoenix-core generated 5 new + 945 unchanged - 0 fixed = 950 total (was 945) |
||| _ Other Tests _ |
| -1 :x: | unit | 135m 55s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 50s | The patch does not generate ASF License warnings. |
| | | 176m 12s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | Load of known null value in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:[line 88] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.options from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 57] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isMetricPublisherEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 69] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isTableLevelMetricsEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 58] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.tableClientMetricsMapping from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 61] |
| Failed junit tests | phoenix.end2end.AuditLoggingIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/5/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1223 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux e89801442dbf 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / ddc3996 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/5/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/5/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/5/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/5/testReport/ |
| Max. process+thread count | 5753 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/5/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1223: PHOENIX-6397 Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1223:
URL: https://github.com/apache/phoenix/pull/1223#issuecomment-840402468
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 14m 12s | 4.x passed |
| +1 :green_heart: | compile | 1m 0s | 4.x passed |
| +1 :green_heart: | checkstyle | 3m 2s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 49s | 4.x passed |
| +0 :ok: | spotbugs | 3m 5s | phoenix-core in 4.x has 946 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 39s | the patch passed |
| +1 :green_heart: | compile | 1m 1s | the patch passed |
| +1 :green_heart: | javac | 1m 1s | the patch passed |
| -1 :x: | checkstyle | 3m 22s | phoenix-core: The patch generated 710 new + 6125 unchanged - 87 fixed = 6835 total (was 6212) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 41s | the patch passed |
| -1 :x: | spotbugs | 3m 16s | phoenix-core generated 5 new + 946 unchanged - 0 fixed = 951 total (was 946) |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 203m 5s | phoenix-core in the patch passed. |
| +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. |
| | | 241m 5s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | Load of known null value in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:[line 88] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.options from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 57] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isMetricPublisherEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 69] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isTableLevelMetricsEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 58] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.tableClientMetricsMapping from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 61] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/10/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1223 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux aef3e5dd294e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 5159f6e |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/10/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/10/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/10/testReport/ |
| Max. process+thread count | 5315 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/10/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] vmeka2020 commented on pull request #1223: PHOENIX-6397 Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries
Posted by GitBox <gi...@apache.org>.
vmeka2020 commented on pull request #1223:
URL: https://github.com/apache/phoenix/pull/1223#issuecomment-833260766
@yanxinyi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1223: PHOENIX-6397 Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1223:
URL: https://github.com/apache/phoenix/pull/1223#issuecomment-833821084
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 29s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 14m 15s | 4.x passed |
| +1 :green_heart: | compile | 0m 59s | 4.x passed |
| +1 :green_heart: | checkstyle | 3m 2s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 46s | 4.x passed |
| +0 :ok: | spotbugs | 3m 3s | phoenix-core in 4.x has 945 extant spotbugs warnings. |
| -0 :warning: | patch | 3m 11s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 39s | the patch passed |
| +1 :green_heart: | compile | 1m 1s | the patch passed |
| +1 :green_heart: | javac | 1m 1s | the patch passed |
| -1 :x: | checkstyle | 3m 20s | phoenix-core: The patch generated 754 new + 6081 unchanged - 131 fixed = 6835 total (was 6212) |
| +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 46s | the patch passed |
| -1 :x: | spotbugs | 3m 14s | phoenix-core generated 5 new + 945 unchanged - 0 fixed = 950 total (was 945) |
||| _ Other Tests _ |
| -1 :x: | unit | 150m 44s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 48s | The patch does not generate ASF License warnings. |
| | | 191m 27s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | Load of known null value in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:[line 88] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.options from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 57] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isMetricPublisherEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 69] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isTableLevelMetricsEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 58] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.tableClientMetricsMapping from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 61] |
| Failed junit tests | phoenix.monitoring.PhoenixTableLevelMetricsIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1223 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 4f65c5f4b276 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / aacab94 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/2/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/2/testReport/ |
| Max. process+thread count | 5857 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/2/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1223: PHOENIX-6397 Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1223:
URL: https://github.com/apache/phoenix/pull/1223#issuecomment-837399896
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 8s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 15m 14s | 4.x passed |
| +1 :green_heart: | compile | 1m 5s | 4.x passed |
| +1 :green_heart: | checkstyle | 2m 7s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 48s | 4.x passed |
| +0 :ok: | spotbugs | 3m 17s | phoenix-core in 4.x has 945 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 47s | the patch passed |
| +1 :green_heart: | compile | 1m 4s | the patch passed |
| +1 :green_heart: | javac | 1m 4s | the patch passed |
| -1 :x: | checkstyle | 2m 18s | phoenix-core: The patch generated 709 new + 6124 unchanged - 86 fixed = 6833 total (was 6210) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 46s | the patch passed |
| -1 :x: | spotbugs | 3m 31s | phoenix-core generated 5 new + 945 unchanged - 0 fixed = 950 total (was 945) |
||| _ Other Tests _ |
| -1 :x: | unit | 204m 55s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 41s | The patch does not generate ASF License warnings. |
| | | 246m 43s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | Load of known null value in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:[line 88] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.options from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 57] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isMetricPublisherEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 69] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isTableLevelMetricsEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 58] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.tableClientMetricsMapping from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 61] |
| Failed junit tests | phoenix.end2end.AuditLoggingIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/7/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1223 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 7ce4bc6e5401 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 6ac64c4 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/7/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/7/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/7/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/7/testReport/ |
| Max. process+thread count | 4799 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/7/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] yanxinyi merged pull request #1223: PHOENIX-6397 Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries
Posted by GitBox <gi...@apache.org>.
yanxinyi merged pull request #1223:
URL: https://github.com/apache/phoenix/pull/1223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] yanxinyi commented on a change in pull request #1223: PHOENIX-6397 Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries
Posted by GitBox <gi...@apache.org>.
yanxinyi commented on a change in pull request #1223:
URL: https://github.com/apache/phoenix/pull/1223#discussion_r631460488
##########
File path: phoenix-core/src/test/java/org/apache/phoenix/monitoring/TableClientMetricsTest.java
##########
@@ -0,0 +1,217 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.phoenix.monitoring;
+
+import static org.junit.Assert.assertTrue;
+
+import java.util.List;
+
+import org.apache.hadoop.conf.Configuration;
+import org.junit.Test;
+import java.util.HashMap;
+import java.util.Map;
+
+import static org.apache.phoenix.monitoring.MetricType.COUNT_ROWS_SCANNED;
+import static org.apache.phoenix.monitoring.MetricType.DELETE_MUTATION_BYTES;
+import static org.apache.phoenix.monitoring.MetricType.DELETE_MUTATION_SQL_COUNTER;
+import static org.apache.phoenix.monitoring.MetricType.MUTATION_BATCH_SIZE;
+import static org.apache.phoenix.monitoring.MetricType.MUTATION_COMMIT_TIME;
+import static org.apache.phoenix.monitoring.MetricType.MUTATION_SQL_COUNTER;
+import static org.apache.phoenix.monitoring.MetricType.QUERY_FAILED_COUNTER;
+import static org.apache.phoenix.monitoring.MetricType.QUERY_TIMEOUT_COUNTER;
+import static org.apache.phoenix.monitoring.MetricType.SCAN_BYTES;
+import static org.apache.phoenix.monitoring.MetricType.SELECT_POINTLOOKUP_FAILED_SQL_COUNTER;
+import static org.apache.phoenix.monitoring.MetricType.SELECT_POINTLOOKUP_SUCCESS_SQL_COUNTER;
+import static org.apache.phoenix.monitoring.MetricType.SELECT_SCAN_FAILED_SQL_COUNTER;
+import static org.apache.phoenix.monitoring.MetricType.SELECT_SCAN_SUCCESS_SQL_COUNTER;
+import static org.apache.phoenix.monitoring.MetricType.SELECT_SQL_QUERY_TIME;
+import static org.apache.phoenix.monitoring.MetricType.TASK_END_TO_END_TIME;
+import static org.apache.phoenix.monitoring.MetricType.UPSERT_MUTATION_BYTES;
+import static org.apache.phoenix.monitoring.MetricType.UPSERT_MUTATION_SQL_COUNTER;
+import static org.apache.phoenix.monitoring.TableLevelMetricsTestData.countRowsScannedCounter;
+import static org.apache.phoenix.monitoring.TableLevelMetricsTestData.deleteMutationByesCounter;
+import static org.apache.phoenix.monitoring.TableLevelMetricsTestData.deleteMutationSqlCounter;
+import static org.apache.phoenix.monitoring.TableLevelMetricsTestData.mutationBatchSizeCounter;
+import static org.apache.phoenix.monitoring.TableLevelMetricsTestData.mutationSqlCommitTimeCounter;
+import static org.apache.phoenix.monitoring.TableLevelMetricsTestData.mutationSqlCounter;
+import static org.apache.phoenix.monitoring.TableLevelMetricsTestData.queryFailedCounter;
+import static org.apache.phoenix.monitoring.TableLevelMetricsTestData.queryTimeOutCounter;
+import static org.apache.phoenix.monitoring.TableLevelMetricsTestData.scanBytesCounter;
+import static org.apache.phoenix.monitoring.TableLevelMetricsTestData.selectPointLookUpFailedCounter;
+import static org.apache.phoenix.monitoring.TableLevelMetricsTestData.selectPointLookUpSuccessCounter;
+import static org.apache.phoenix.monitoring.TableLevelMetricsTestData.selectScanFailedCounter;
+import static org.apache.phoenix.monitoring.TableLevelMetricsTestData.selectScanSuccessCounter;
+import static org.apache.phoenix.monitoring.TableLevelMetricsTestData.selectSqlQueryTimeCounter;
+import static org.apache.phoenix.monitoring.TableLevelMetricsTestData.taskEndToEndTimeCounter;
+import static org.apache.phoenix.monitoring.TableLevelMetricsTestData.upsertMutationBytesCounter;
+import static org.apache.phoenix.monitoring.TableLevelMetricsTestData.upsertMutationSqlCounter;
+import static org.apache.phoenix.monitoring.TableLevelMetricsTestData.tableNames;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
Review comment:
extra import on line 67 and 21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1223: PHOENIX-6397 Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1223:
URL: https://github.com/apache/phoenix/pull/1223#issuecomment-837837008
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 7s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 15m 34s | 4.x passed |
| +1 :green_heart: | compile | 1m 5s | 4.x passed |
| +1 :green_heart: | checkstyle | 2m 7s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 49s | 4.x passed |
| +0 :ok: | spotbugs | 3m 17s | phoenix-core in 4.x has 945 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 53s | the patch passed |
| +1 :green_heart: | compile | 1m 6s | the patch passed |
| +1 :green_heart: | javac | 1m 6s | the patch passed |
| -1 :x: | checkstyle | 2m 19s | phoenix-core: The patch generated 709 new + 6124 unchanged - 86 fixed = 6833 total (was 6210) |
| +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 48s | the patch passed |
| -1 :x: | spotbugs | 3m 35s | phoenix-core generated 5 new + 945 unchanged - 0 fixed = 950 total (was 945) |
||| _ Other Tests _ |
| -1 :x: | unit | 199m 15s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 40s | The patch does not generate ASF License warnings. |
| | | 241m 24s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | Load of known null value in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:[line 88] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.options from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 57] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isMetricPublisherEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 69] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isTableLevelMetricsEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 58] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.tableClientMetricsMapping from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 61] |
| Failed junit tests | phoenix.end2end.AuditLoggingIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/8/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1223 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux a463bf6aa2bf 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 6ac64c4 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/8/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/8/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/8/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/8/testReport/ |
| Max. process+thread count | 5185 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1223/8/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org