You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "lowka (via GitHub)" <gi...@apache.org> on 2023/06/02 12:36:20 UTC
[GitHub] [ignite-3] lowka opened a new pull request, #2140: [IGNITE-19587] Sql. Remove execution-related part from IgniteTable.
lowka opened a new pull request, #2140:
URL: https://github.com/apache/ignite-3/pull/2140
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] korlov42 merged pull request #2140: IGNITE-19587: Sql. Remove execution-related part from IgniteTable.
Posted by "korlov42 (via GitHub)" <gi...@apache.org>.
korlov42 merged PR #2140:
URL: https://github.com/apache/ignite-3/pull/2140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] lowka commented on a diff in pull request #2140: [IGNITE-19587] Sql. Remove execution-related part from IgniteTable.
Posted by "lowka (via GitHub)" <gi...@apache.org>.
lowka commented on code in PR #2140:
URL: https://github.com/apache/ignite-3/pull/2140#discussion_r1226780794
##########
modules/core/src/main/java/org/apache/ignite/internal/thread/StripedThreadPoolExecutor.java:
##########
@@ -105,7 +106,7 @@ public void execute(Runnable cmd) {
* @throws NullPointerException if the task is {@code null}.
*/
public CompletableFuture<?> submit(Runnable task, int idx) {
- return CompletableFuture.runAsync(task, execs[threadId(idx)]);
+ return CompletableFuture.runAsync(task, commandExecutor(idx));
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] lowka commented on a diff in pull request #2140: [IGNITE-19587] Sql. Remove execution-related part from IgniteTable.
Posted by "lowka (via GitHub)" <gi...@apache.org>.
lowka commented on code in PR #2140:
URL: https://github.com/apache/ignite-3/pull/2140#discussion_r1227689796
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutableTable.java:
##########
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.sql.engine.exec;
+
+import org.apache.ignite.internal.table.InternalTable;
+
+/**
+ * Execution related APIs of a table.
+ */
+public interface ExecutableTable {
+
+ /**
+ * Returns read API.
+ */
+ InternalTable table();
Review Comment:
will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2140: [IGNITE-19587] Sql. Remove execution-related part from IgniteTable.
Posted by "AMashenkov (via GitHub)" <gi...@apache.org>.
AMashenkov commented on code in PR #2140:
URL: https://github.com/apache/ignite-3/pull/2140#discussion_r1226776026
##########
modules/core/src/main/java/org/apache/ignite/internal/thread/StripedThreadPoolExecutor.java:
##########
@@ -105,7 +106,7 @@ public void execute(Runnable cmd) {
* @throws NullPointerException if the task is {@code null}.
*/
public CompletableFuture<?> submit(Runnable task, int idx) {
- return CompletableFuture.runAsync(task, execs[threadId(idx)]);
+ return CompletableFuture.runAsync(task, commandExecutor(idx));
Review Comment:
`@param idx` is missed in javadoc.
Would you please fix this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] lowka commented on a diff in pull request #2140: [IGNITE-19587] Sql. Remove execution-related part from IgniteTable.
Posted by "lowka (via GitHub)" <gi...@apache.org>.
lowka commented on code in PR #2140:
URL: https://github.com/apache/ignite-3/pull/2140#discussion_r1228296263
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/QueryTaskExecutor.java:
##########
@@ -45,4 +45,13 @@ public interface QueryTaskExecutor extends LifecycleAware, Executor {
* @return the new CompletableFuture
*/
CompletableFuture<?> submit(UUID qryId, long fragmentId, Runnable qryTask);
+
+ /**
+ * Returns an executor that is responsible for the given query fragment.
+ *
+ * @param qryId Query ID.
+ * @param fragmentId Fragment ID.
+ * @return An executor.
+ */
+ Executor fragmentExecutor(UUID qryId, long fragmentId);
Review Comment:
Done.
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java:
##########
@@ -114,6 +116,9 @@ public class SqlQueryProcessor implements QueryProcessor {
/** Size of the cache for query plans. */
private static final int PLAN_CACHE_SIZE = 1024;
+ /** Size of the table access cache. */
+ public static final int TABLE_CACHE_SIZE = 1024;
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] lowka commented on a diff in pull request #2140: [IGNITE-19587] Sql. Remove execution-related part from IgniteTable.
Posted by "lowka (via GitHub)" <gi...@apache.org>.
lowka commented on code in PR #2140:
URL: https://github.com/apache/ignite-3/pull/2140#discussion_r1228296810
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutableTable.java:
##########
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.sql.engine.exec;
+
+import org.apache.ignite.internal.table.InternalTable;
+
+/**
+ * Execution related APIs of a table.
+ */
+public interface ExecutableTable {
+
+ /**
+ * Returns read API.
+ */
+ InternalTable table();
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2140: [IGNITE-19587] Sql. Remove execution-related part from IgniteTable.
Posted by "korlov42 (via GitHub)" <gi...@apache.org>.
korlov42 commented on code in PR #2140:
URL: https://github.com/apache/ignite-3/pull/2140#discussion_r1226605360
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/QueryTaskExecutor.java:
##########
@@ -45,4 +45,13 @@ public interface QueryTaskExecutor extends LifecycleAware, Executor {
* @return the new CompletableFuture
*/
CompletableFuture<?> submit(UUID qryId, long fragmentId, Runnable qryTask);
+
+ /**
+ * Returns an executor that is responsible for the given query fragment.
+ *
+ * @param qryId Query ID.
+ * @param fragmentId Fragment ID.
+ * @return An executor.
+ */
+ Executor fragmentExecutor(UUID qryId, long fragmentId);
Review Comment:
Sole purpose of query task executer is to hide presence of several executers, while providing necessary guarantee for execution order of tasks from the same fragment.
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutableTable.java:
##########
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.sql.engine.exec;
+
+import org.apache.ignite.internal.table.InternalTable;
+
+/**
+ * Execution related APIs of a table.
+ */
+public interface ExecutableTable {
+
+ /**
+ * Returns read API.
+ */
+ InternalTable table();
Review Comment:
It's better to introduce something like ScannableTable (similar to UpdateableTable).
BTW, let's rename UpdateableTable --> UpdatableTable to make naming more consistent
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java:
##########
@@ -114,6 +116,9 @@ public class SqlQueryProcessor implements QueryProcessor {
/** Size of the cache for query plans. */
private static final int PLAN_CACHE_SIZE = 1024;
+ /** Size of the table access cache. */
+ public static final int TABLE_CACHE_SIZE = 1024;
Review Comment:
why `public`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org