You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2015/06/16 12:28:30 UTC
[Bug 58039] New: [PATCH] Make D* functions thread safe
https://bz.apache.org/bugzilla/show_bug.cgi?id=58039
Bug ID: 58039
Summary: [PATCH] Make D* functions thread safe
Product: POI
Version: 3.13-dev
Hardware: PC
Status: NEW
Severity: normal
Priority: P2
Component: SS Common
Assignee: dev@poi.apache.org
Reporter: patrick.zimmermann@haltec.de
Created attachment 32825
--> https://bz.apache.org/bugzilla/attachment.cgi?id=32825&action=edit
dstar_threading.patch
The DGet/DMin implementations relied on class variables. They thus
unpredictably returned wrong values when using them in a multithreaded
environment.
This patch fixes this.
The code is tested, but whether the multithreading issues I encountered are
actually gone will only show in a week or two. It's a rather simple patch, so
I'm quite confident anyways.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 58039] [PATCH] Make D* functions thread safe
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58039
--- Comment #2 from Patrick Zimmermann <pa...@haltec.de> ---
This patch has proven reliable in our production system over the past two
months. Is there any reason for not merging?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 58039] [PATCH] Make D* functions thread safe
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58039
Patrick Zimmermann <pa...@haltec.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
OS| |All
--- Comment #1 from Patrick Zimmermann <pa...@haltec.de> ---
Just noticed that this bug also affects non-threaded but nested uses of a D*
function. This patch fixes these cases also.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 58039] [PATCH] Make D* functions thread safe
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58039
Dominik Stadler <do...@gmx.at> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |PatchAvailable
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 58039] [PATCH] Make D* functions thread safe
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58039
David North <dt...@corefiling.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #3 from David North <dt...@corefiling.co.uk> ---
Looks good to me. Merged with some minor tweaks in svn r1701055
Should be in the next beta release.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org