You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by "mercyblitz (GitHub)" <gi...@apache.org> on 2020/03/24 07:04:43 UTC

[GitHub] [dubbo] mercyblitz opened pull request #5910: [LICENSE] Adding the checkstyle module for checking the Apache 2.0 License


[ Full content available at: https://github.com/apache/dubbo/pull/5910 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo] codecov-io commented on issue #5910: [LICENSE] Adding the checkstyle module for checking the Apache 2.0 License

Posted by "codecov-io (GitHub)" <gi...@apache.org>.

# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5910?src=pr&el=h1) Report
> Merging [#5910](https://codecov.io/gh/apache/dubbo/pull/5910?src=pr&el=desc) into [2.7.6-release](https://codecov.io/gh/apache/dubbo/commit/af4cff2846bdfb9f105bf32b988616a4ed40a072&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/5910/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0)](https://codecov.io/gh/apache/dubbo/pull/5910?src=pr&el=tree)

```diff
@@                 Coverage Diff                 @@
##             2.7.6-release    #5910      +/-   ##
===================================================
- Coverage            61.22%   61.20%   -0.03%     
+ Complexity             496      495       -1     
===================================================
  Files                  982      982              
  Lines                39134    39134              
  Branches              5641     5641              
===================================================
- Hits                 23961    23951      -10     
- Misses               12543    12555      +12     
+ Partials              2630     2628       -2     
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/5910?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/dubbo/registry/nacos/NacosServiceDiscovery.java](https://codecov.io/gh/apache/dubbo/pull/5910/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktbmFjb3Mvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlZ2lzdHJ5L25hY29zL05hY29zU2VydmljZURpc2NvdmVyeS5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...n/java/org/apache/dubbo/remoting/IdleSensible.java](https://codecov.io/gh/apache/dubbo/pull/5910/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9JZGxlU2Vuc2libGUuamF2YQ==) | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/dubbo/rpc/protocol/grpc/GrpcProtocol.java](https://codecov.io/gh/apache/dubbo/pull/5910/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1ncnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvcHJvdG9jb2wvZ3JwYy9HcnBjUHJvdG9jb2wuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...che/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/dubbo/pull/5910/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L21pbmEvTWluYUNoYW5uZWwuamF2YQ==) | `39.47% <0.00%> (-10.53%)` | `15.00% <0.00%> (-1.00%)` | |
| [...ng/exchange/support/header/HeartbeatTimerTask.java](https://codecov.io/gh/apache/dubbo/pull/5910/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFydGJlYXRUaW1lclRhc2suamF2YQ==) | `73.68% <0.00%> (-5.27%)` | `0.00% <0.00%> (ø%)` | |
| [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/5910/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `52.27% <0.00%> (-3.41%)` | `19.00% <0.00%> (-1.00%)` | |
| [...g/apache/dubbo/registry/consul/ConsulRegistry.java](https://codecov.io/gh/apache/dubbo/pull/5910/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktY29uc3VsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jb25zdWwvQ29uc3VsUmVnaXN0cnkuamF2YQ==) | `62.11% <0.00%> (-0.63%)` | `30.00% <0.00%> (ø%)` | |
| [...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/dubbo/pull/5910/diff?src=pr&el=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21vbml0b3IvZHViYm8vRHViYm9Nb25pdG9yLmphdmE=) | `89.52% <0.00%> (+0.95%)` | `17.00% <0.00%> (+1.00%)` | |
| [.../threadpool/manager/DefaultExecutorRepository.java](https://codecov.io/gh/apache/dubbo/pull/5910/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGhyZWFkcG9vbC9tYW5hZ2VyL0RlZmF1bHRFeGVjdXRvclJlcG9zaXRvcnkuamF2YQ==) | `62.50% <0.00%> (+1.78%)` | `0.00% <0.00%> (ø%)` | |
| [...ache/dubbo/remoting/transport/AbstractChannel.java](https://codecov.io/gh/apache/dubbo/pull/5910/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RDaGFubmVsLmphdmE=) | `87.50% <0.00%> (+12.50%)` | `0.00% <0.00%> (ø%)` | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/5910?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/5910?src=pr&el=footer). Last update [af4cff2...96a0fa3](https://codecov.io/gh/apache/dubbo/pull/5910?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo/pull/5910 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo] htynkn commented on issue #5910: [LICENSE] Adding the checkstyle module for checking the Apache 2.0 License

Posted by "htynkn (GitHub)" <gi...@apache.org>.

I thought rat plugin are doing this check at this moment?

[ Full content available at: https://github.com/apache/dubbo/pull/5910 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo] slievrly commented on issue #5910: [LICENSE] Adding the checkstyle module for checking the Apache 2.0 License

Posted by "slievrly (GitHub)" <gi...@apache.org>.

It is best to automatically add and format copyright header when executing maven goals. I recommend use the `com.mycila:license-maven-plugin` plugin.
![image](https://user-images.githubusercontent.com/8758457/77526682-f0747c80-6ec5-11ea-8430-9c24c6a2ea4a.png)







[ Full content available at: https://github.com/apache/dubbo/pull/5910 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org