You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jordan Birdsell (Code Review)" <ge...@cloudera.org> on 2016/10/23 20:05:22 UTC
[kudu-CR] KUDU-1723 - [python] Enable setting of default values
Jordan Birdsell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4818
Change subject: KUDU-1723 - [python] Enable setting of default values
......................................................................
KUDU-1723 - [python] Enable setting of default values
This patch enables the python client to set default column
values when adding columns to a SchemaBuilder. Some KuduValue
logic needed to be decoupled from scan predicates to enable this.
Existing tests were modified for this patch.
Change-Id: I78008c5ca3646e0b1fdf47bbc0bc14af1b88166e
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/schema.pxd
M python/kudu/schema.pyx
M python/kudu/tests/common.py
M python/kudu/tests/util.py
6 files changed, 84 insertions(+), 50 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/4818/1
--
To view, visit http://gerrit.cloudera.org:8080/4818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I78008c5ca3646e0b1fdf47bbc0bc14af1b88166e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
[kudu-CR] KUDU-1690 - [python] Enable setting of default values
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has submitted this change and it was merged.
Change subject: KUDU-1690 - [python] Enable setting of default values
......................................................................
KUDU-1690 - [python] Enable setting of default values
This patch enables the python client to set default column
values when adding columns to a SchemaBuilder. Some KuduValue
logic needed to be decoupled from scan predicates to enable this.
Existing tests were modified for this patch.
Change-Id: I78008c5ca3646e0b1fdf47bbc0bc14af1b88166e
Reviewed-on: http://gerrit.cloudera.org:8080/4818
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
Tested-by: Kudu Jenkins
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/schema.pxd
M python/kudu/schema.pyx
M python/kudu/tests/common.py
M python/kudu/tests/util.py
6 files changed, 87 insertions(+), 50 deletions(-)
Approvals:
Jean-Daniel Cryans: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I78008c5ca3646e0b1fdf47bbc0bc14af1b88166e
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-1690 - [python] Enable setting of default values
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4818
to look at the new patch set (#6).
Change subject: KUDU-1690 - [python] Enable setting of default values
......................................................................
KUDU-1690 - [python] Enable setting of default values
This patch enables the python client to set default column
values when adding columns to a SchemaBuilder. Some KuduValue
logic needed to be decoupled from scan predicates to enable this.
Existing tests were modified for this patch.
Change-Id: I78008c5ca3646e0b1fdf47bbc0bc14af1b88166e
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/schema.pxd
M python/kudu/schema.pyx
M python/kudu/tests/common.py
M python/kudu/tests/util.py
6 files changed, 87 insertions(+), 50 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/4818/6
--
To view, visit http://gerrit.cloudera.org:8080/4818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I78008c5ca3646e0b1fdf47bbc0bc14af1b88166e
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-1690 - [python] Enable setting of default values
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.
Change subject: KUDU-1690 - [python] Enable setting of default values
......................................................................
Patch Set 3:
> Patch Set 3: Code-Review+1
Deliberately a +1\u2026I feel good reviewing the python, but given there was a bit of a change to the python <-> c++ mapping I\u2019m being cautious and wanting someone more familiar with that mechanism to also review.
--
To view, visit http://gerrit.cloudera.org:8080/4818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78008c5ca3646e0b1fdf47bbc0bc14af1b88166e
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] KUDU-1690 - [python] Enable setting of default values
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4818
to look at the new patch set (#3).
Change subject: KUDU-1690 - [python] Enable setting of default values
......................................................................
KUDU-1690 - [python] Enable setting of default values
This patch enables the python client to set default column
values when adding columns to a SchemaBuilder. Some KuduValue
logic needed to be decoupled from scan predicates to enable this.
Existing tests were modified for this patch.
Change-Id: I78008c5ca3646e0b1fdf47bbc0bc14af1b88166e
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/schema.pxd
M python/kudu/schema.pyx
M python/kudu/tests/common.py
M python/kudu/tests/util.py
6 files changed, 86 insertions(+), 50 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/4818/3
--
To view, visit http://gerrit.cloudera.org:8080/4818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I78008c5ca3646e0b1fdf47bbc0bc14af1b88166e
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-1690 - [python] Enable setting of default values
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4818
to look at the new patch set (#5).
Change subject: KUDU-1690 - [python] Enable setting of default values
......................................................................
KUDU-1690 - [python] Enable setting of default values
This patch enables the python client to set default column
values when adding columns to a SchemaBuilder. Some KuduValue
logic needed to be decoupled from scan predicates to enable this.
Existing tests were modified for this patch.
Change-Id: I78008c5ca3646e0b1fdf47bbc0bc14af1b88166e
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/schema.pxd
M python/kudu/schema.pyx
M python/kudu/tests/common.py
M python/kudu/tests/util.py
6 files changed, 87 insertions(+), 50 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/4818/5
--
To view, visit http://gerrit.cloudera.org:8080/4818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I78008c5ca3646e0b1fdf47bbc0bc14af1b88166e
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-1690 - [python] Enable setting of default values
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has uploaded a new patch set (#2).
Change subject: KUDU-1690 - [python] Enable setting of default values
......................................................................
KUDU-1690 - [python] Enable setting of default values
This patch enables the python client to set default column
values when adding columns to a SchemaBuilder. Some KuduValue
logic needed to be decoupled from scan predicates to enable this.
Existing tests were modified for this patch.
Change-Id: I78008c5ca3646e0b1fdf47bbc0bc14af1b88166e
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/schema.pxd
M python/kudu/schema.pyx
M python/kudu/tests/common.py
M python/kudu/tests/util.py
6 files changed, 84 insertions(+), 50 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/4818/2
--
To view, visit http://gerrit.cloudera.org:8080/4818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I78008c5ca3646e0b1fdf47bbc0bc14af1b88166e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-1690 - [python] Enable setting of default values
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.
Change subject: KUDU-1690 - [python] Enable setting of default values
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/4818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78008c5ca3646e0b1fdf47bbc0bc14af1b88166e
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] KUDU-1690 - [python] Enable setting of default values
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: KUDU-1690 - [python] Enable setting of default values
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78008c5ca3646e0b1fdf47bbc0bc14af1b88166e
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No