You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whirr.apache.org by "Stu Hood (JIRA)" <ji...@apache.org> on 2010/12/22 00:48:00 UTC
[jira] Created: (WHIRR-173) Add ClusterAction for generic script
execution
Add ClusterAction for generic script execution
----------------------------------------------
Key: WHIRR-173
URL: https://issues.apache.org/jira/browse/WHIRR-173
Project: Whirr
Issue Type: Improvement
Reporter: Stu Hood
The usecase is that once a cluster is launched, it is useful to be able to execute named scripts against predicate-matched nodes in the cluster.
Tom indicated that this Action is likely to look almost exactly like ConfigureClusterAction: in fact, it may just be renaming ConfigureClusterAction.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Commented] (WHIRR-173) Add ClusterAction for generic script
execution
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021609#comment-13021609 ]
Andrei Savu commented on WHIRR-173:
-----------------------------------
I believe that for now it's safe to assume that all scripts executed with this command are short-running.
> Add ClusterAction for generic script execution
> ----------------------------------------------
>
> Key: WHIRR-173
> URL: https://issues.apache.org/jira/browse/WHIRR-173
> Project: Whirr
> Issue Type: Improvement
> Reporter: Stu Hood
> Assignee: Andrei Savu
> Attachments: WHIRR-173.patch
>
>
> The usecase is that once a cluster is launched, it is useful to be able to execute named scripts against predicate-matched nodes in the cluster.
> Tom indicated that this Action is likely to look almost exactly like ConfigureClusterAction: in fact, it may just be renaming ConfigureClusterAction.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-173) Add ClusterAction for generic script
execution
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025767#comment-13025767 ]
Andrei Savu commented on WHIRR-173:
-----------------------------------
Good to go in?
> Add ClusterAction for generic script execution
> ----------------------------------------------
>
> Key: WHIRR-173
> URL: https://issues.apache.org/jira/browse/WHIRR-173
> Project: Whirr
> Issue Type: Improvement
> Reporter: Stu Hood
> Assignee: Andrei Savu
> Fix For: 0.5.0
>
> Attachments: WHIRR-173.patch, WHIRR-173.patch
>
>
> The usecase is that once a cluster is launched, it is useful to be able to execute named scripts against predicate-matched nodes in the cluster.
> Tom indicated that this Action is likely to look almost exactly like ConfigureClusterAction: in fact, it may just be renaming ConfigureClusterAction.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WHIRR-173) Add ClusterAction for generic script
execution
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated WHIRR-173:
------------------------------
Attachment: WHIRR-173.patch
I've updated the patch and added some tests. I'm moving to WHIRR-246.
> Add ClusterAction for generic script execution
> ----------------------------------------------
>
> Key: WHIRR-173
> URL: https://issues.apache.org/jira/browse/WHIRR-173
> Project: Whirr
> Issue Type: Improvement
> Reporter: Stu Hood
> Assignee: Andrei Savu
> Attachments: WHIRR-173.patch, WHIRR-173.patch
>
>
> The usecase is that once a cluster is launched, it is useful to be able to execute named scripts against predicate-matched nodes in the cluster.
> Tom indicated that this Action is likely to look almost exactly like ConfigureClusterAction: in fact, it may just be renaming ConfigureClusterAction.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-173) Add ClusterAction for generic script
execution
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021748#comment-13021748 ]
Tom White commented on WHIRR-173:
---------------------------------
Looks good. Needs a unit test like the other commands. Should we print out stdout and stderr, regardless of exit code?
Nit: Rather than saying "script.sh" in the usage string say "<script>" so it's less literal.
> Add ClusterAction for generic script execution
> ----------------------------------------------
>
> Key: WHIRR-173
> URL: https://issues.apache.org/jira/browse/WHIRR-173
> Project: Whirr
> Issue Type: Improvement
> Reporter: Stu Hood
> Assignee: Andrei Savu
> Attachments: WHIRR-173.patch
>
>
> The usecase is that once a cluster is launched, it is useful to be able to execute named scripts against predicate-matched nodes in the cluster.
> Tom indicated that this Action is likely to look almost exactly like ConfigureClusterAction: in fact, it may just be renaming ConfigureClusterAction.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (WHIRR-173) Add ClusterAction for generic script
execution
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu reassigned WHIRR-173:
---------------------------------
Assignee: Andrei Savu
> Add ClusterAction for generic script execution
> ----------------------------------------------
>
> Key: WHIRR-173
> URL: https://issues.apache.org/jira/browse/WHIRR-173
> Project: Whirr
> Issue Type: Improvement
> Reporter: Stu Hood
> Assignee: Andrei Savu
>
> The usecase is that once a cluster is launched, it is useful to be able to execute named scripts against predicate-matched nodes in the cluster.
> Tom indicated that this Action is likely to look almost exactly like ConfigureClusterAction: in fact, it may just be renaming ConfigureClusterAction.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-173) Add ClusterAction for generic script
execution
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025917#comment-13025917 ]
Tom White commented on WHIRR-173:
---------------------------------
Sorry, missed the update. +1
> Add ClusterAction for generic script execution
> ----------------------------------------------
>
> Key: WHIRR-173
> URL: https://issues.apache.org/jira/browse/WHIRR-173
> Project: Whirr
> Issue Type: Improvement
> Reporter: Stu Hood
> Assignee: Andrei Savu
> Fix For: 0.5.0
>
> Attachments: WHIRR-173.patch, WHIRR-173.patch
>
>
> The usecase is that once a cluster is launched, it is useful to be able to execute named scripts against predicate-matched nodes in the cluster.
> Tom indicated that this Action is likely to look almost exactly like ConfigureClusterAction: in fact, it may just be renaming ConfigureClusterAction.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WHIRR-173) Add ClusterAction for generic script
execution
Posted by "Adrian Cole (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974169#action_12974169 ]
Adrian Cole commented on WHIRR-173:
-----------------------------------
this should be quite easy to implement, with the only concern being what to do with the aggregated shell script responses. currently, jclouds' ComputeService.runScriptOnNodesMatching() function returns a Map<? extends NodeMetadata, ExecResponse> where the exec response may have an unsuccessful error code inside.
> Add ClusterAction for generic script execution
> ----------------------------------------------
>
> Key: WHIRR-173
> URL: https://issues.apache.org/jira/browse/WHIRR-173
> Project: Whirr
> Issue Type: Improvement
> Reporter: Stu Hood
>
> The usecase is that once a cluster is launched, it is useful to be able to execute named scripts against predicate-matched nodes in the cluster.
> Tom indicated that this Action is likely to look almost exactly like ConfigureClusterAction: in fact, it may just be renaming ConfigureClusterAction.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Updated] (WHIRR-173) Add ClusterAction for generic script
execution
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated WHIRR-173:
------------------------------
Fix Version/s: 0.5.0
Status: Patch Available (was: Open)
> Add ClusterAction for generic script execution
> ----------------------------------------------
>
> Key: WHIRR-173
> URL: https://issues.apache.org/jira/browse/WHIRR-173
> Project: Whirr
> Issue Type: Improvement
> Reporter: Stu Hood
> Assignee: Andrei Savu
> Fix For: 0.5.0
>
> Attachments: WHIRR-173.patch, WHIRR-173.patch
>
>
> The usecase is that once a cluster is launched, it is useful to be able to execute named scripts against predicate-matched nodes in the cluster.
> Tom indicated that this Action is likely to look almost exactly like ConfigureClusterAction: in fact, it may just be renaming ConfigureClusterAction.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WHIRR-173) Add ClusterAction for generic script
execution
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated WHIRR-173:
------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I've just committed this.
> Add ClusterAction for generic script execution
> ----------------------------------------------
>
> Key: WHIRR-173
> URL: https://issues.apache.org/jira/browse/WHIRR-173
> Project: Whirr
> Issue Type: Improvement
> Reporter: Stu Hood
> Assignee: Andrei Savu
> Fix For: 0.5.0
>
> Attachments: WHIRR-173.patch, WHIRR-173.patch
>
>
> The usecase is that once a cluster is launched, it is useful to be able to execute named scripts against predicate-matched nodes in the cluster.
> Tom indicated that this Action is likely to look almost exactly like ConfigureClusterAction: in fact, it may just be renaming ConfigureClusterAction.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WHIRR-173) Add ClusterAction for generic script
execution
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated WHIRR-173:
------------------------------
Attachment: WHIRR-173.patch
A bit ugly but working patch. I will refactor the code soon. Let me know what you think.
The code is only tested on AWS but it should work anywhere thanks to jclouds.
> Add ClusterAction for generic script execution
> ----------------------------------------------
>
> Key: WHIRR-173
> URL: https://issues.apache.org/jira/browse/WHIRR-173
> Project: Whirr
> Issue Type: Improvement
> Reporter: Stu Hood
> Assignee: Andrei Savu
> Attachments: WHIRR-173.patch
>
>
> The usecase is that once a cluster is launched, it is useful to be able to execute named scripts against predicate-matched nodes in the cluster.
> Tom indicated that this Action is likely to look almost exactly like ConfigureClusterAction: in fact, it may just be renaming ConfigureClusterAction.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-173) Add ClusterAction for generic script
execution
Posted by "Adrian Cole (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021043#comment-13021043 ]
Adrian Cole commented on WHIRR-173:
-----------------------------------
I have a compute example called exec for this. you may want to add a flag as to whether the command is long-running or not. For example, executing "uptime" doesn't need to be run init style, so you'd want to set wrapInInitScript(false).
https://github.com/jclouds/jclouds-examples/blob/master/compute-basics/src/main/java/org/jclouds/examples/compute/basics/MainApp.java
> Add ClusterAction for generic script execution
> ----------------------------------------------
>
> Key: WHIRR-173
> URL: https://issues.apache.org/jira/browse/WHIRR-173
> Project: Whirr
> Issue Type: Improvement
> Reporter: Stu Hood
> Assignee: Andrei Savu
>
> The usecase is that once a cluster is launched, it is useful to be able to execute named scripts against predicate-matched nodes in the cluster.
> Tom indicated that this Action is likely to look almost exactly like ConfigureClusterAction: in fact, it may just be renaming ConfigureClusterAction.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira