[GitHub] [airflow] Taragolis commented on a diff in pull request #34570: do not fail operator if we cannot find logs

["Taragolis (via GitHub)" <gi...@apache.org>]

Taragolis commented on code in PR #34570:
URL: https://github.com/apache/airflow/pull/34570#discussion_r1334878879


##########
airflow/providers/amazon/aws/operators/batch.py:
##########
@@ -359,7 +359,12 @@ def monitor_job(self, context: Context):
             else:
                 self.hook.wait_for_job(self.job_id)
 
-        awslogs = self.hook.get_job_all_awslogs_info(self.job_id)
+        awslogs = []
+        try:
+            awslogs = self.hook.get_job_all_awslogs_info(self.job_id)
+        except AirflowException as ae:
+            self.log.warning("cannot determine where to find aws logs for this batch job: %s", ae)

Review Comment:
   I think this is happen because we lack of support AWS Batch on EKS in the BatchOperator.
   So it might work on simple case and fail on logs but it general it could fail in other places too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org