You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tez.apache.org by ks...@apache.org on 2017/10/27 21:49:39 UTC
tez git commit: TEZ-3858. Misleading dag level diagnostics in case of
invalid vertex event (Zhiyuan Yang via kshukla)
Repository: tez
Updated Branches:
refs/heads/master 8247a643f -> 87d7c145f
TEZ-3858. Misleading dag level diagnostics in case of invalid vertex event (Zhiyuan Yang via kshukla)
Project: http://git-wip-us.apache.org/repos/asf/tez/repo
Commit: http://git-wip-us.apache.org/repos/asf/tez/commit/87d7c145
Tree: http://git-wip-us.apache.org/repos/asf/tez/tree/87d7c145
Diff: http://git-wip-us.apache.org/repos/asf/tez/diff/87d7c145
Branch: refs/heads/master
Commit: 87d7c145ffc71707d1d393fddf94efa2a77d8822
Parents: 8247a64
Author: Kuhu Shukla <ks...@yahoo-inc.com>
Authored: Fri Oct 27 16:48:03 2017 -0500
Committer: Kuhu Shukla <ks...@yahoo-inc.com>
Committed: Fri Oct 27 16:48:03 2017 -0500
----------------------------------------------------------------------
.../java/org/apache/tez/dag/app/dag/impl/VertexImpl.java | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tez/blob/87d7c145/tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/VertexImpl.java
----------------------------------------------------------------------
diff --git a/tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/VertexImpl.java b/tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/VertexImpl.java
index 0bd73ee..c329ec7 100644
--- a/tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/VertexImpl.java
+++ b/tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/VertexImpl.java
@@ -4061,11 +4061,9 @@ public class VertexImpl implements org.apache.tez.dag.app.dag.Vertex, EventHandl
SingleArcTransition<VertexImpl, VertexEvent> {
@Override
public void transition(VertexImpl vertex, VertexEvent event) {
- LOG.error("Invalid event " + event.getType() + " on Vertex "
- + vertex.getLogIdentifier());
- vertex.eventHandler.handle(new DAGEventDiagnosticsUpdate(
- vertex.getDAGId(), "Invalid event " + event.getType()
- + " on Vertex " + vertex.getLogIdentifier()));
+ String msg = "Invalid event on Vertex " + vertex.getLogIdentifier();
+ LOG.error(msg);
+ vertex.eventHandler.handle(new DAGEventDiagnosticsUpdate(vertex.getDAGId(), msg));
vertex.setFinishTime();
vertex.trySetTerminationCause(VertexTerminationCause.INTERNAL_ERROR);
vertex.cancelCommits();