You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2023/01/18 08:58:07 UTC
[GitHub] [cloudstack] weizhouapache opened a new pull request, #7103: VR: fix public-key is missing in VR after acquiring public IP
weizhouapache opened a new pull request, #7103:
URL: https://github.com/apache/cloudstack/pull/7103
### Description
This fixes #6765
The following command (in vm) worked before acquiring IP but did not work after that root$ curl http://<gateway>/latest/meta-data/public-keys
in VR, the file is empty:
root@r-40-VM:/var/www/html/metadata/<VM IP># ls -l public-keys -rw-r--r-- 1 root root 0 Jan 17 18:41 public-keys
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [x] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7103: VR: fix public-key is missing in VR after acquiring public IP
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7103:
URL: https://github.com/apache/cloudstack/pull/7103#issuecomment-1396742968
@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7103: VR: fix public-key is missing in VR after acquiring public IP
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #7103:
URL: https://github.com/apache/cloudstack/pull/7103#issuecomment-1386773635
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7103)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7103&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7103&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7103&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7103&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7103&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7103&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7103&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7103&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7103&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7103&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7103&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7103&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7103&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7103&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7103&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7103&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7103: VR: fix public-key is missing in VR after acquiring public IP
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #7103:
URL: https://github.com/apache/cloudstack/pull/7103#issuecomment-1398054083
@weizhouapache copying from the issue, did you test this using the below scenario?
```
Steps followed using APIs:
1. Create project
2. Create VPC network
3. Register SSH key pair
4. Create new instance
5. Attach this instance to the VPC network
6. Acquire and associate public ip address to the VPC network and static nat with the instance
7. Try to access this instance using public ip and ssh key
Everything working fine, We can see the registered ssh key pair in the Cloud Stack UI under the instance details. But at the time of logging in using ssh it gives error **Permission denied (publickey).**
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #7103: VR: fix public-key is missing in VR after acquiring public IP
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #7103:
URL: https://github.com/apache/cloudstack/pull/7103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7103: VR: fix public-key is missing in VR after acquiring public IP
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7103:
URL: https://github.com/apache/cloudstack/pull/7103#issuecomment-1386928368
@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #7103: VR: fix public-key is missing in VR after acquiring public IP
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #7103:
URL: https://github.com/apache/cloudstack/pull/7103#issuecomment-1386927222
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7103: VR: fix public-key is missing in VR after acquiring public IP
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #7103:
URL: https://github.com/apache/cloudstack/pull/7103#issuecomment-1396741980
LGTM, didn't test it.
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7103: VR: fix public-key is missing in VR after acquiring public IP
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7103:
URL: https://github.com/apache/cloudstack/pull/7103#issuecomment-1397715235
<b>Trillian test result (tid-5905)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43696 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7103-t5905-kvm-centos7.zip
Smoke tests completed. 100 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 576.14 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7103: VR: fix public-key is missing in VR after acquiring public IP
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #7103:
URL: https://github.com/apache/cloudstack/pull/7103#issuecomment-1386925659
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7103?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7103](https://codecov.io/gh/apache/cloudstack/pull/7103?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eabd808) into [4.17](https://codecov.io/gh/apache/cloudstack/commit/3dc0e499dcf0656ecf718722e4c8f41cde87dbfe?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3dc0e49) will **not change** coverage.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## 4.17 #7103 +/- ##
=========================================
Coverage 10.37% 10.37%
Complexity 6643 6643
=========================================
Files 2453 2453
Lines 242410 242410
Branches 37933 37933
=========================================
Hits 25139 25139
Misses 214165 214165
Partials 3106 3106
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/7103?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...oudstack/network/topology/BasicNetworkVisitor.java](https://codecov.io/gh/apache/cloudstack/pull/7103?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL25ldHdvcmsvdG9wb2xvZ3kvQmFzaWNOZXR3b3JrVmlzaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7103: VR: fix public-key is missing in VR after acquiring public IP
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7103:
URL: https://github.com/apache/cloudstack/pull/7103#issuecomment-1386984498
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5311
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7103: VR: fix public-key is missing in VR after acquiring public IP
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7103:
URL: https://github.com/apache/cloudstack/pull/7103#issuecomment-1403331294
> 6. Acquire and associate public ip address to the VPC network and static nat with the instance
@DaanHoogland
yes, I have tested it. sometimes it worked, sometimes it did not work, depends on when the vm gets the ssh key from VR (before or after associating public IP).
with this PR, the issue is gone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org