You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Daniel Gergely <dg...@hortonworks.com> on 2016/04/11 15:12:54 UTC
Review Request 46021: Audit logging cleanup and tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46021/
-----------------------------------------------------------
Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.
Bugs: AMBARI-15804
https://issues.apache.org/jira/browse/AMBARI-15804
Repository: ambari
Description
-------
Audit logging cleanup and tests
Unit tests for creators
Adding component to host now handles multiple components
Fixing hostname for host event
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/ActivateUserRequestAuditEvent.java df5726d
ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddComponentToHostRequestAuditEvent.java 2c9eedd
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/HostEventCreator.java 7c27d19
ambari-server/src/test/java/org/apache/ambari/server/audit/request/TaskStatusAuditEventTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AlertGroupEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AlertTargetEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestBase.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestHelper.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/BlueprintEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/BlueprintExportEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ComponentEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ConfigurationChangeEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/CredentialEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/DefaultEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/GroupEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/HostEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/MemberEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/PrivilegeEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RecomendationIgnoreEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryVersionEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ServiceConfigDownloadEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ServiceEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UnauthorizedEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UpgradeEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UpgradeItemEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UserEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ValidationIgnoreEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ViewInstanceEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ViewPrivilegeEventCreatorTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/46021/diff/
Testing
-------
Still running locally...
Thanks,
Daniel Gergely
Re: Review Request 46021: Audit logging cleanup and tests
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46021/#review128345
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/HostEventCreator.java (line 128)
<https://reviews.apache.org/r/46021/#comment191770>
You could use guava Iterables.getFirst() to make this more readable.
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/HostEventCreator.java (line 147)
<https://reviews.apache.org/r/46021/#comment191771>
Regex may give more flexivility (e.g handle white spaces, validate if the request URI is in the appropriate format before extracting hostname from it).
- Sebastian Toader
On April 11, 2016, 5:51 p.m., Daniel Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46021/
> -----------------------------------------------------------
>
> (Updated April 11, 2016, 5:51 p.m.)
>
>
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-15804
> https://issues.apache.org/jira/browse/AMBARI-15804
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Audit logging cleanup and tests
>
> Unit tests for creators
> Adding component to host now handles multiple components
> Fixing hostname for host event
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/AbstractKerberosAuditEvent.java 77c162c
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/CreatePrincipalKerberosAuditEvent.java e3fbbe4
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/DestroyPrincipalKerberosAuditEvent.java ba56f21
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/ActivateUserRequestAuditEvent.java df5726d
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddComponentToHostRequestAuditEvent.java 2c9eedd
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/HostEventCreator.java 7c27d19
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java 8c728db
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java 03a181e
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/DestroyPrincipalsServerAction.java 95dd7a3
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java 922cadb
> ambari-server/src/test/java/org/apache/ambari/server/audit/TaskStatusAuditEventTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/ChangeSecurityStateKerberosAuditEventTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/CreateKeyTabKerberosAuditEventTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/CreatePrincipalKerberosAuditEventTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/DestroyPrincipalKerberosAuditEventTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AlertGroupEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AlertTargetEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestBase.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestHelper.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/BlueprintEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/BlueprintExportEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ComponentEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ConfigurationChangeEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/CredentialEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/DefaultEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/GroupEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/HostEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/MemberEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/PrivilegeEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RecomendationIgnoreEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryVersionEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ServiceConfigDownloadEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ServiceEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UnauthorizedEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UpgradeEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UpgradeItemEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UserEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ValidationIgnoreEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ViewInstanceEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ViewPrivilegeEventCreatorTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/46021/diff/
>
>
> Testing
> -------
>
> (the failing test is not related to any of my changes)
>
> Results :
>
> Failed tests:
> ViewDirectoryWatcherTest.testDirectoryExtractionOnFileAdd:111
> Expectation failure on verify:
> ViewRegistry.readViewArchive(/var/folders/pj/m3fkd7v172dg2cx82nrsq2zh0000gn/T/test_dir/file.jar): expected: 1, actual: 0
>
> Tests run: 4202, Failures: 1, Errors: 0, Skipped: 32
>
>
> Thanks,
>
> Daniel Gergely
>
>
Re: Review Request 46021: Audit logging cleanup and tests
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46021/#review128376
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/HostEventCreator.java (line 153)
<https://reviews.apache.org/r/46021/#comment191816>
The equivalent for this is: `if (matcher.find())`
- Sebastian Toader
On April 12, 2016, 2:09 p.m., Daniel Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46021/
> -----------------------------------------------------------
>
> (Updated April 12, 2016, 2:09 p.m.)
>
>
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-15804
> https://issues.apache.org/jira/browse/AMBARI-15804
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Audit logging cleanup and tests
>
> Unit tests for creators
> Adding component to host now handles multiple components
> Fixing hostname for host event
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/AbstractKerberosAuditEvent.java 77c162c
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/CreatePrincipalKerberosAuditEvent.java e3fbbe4
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/DestroyPrincipalKerberosAuditEvent.java ba56f21
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/ActivateUserRequestAuditEvent.java df5726d
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddComponentToHostRequestAuditEvent.java 2c9eedd
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/ConfigurationChangeEventCreator.java 139f6f6
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/HostEventCreator.java 7c27d19
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/PrivilegeEventCreator.java cd14dd1
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RepositoryVersionEventCreator.java 30fd377
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestAuditEventCreatorHelper.java a02428f
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/UserEventCreator.java 54d02a7
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java 8c728db
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java 03a181e
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/DestroyPrincipalsServerAction.java 95dd7a3
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java 922cadb
> ambari-server/src/test/java/org/apache/ambari/server/audit/TaskStatusAuditEventTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/ChangeSecurityStateKerberosAuditEventTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/CreateKeyTabKerberosAuditEventTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/CreatePrincipalKerberosAuditEventTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/DestroyPrincipalKerberosAuditEventTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AlertGroupEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AlertTargetEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestBase.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestHelper.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/BlueprintEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/BlueprintExportEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ComponentEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ConfigurationChangeEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/CredentialEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/DefaultEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/GroupEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/HostEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/MemberEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/PrivilegeEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RecomendationIgnoreEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryVersionEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ServiceConfigDownloadEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ServiceEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UnauthorizedEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UpgradeEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UpgradeItemEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UserEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ValidationIgnoreEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ViewInstanceEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ViewPrivilegeEventCreatorTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/46021/diff/
>
>
> Testing
> -------
>
> (the failing test is not related to any of my changes)
>
> Results :
>
> Failed tests:
> ViewDirectoryWatcherTest.testDirectoryExtractionOnFileAdd:111
> Expectation failure on verify:
> ViewRegistry.readViewArchive(/var/folders/pj/m3fkd7v172dg2cx82nrsq2zh0000gn/T/test_dir/file.jar): expected: 1, actual: 0
>
> Tests run: 4202, Failures: 1, Errors: 0, Skipped: 32
>
>
> Thanks,
>
> Daniel Gergely
>
>
Re: Review Request 46021: Audit logging cleanup and tests
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46021/#review128399
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On April 12, 2016, 3:51 p.m., Daniel Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46021/
> -----------------------------------------------------------
>
> (Updated April 12, 2016, 3:51 p.m.)
>
>
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-15804
> https://issues.apache.org/jira/browse/AMBARI-15804
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Audit logging cleanup and tests
>
> Unit tests for creators
> Adding component to host now handles multiple components
> Fixing hostname for host event
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/AbstractKerberosAuditEvent.java 77c162c
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/CreatePrincipalKerberosAuditEvent.java e3fbbe4
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/DestroyPrincipalKerberosAuditEvent.java ba56f21
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/ActivateUserRequestAuditEvent.java df5726d
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddComponentToHostRequestAuditEvent.java 2c9eedd
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/ConfigurationChangeEventCreator.java 139f6f6
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/HostEventCreator.java 7c27d19
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/PrivilegeEventCreator.java cd14dd1
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RepositoryVersionEventCreator.java 30fd377
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestAuditEventCreatorHelper.java a02428f
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/UserEventCreator.java 54d02a7
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java 8c728db
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java 03a181e
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/DestroyPrincipalsServerAction.java 95dd7a3
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java 922cadb
> ambari-server/src/test/java/org/apache/ambari/server/audit/TaskStatusAuditEventTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/ChangeSecurityStateKerberosAuditEventTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/CreateKeyTabKerberosAuditEventTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/CreatePrincipalKerberosAuditEventTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/DestroyPrincipalKerberosAuditEventTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AlertGroupEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AlertTargetEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestBase.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestHelper.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/BlueprintEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/BlueprintExportEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ComponentEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ConfigurationChangeEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/CredentialEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/DefaultEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/GroupEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/HostEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/MemberEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/PrivilegeEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RecomendationIgnoreEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryVersionEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ServiceConfigDownloadEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ServiceEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UnauthorizedEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UpgradeEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UpgradeItemEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UserEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ValidationIgnoreEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ViewInstanceEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ViewPrivilegeEventCreatorTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/46021/diff/
>
>
> Testing
> -------
>
> (the failing test is not related to any of my changes)
>
> Results :
>
> Failed tests:
> ViewDirectoryWatcherTest.testDirectoryExtractionOnFileAdd:111
> Expectation failure on verify:
> ViewRegistry.readViewArchive(/var/folders/pj/m3fkd7v172dg2cx82nrsq2zh0000gn/T/test_dir/file.jar): expected: 1, actual: 0
>
> Tests run: 4202, Failures: 1, Errors: 0, Skipped: 32
>
>
> Thanks,
>
> Daniel Gergely
>
>
Re: Review Request 46021: Audit logging cleanup and tests
Posted by Sandor Magyari <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46021/#review128416
-----------------------------------------------------------
Ship it!
Ship It!
- Sandor Magyari
On April 12, 2016, 1:51 p.m., Daniel Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46021/
> -----------------------------------------------------------
>
> (Updated April 12, 2016, 1:51 p.m.)
>
>
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-15804
> https://issues.apache.org/jira/browse/AMBARI-15804
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Audit logging cleanup and tests
>
> Unit tests for creators
> Adding component to host now handles multiple components
> Fixing hostname for host event
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/AbstractKerberosAuditEvent.java 77c162c
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/CreatePrincipalKerberosAuditEvent.java e3fbbe4
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/DestroyPrincipalKerberosAuditEvent.java ba56f21
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/ActivateUserRequestAuditEvent.java df5726d
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddComponentToHostRequestAuditEvent.java 2c9eedd
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/ConfigurationChangeEventCreator.java 139f6f6
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/HostEventCreator.java 7c27d19
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/PrivilegeEventCreator.java cd14dd1
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RepositoryVersionEventCreator.java 30fd377
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestAuditEventCreatorHelper.java a02428f
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/UserEventCreator.java 54d02a7
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java 8c728db
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java 03a181e
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/DestroyPrincipalsServerAction.java 95dd7a3
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java 922cadb
> ambari-server/src/test/java/org/apache/ambari/server/audit/TaskStatusAuditEventTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/ChangeSecurityStateKerberosAuditEventTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/CreateKeyTabKerberosAuditEventTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/CreatePrincipalKerberosAuditEventTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/DestroyPrincipalKerberosAuditEventTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AlertGroupEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AlertTargetEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestBase.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestHelper.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/BlueprintEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/BlueprintExportEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ComponentEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ConfigurationChangeEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/CredentialEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/DefaultEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/GroupEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/HostEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/MemberEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/PrivilegeEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RecomendationIgnoreEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryVersionEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ServiceConfigDownloadEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ServiceEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UnauthorizedEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UpgradeEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UpgradeItemEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UserEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ValidationIgnoreEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ViewInstanceEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ViewPrivilegeEventCreatorTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/46021/diff/
>
>
> Testing
> -------
>
> (the failing test is not related to any of my changes)
>
> Results :
>
> Failed tests:
> ViewDirectoryWatcherTest.testDirectoryExtractionOnFileAdd:111
> Expectation failure on verify:
> ViewRegistry.readViewArchive(/var/folders/pj/m3fkd7v172dg2cx82nrsq2zh0000gn/T/test_dir/file.jar): expected: 1, actual: 0
>
> Tests run: 4202, Failures: 1, Errors: 0, Skipped: 32
>
>
> Thanks,
>
> Daniel Gergely
>
>
Re: Review Request 46021: Audit logging cleanup and tests
Posted by Daniel Gergely <dg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46021/
-----------------------------------------------------------
(Updated ápr. 12, 2016, 1:51 du)
Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.
Changes
-------
Changing regex pattern to class constant
Bugs: AMBARI-15804
https://issues.apache.org/jira/browse/AMBARI-15804
Repository: ambari
Description
-------
Audit logging cleanup and tests
Unit tests for creators
Adding component to host now handles multiple components
Fixing hostname for host event
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/AbstractKerberosAuditEvent.java 77c162c
ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/CreatePrincipalKerberosAuditEvent.java e3fbbe4
ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/DestroyPrincipalKerberosAuditEvent.java ba56f21
ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/ActivateUserRequestAuditEvent.java df5726d
ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddComponentToHostRequestAuditEvent.java 2c9eedd
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/ConfigurationChangeEventCreator.java 139f6f6
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/HostEventCreator.java 7c27d19
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/PrivilegeEventCreator.java cd14dd1
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RepositoryVersionEventCreator.java 30fd377
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestAuditEventCreatorHelper.java a02428f
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/UserEventCreator.java 54d02a7
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java 8c728db
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java 03a181e
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/DestroyPrincipalsServerAction.java 95dd7a3
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java 922cadb
ambari-server/src/test/java/org/apache/ambari/server/audit/TaskStatusAuditEventTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/ChangeSecurityStateKerberosAuditEventTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/CreateKeyTabKerberosAuditEventTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/CreatePrincipalKerberosAuditEventTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/DestroyPrincipalKerberosAuditEventTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AlertGroupEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AlertTargetEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestBase.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestHelper.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/BlueprintEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/BlueprintExportEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ComponentEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ConfigurationChangeEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/CredentialEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/DefaultEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/GroupEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/HostEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/MemberEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/PrivilegeEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RecomendationIgnoreEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryVersionEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ServiceConfigDownloadEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ServiceEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UnauthorizedEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UpgradeEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UpgradeItemEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UserEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ValidationIgnoreEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ViewInstanceEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ViewPrivilegeEventCreatorTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/46021/diff/
Testing
-------
(the failing test is not related to any of my changes)
Results :
Failed tests:
ViewDirectoryWatcherTest.testDirectoryExtractionOnFileAdd:111
Expectation failure on verify:
ViewRegistry.readViewArchive(/var/folders/pj/m3fkd7v172dg2cx82nrsq2zh0000gn/T/test_dir/file.jar): expected: 1, actual: 0
Tests run: 4202, Failures: 1, Errors: 0, Skipped: 32
Thanks,
Daniel Gergely
Re: Review Request 46021: Audit logging cleanup and tests
Posted by Daniel Gergely <dg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46021/
-----------------------------------------------------------
(Updated ápr. 12, 2016, 12:54 du)
Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.
Changes
-------
Review fix
Bugs: AMBARI-15804
https://issues.apache.org/jira/browse/AMBARI-15804
Repository: ambari
Description
-------
Audit logging cleanup and tests
Unit tests for creators
Adding component to host now handles multiple components
Fixing hostname for host event
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/AbstractKerberosAuditEvent.java 77c162c
ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/CreatePrincipalKerberosAuditEvent.java e3fbbe4
ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/DestroyPrincipalKerberosAuditEvent.java ba56f21
ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/ActivateUserRequestAuditEvent.java df5726d
ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddComponentToHostRequestAuditEvent.java 2c9eedd
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/ConfigurationChangeEventCreator.java 139f6f6
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/HostEventCreator.java 7c27d19
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/PrivilegeEventCreator.java cd14dd1
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RepositoryVersionEventCreator.java 30fd377
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestAuditEventCreatorHelper.java a02428f
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/UserEventCreator.java 54d02a7
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java 8c728db
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java 03a181e
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/DestroyPrincipalsServerAction.java 95dd7a3
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java 922cadb
ambari-server/src/test/java/org/apache/ambari/server/audit/TaskStatusAuditEventTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/ChangeSecurityStateKerberosAuditEventTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/CreateKeyTabKerberosAuditEventTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/CreatePrincipalKerberosAuditEventTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/DestroyPrincipalKerberosAuditEventTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AlertGroupEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AlertTargetEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestBase.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestHelper.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/BlueprintEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/BlueprintExportEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ComponentEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ConfigurationChangeEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/CredentialEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/DefaultEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/GroupEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/HostEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/MemberEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/PrivilegeEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RecomendationIgnoreEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryVersionEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ServiceConfigDownloadEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ServiceEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UnauthorizedEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UpgradeEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UpgradeItemEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UserEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ValidationIgnoreEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ViewInstanceEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ViewPrivilegeEventCreatorTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/46021/diff/
Testing
-------
(the failing test is not related to any of my changes)
Results :
Failed tests:
ViewDirectoryWatcherTest.testDirectoryExtractionOnFileAdd:111
Expectation failure on verify:
ViewRegistry.readViewArchive(/var/folders/pj/m3fkd7v172dg2cx82nrsq2zh0000gn/T/test_dir/file.jar): expected: 1, actual: 0
Tests run: 4202, Failures: 1, Errors: 0, Skipped: 32
Thanks,
Daniel Gergely
Re: Review Request 46021: Audit logging cleanup and tests
Posted by Daniel Gergely <dg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46021/
-----------------------------------------------------------
(Updated ápr. 12, 2016, 12:09 du)
Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.
Changes
-------
Add regexp, use Iterables
Bugs: AMBARI-15804
https://issues.apache.org/jira/browse/AMBARI-15804
Repository: ambari
Description
-------
Audit logging cleanup and tests
Unit tests for creators
Adding component to host now handles multiple components
Fixing hostname for host event
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/AbstractKerberosAuditEvent.java 77c162c
ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/CreatePrincipalKerberosAuditEvent.java e3fbbe4
ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/DestroyPrincipalKerberosAuditEvent.java ba56f21
ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/ActivateUserRequestAuditEvent.java df5726d
ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddComponentToHostRequestAuditEvent.java 2c9eedd
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/ConfigurationChangeEventCreator.java 139f6f6
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/HostEventCreator.java 7c27d19
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/PrivilegeEventCreator.java cd14dd1
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RepositoryVersionEventCreator.java 30fd377
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestAuditEventCreatorHelper.java a02428f
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/UserEventCreator.java 54d02a7
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java 8c728db
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java 03a181e
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/DestroyPrincipalsServerAction.java 95dd7a3
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java 922cadb
ambari-server/src/test/java/org/apache/ambari/server/audit/TaskStatusAuditEventTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/ChangeSecurityStateKerberosAuditEventTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/CreateKeyTabKerberosAuditEventTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/CreatePrincipalKerberosAuditEventTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/DestroyPrincipalKerberosAuditEventTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AlertGroupEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AlertTargetEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestBase.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestHelper.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/BlueprintEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/BlueprintExportEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ComponentEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ConfigurationChangeEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/CredentialEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/DefaultEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/GroupEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/HostEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/MemberEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/PrivilegeEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RecomendationIgnoreEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryVersionEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ServiceConfigDownloadEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ServiceEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UnauthorizedEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UpgradeEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UpgradeItemEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UserEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ValidationIgnoreEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ViewInstanceEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ViewPrivilegeEventCreatorTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/46021/diff/
Testing
-------
(the failing test is not related to any of my changes)
Results :
Failed tests:
ViewDirectoryWatcherTest.testDirectoryExtractionOnFileAdd:111
Expectation failure on verify:
ViewRegistry.readViewArchive(/var/folders/pj/m3fkd7v172dg2cx82nrsq2zh0000gn/T/test_dir/file.jar): expected: 1, actual: 0
Tests run: 4202, Failures: 1, Errors: 0, Skipped: 32
Thanks,
Daniel Gergely
Re: Review Request 46021: Audit logging cleanup and tests
Posted by Daniel Gergely <dg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46021/
-----------------------------------------------------------
(Updated ápr. 11, 2016, 3:51 du)
Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.
Bugs: AMBARI-15804
https://issues.apache.org/jira/browse/AMBARI-15804
Repository: ambari
Description
-------
Audit logging cleanup and tests
Unit tests for creators
Adding component to host now handles multiple components
Fixing hostname for host event
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/AbstractKerberosAuditEvent.java 77c162c
ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/CreatePrincipalKerberosAuditEvent.java e3fbbe4
ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/DestroyPrincipalKerberosAuditEvent.java ba56f21
ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/ActivateUserRequestAuditEvent.java df5726d
ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddComponentToHostRequestAuditEvent.java 2c9eedd
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/HostEventCreator.java 7c27d19
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java 8c728db
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java 03a181e
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/DestroyPrincipalsServerAction.java 95dd7a3
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java 922cadb
ambari-server/src/test/java/org/apache/ambari/server/audit/TaskStatusAuditEventTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/ChangeSecurityStateKerberosAuditEventTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/CreateKeyTabKerberosAuditEventTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/CreatePrincipalKerberosAuditEventTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/DestroyPrincipalKerberosAuditEventTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AlertGroupEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AlertTargetEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestBase.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestHelper.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/BlueprintEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/BlueprintExportEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ComponentEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ConfigurationChangeEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/CredentialEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/DefaultEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/GroupEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/HostEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/MemberEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/PrivilegeEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RecomendationIgnoreEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryVersionEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ServiceConfigDownloadEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ServiceEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UnauthorizedEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UpgradeEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UpgradeItemEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UserEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ValidationIgnoreEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ViewInstanceEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ViewPrivilegeEventCreatorTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/46021/diff/
Testing (updated)
-------
(the failing test is not related to any of my changes)
Results :
Failed tests:
ViewDirectoryWatcherTest.testDirectoryExtractionOnFileAdd:111
Expectation failure on verify:
ViewRegistry.readViewArchive(/var/folders/pj/m3fkd7v172dg2cx82nrsq2zh0000gn/T/test_dir/file.jar): expected: 1, actual: 0
Tests run: 4202, Failures: 1, Errors: 0, Skipped: 32
Thanks,
Daniel Gergely
Re: Review Request 46021: Audit logging cleanup and tests
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46021/#review128126
-----------------------------------------------------------
Ship it!
Ship It!
- Oliver Szabo
On April 11, 2016, 2:11 p.m., Daniel Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46021/
> -----------------------------------------------------------
>
> (Updated April 11, 2016, 2:11 p.m.)
>
>
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-15804
> https://issues.apache.org/jira/browse/AMBARI-15804
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Audit logging cleanup and tests
>
> Unit tests for creators
> Adding component to host now handles multiple components
> Fixing hostname for host event
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/AbstractKerberosAuditEvent.java 77c162c
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/CreatePrincipalKerberosAuditEvent.java e3fbbe4
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/DestroyPrincipalKerberosAuditEvent.java ba56f21
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/ActivateUserRequestAuditEvent.java df5726d
> ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddComponentToHostRequestAuditEvent.java 2c9eedd
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/HostEventCreator.java 7c27d19
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java 8c728db
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java 03a181e
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/DestroyPrincipalsServerAction.java 95dd7a3
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java 922cadb
> ambari-server/src/test/java/org/apache/ambari/server/audit/TaskStatusAuditEventTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/ChangeSecurityStateKerberosAuditEventTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/CreateKeyTabKerberosAuditEventTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/CreatePrincipalKerberosAuditEventTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/DestroyPrincipalKerberosAuditEventTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AlertGroupEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AlertTargetEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestBase.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestHelper.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/BlueprintEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/BlueprintExportEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ComponentEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ConfigurationChangeEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/CredentialEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/DefaultEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/GroupEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/HostEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/MemberEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/PrivilegeEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RecomendationIgnoreEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryVersionEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ServiceConfigDownloadEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ServiceEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UnauthorizedEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UpgradeEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UpgradeItemEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UserEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ValidationIgnoreEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ViewInstanceEventCreatorTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ViewPrivilegeEventCreatorTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/46021/diff/
>
>
> Testing
> -------
>
> Still running locally...
>
>
> Thanks,
>
> Daniel Gergely
>
>
Re: Review Request 46021: Audit logging cleanup and tests
Posted by Daniel Gergely <dg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46021/
-----------------------------------------------------------
(Updated ápr. 11, 2016, 2:11 du)
Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.
Changes
-------
Kerberos audit events related changes.
Bugs: AMBARI-15804
https://issues.apache.org/jira/browse/AMBARI-15804
Repository: ambari
Description
-------
Audit logging cleanup and tests
Unit tests for creators
Adding component to host now handles multiple components
Fixing hostname for host event
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/AbstractKerberosAuditEvent.java 77c162c
ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/CreatePrincipalKerberosAuditEvent.java e3fbbe4
ambari-server/src/main/java/org/apache/ambari/server/audit/event/kerberos/DestroyPrincipalKerberosAuditEvent.java ba56f21
ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/ActivateUserRequestAuditEvent.java df5726d
ambari-server/src/main/java/org/apache/ambari/server/audit/event/request/AddComponentToHostRequestAuditEvent.java 2c9eedd
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/HostEventCreator.java 7c27d19
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java 8c728db
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java 03a181e
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/DestroyPrincipalsServerAction.java 95dd7a3
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java 922cadb
ambari-server/src/test/java/org/apache/ambari/server/audit/TaskStatusAuditEventTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/ChangeSecurityStateKerberosAuditEventTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/CreateKeyTabKerberosAuditEventTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/CreatePrincipalKerberosAuditEventTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/kerberos/DestroyPrincipalKerberosAuditEventTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AlertGroupEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AlertTargetEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestBase.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestHelper.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/BlueprintEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/BlueprintExportEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ComponentEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ConfigurationChangeEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/CredentialEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/DefaultEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/GroupEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/HostEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/MemberEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/PrivilegeEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RecomendationIgnoreEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryVersionEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ServiceConfigDownloadEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ServiceEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UnauthorizedEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UpgradeEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UpgradeItemEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UserEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ValidationIgnoreEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ViewInstanceEventCreatorTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ViewPrivilegeEventCreatorTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/46021/diff/
Testing
-------
Still running locally...
Thanks,
Daniel Gergely