[GitHub] [thrift] cspwizard commented on a change in pull request #2523: THRIFT-5139: THRIFT-4181: Python3 type hints

[GitBox <gi...@apache.org>]

cspwizard commented on a change in pull request #2523:
URL: https://github.com/apache/thrift/pull/2523#discussion_r825304780



##########
File path: compiler/cpp/src/thrift/generate/t_py_generator.cc
##########
@@ -127,6 +128,9 @@ class t_py_generator : public t_generator {
         gen_tornado_ = true;
       } else if( iter->first.compare("coding") == 0) {
         coding_ = iter->second;
+      } else if( iter->first.compare("type_hints") == 0) {
+        gen_type_hints_ = true;
+        gen_enum_ = true;

Review comment:
       added it, but it should be obvious as without enum type type hinting won't work.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org