[jira] [Commented] (CALCITE-5280) Implement geometry aggregate functions

["Julian Hyde (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-5280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602578#comment-17602578 ] 

Julian Hyde commented on CALCITE-5280:
--------------------------------------

{{SqlAggFunction}} defines the function for validation purposes (e.g. type derivation). If you need smarter type derivation you may need to implement it directly. But even if you implement {{SqlAggFunction}} you will still have to specify how it is implemented at runtime - i.e. in code generation.

{{AggregateFunctionImpl}} is about the code generation part. If you just provide one of those, Calcite will add a {{SqlUserDefinedAggFunction}} wrapper which will probably be sufficient for validation purposes. That's what I would try first.

> Implement geometry aggregate functions
> --------------------------------------
>
>                 Key: CALCITE-5280
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5280
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Bertil Chapuis
>            Assignee: Bertil Chapuis
>            Priority: Minor
>
> Geometry aggregate functions (ST_Accum, ST_Collect, and ST_Union) are currently missing in Calcite. Using an AggregateFunctionImpl looks be pretty straightforward, but many aggregate function implement SqlAggFunction directly.
> [~julianhyde] What would be the best way to implement them?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)