You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/01 12:27:32 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #2259: Remove fallibility from RLEEncoder (#2226)
tustvold opened a new pull request, #2259:
URL: https://github.com/apache/arrow-rs/pull/2259
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #2226
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Follow on to #2226
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
RLEEncoder is no longer fallible and so we can simplify its interface
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
No, the encoding module is experimental
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a diff in pull request #2259: Remove fallibility from RleEncoder (#2226)
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #2259:
URL: https://github.com/apache/arrow-rs/pull/2259#discussion_r935578587
##########
parquet/src/encodings/rle.rs:
##########
@@ -244,10 +239,9 @@ impl RleEncoder {
);
self.num_buffered_values = 0;
self.repeat_count = 0;
- Ok(())
Review Comment:
So it seems like the `flush_*` functions are the root of the chain and then the "can't fail" gets to percolate up? 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #2259: Remove fallibility from paruqet RleEncoder (#2226)
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2259:
URL: https://github.com/apache/arrow-rs/pull/2259#issuecomment-1202546261
Benchmark runs are scheduled for baseline = 9a4b1c99d7e5a3bd3c6e3bce3ba0ee154720827f and contender = 4222f5aa40c3d0c0821fc61c1c4091176ebb70f2. 4222f5aa40c3d0c0821fc61c1c4091176ebb70f2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/28dfc479a1874c52b89c795d663fe175...b4cf8f51f5994f43a215f3beb5aa79cf/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/dd374a22c18a40758a962ed5fb674406...94c57e2e9e584d488dd039fb69922550/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/c69e12537a4847ffa9555734805745af...3ec357e8daae4c4b8be5574d4b8e6a81/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/347b98834e444b64ae266ca03dec564a...af42583bf77842aeb6c31e6c767aab06/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2259: Remove fallibility from RLEEncoder (#2226)
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #2259:
URL: https://github.com/apache/arrow-rs/pull/2259#discussion_r934471293
##########
parquet/src/encodings/rle.rs:
##########
@@ -132,23 +132,21 @@ impl RleEncoder {
}
/// Encodes `value`, which must be representable with `bit_width` bits.
- /// Returns true if the value fits in buffer, false if it doesn't, or
Review Comment:
I am very happy to see this gone, it made for a very confusing interface imo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #2259: Remove fallibility from RleEncoder (#2226)
Posted by GitBox <gi...@apache.org>.
alamb merged PR #2259:
URL: https://github.com/apache/arrow-rs/pull/2259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org