You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/10 17:38:00 UTC
[GitHub] [airflow] anitakar opened a new pull request #16376: Set num of retries for google cloud connection to 3.
anitakar opened a new pull request #16376:
URL: https://github.com/apache/airflow/pull/16376
Can be useful in case of a connection being kept alive for
a very long time, for example because underneth it waits for a dataflow job.
related: #1397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #16376: Set num of retries for google cloud connection to 3.
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #16376:
URL: https://github.com/apache/airflow/pull/16376#discussion_r649480136
##########
File path: airflow/utils/db.py
##########
@@ -277,6 +277,7 @@ def create_default_connections(session=None):
conn_id="google_cloud_default",
conn_type="google_cloud_platform",
schema="default",
+ extra='{"extra__google_cloud_platform__num_retries": 3}',
Review comment:
By default, we set this value to 5. See: https://github.com/apache/airflow/blob/491c835051e904d7632b05bc3512a7cb77e3b575/airflow/providers/google/common/hooks/base_google.py#L189
https://github.com/apache/airflow/blob/491c835051e904d7632b05bc3512a7cb77e3b575/airflow/providers/google/common/hooks/base_google.py#L310-L330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #16376: Set num of retries for google cloud connection to 3.
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #16376:
URL: https://github.com/apache/airflow/pull/16376#discussion_r649480136
##########
File path: airflow/utils/db.py
##########
@@ -277,6 +277,7 @@ def create_default_connections(session=None):
conn_id="google_cloud_default",
conn_type="google_cloud_platform",
schema="default",
+ extra='{"extra__google_cloud_platform__num_retries": 3}',
Review comment:
By default, we set this value to 5. See: https://github.com/apache/airflow/blob/491c835051e904d7632b05bc3512a7cb77e3b575/airflow/providers/google/common/hooks/base_google.py#L189
https://github.com/apache/airflow/blob/491c835051e904d7632b05bc3512a7cb77e3b575/airflow/providers/google/common/hooks/base_google.py#L310-L330
You don't need to configure it again here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] anitakar closed pull request #16376: Set num of retries for google cloud connection to 3.
Posted by GitBox <gi...@apache.org>.
anitakar closed pull request #16376:
URL: https://github.com/apache/airflow/pull/16376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] anitakar commented on a change in pull request #16376: Set num of retries for google cloud connection to 3.
Posted by GitBox <gi...@apache.org>.
anitakar commented on a change in pull request #16376:
URL: https://github.com/apache/airflow/pull/16376#discussion_r649757572
##########
File path: airflow/utils/db.py
##########
@@ -277,6 +277,7 @@ def create_default_connections(session=None):
conn_id="google_cloud_default",
conn_type="google_cloud_platform",
schema="default",
+ extra='{"extra__google_cloud_platform__num_retries": 3}',
Review comment:
Thanks!. Reverting then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org