[jira] [Comment Edited] (PDFBOX-4122) Resolve potential NPEs flagged by Sonar

["Maruan Sahyoun (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PDFBOX-4122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387841#comment-16387841 ] 

Maruan Sahyoun edited comment on PDFBOX-4122 at 3/6/18 3:30 PM:
----------------------------------------------------------------

[~lehmi] I would have used {{Objects.requireNonNull}} but that will throw an NPE which IMHO is fine as we document in anyway. If you don't like it we can add our own test and throw an {{IllegalArgumentException}} and document that. WDYT?

My preference would be to throw an NPE in this case as this is inline with the documentation for NPE and in this case more specific than an {{IllegalArgumentException}}
{quote}
Applications should throw instances of this class to indicate other illegal uses of the null object.
{quote} 


was (Author: msahyoun):
[~lehmi] I would have used {{Objects.requireNonNull}} but that will throw an NPE which IMHO is fine as we document in anyway. If you don't like it we can add our own test and throw an {{IllegalArgumentException}} and document that. WDYT?

> Resolve potential NPEs flagged by Sonar
> ---------------------------------------
>
>                 Key: PDFBOX-4122
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-4122
>             Project: PDFBox
>          Issue Type: Sub-task
>    Affects Versions: 3.0.0 PDFBox
>            Reporter: Maruan Sahyoun
>            Assignee: Maruan Sahyoun
>            Priority: Major
>             Fix For: 3.0.0 PDFBox
>
>
> We have many potential NPEs resolved by now but there are still some flagged by Sonar
> https://builds.apache.org/analysis/component_issues?id=org.apache.pdfbox%3Apdfbox-reactor#resolved=false|types=BUG|severities=BLOCKER.
> Although it's very unlikely that we hit them in practice e.g. as this would mean a very corrupt font file I'll try to resolve these debug logging the condition and returning in that case.
> [~tilman] [~lehmi] please comment/revert if you are not happy with the approach. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org