You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/04/19 13:27:02 UTC
[GitHub] [incubator-pekko-connectors] mdedetrich opened a new pull request, #83: Set contentCount values to 0
mdedetrich opened a new pull request, #83:
URL: https://github.com/apache/incubator-pekko-connectors/pull/83
The fact that these values are set to 4 and 5 in the base test trait is likely complete oversight. For some context, these values are used in the `list with real credentials`, `list with real credentials using the Version 1 API` and `list with real credentials in non us-east-1 zone` tests. In all of these cases, these are the first tests to run in the test suite and when they do run the buckets are empty which is why 0 is the correct value.
These tests were passing as expected in Minio since they were overridden to be 0 but they were failing in AWS S3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich merged pull request #83: Set contentCount values to 0
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #83:
URL: https://github.com/apache/incubator-pekko-connectors/pull/83
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on pull request #83: Set contentCount values to 0
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #83:
URL: https://github.com/apache/incubator-pekko-connectors/pull/83#issuecomment-1514758753
Relevant CI passed, merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org