You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mo...@apache.org on 2015/04/27 02:51:24 UTC

incubator-zeppelin git commit: ZEPPELIN-58 Test ZeppelinRestApiTest.getAvailableInterpreters is failing after adding new interpreter

Repository: incubator-zeppelin
Updated Branches:
  refs/heads/master ce48f4a90 -> 87f28ab4b


ZEPPELIN-58 Test ZeppelinRestApiTest.getAvailableInterpreters is failing after adding new interpreter

https://issues.apache.org/jira/browse/ZEPPELIN-58

This pr removes hardcoded value from test to prevent test failure after adding new interpreter.

Ready to merge.

Author: Lee moon soo <mo...@apache.org>

Closes #50 from Leemoonsoo/ZEPPELIN-58 and squashes the following commits:

69403e0 [Lee moon soo] ZEPPELIN-58 remove hardcoded value


Project: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/commit/87f28ab4
Tree: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/tree/87f28ab4
Diff: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/diff/87f28ab4

Branch: refs/heads/master
Commit: 87f28ab4b94668bd095433dd5c309f55c42965a7
Parents: ce48f4a
Author: Lee moon soo <mo...@apache.org>
Authored: Sat Apr 25 09:22:28 2015 +0900
Committer: Lee moon soo <mo...@apache.org>
Committed: Mon Apr 27 09:51:18 2015 +0900

----------------------------------------------------------------------
 .../test/java/org/apache/zeppelin/rest/ZeppelinRestApiTest.java   | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/87f28ab4/zeppelin-server/src/test/java/org/apache/zeppelin/rest/ZeppelinRestApiTest.java
----------------------------------------------------------------------
diff --git a/zeppelin-server/src/test/java/org/apache/zeppelin/rest/ZeppelinRestApiTest.java b/zeppelin-server/src/test/java/org/apache/zeppelin/rest/ZeppelinRestApiTest.java
index db37bf5..0d4e158 100644
--- a/zeppelin-server/src/test/java/org/apache/zeppelin/rest/ZeppelinRestApiTest.java
+++ b/zeppelin-server/src/test/java/org/apache/zeppelin/rest/ZeppelinRestApiTest.java
@@ -26,6 +26,7 @@ import java.util.List;
 import java.util.Map;
 
 import org.apache.commons.httpclient.methods.GetMethod;
+import org.apache.zeppelin.conf.ZeppelinConfiguration;
 import org.apache.zeppelin.notebook.Note;
 import org.apache.zeppelin.server.ZeppelinServer;
 import org.junit.AfterClass;
@@ -79,7 +80,7 @@ public class ZeppelinRestApiTest extends AbstractTestRestApi {
     assertThat(get, isAllowed());
     Map<String, Object> resp = gson.fromJson(get.getResponseBodyAsString(), new TypeToken<Map<String, Object>>(){}.getType());
     Map<String, Object> body = (Map<String, Object>) resp.get("body");
-    assertEquals(8, body.size());
+    assertEquals(ZeppelinConfiguration.ConfVars.ZEPPELIN_INTERPRETERS.getStringValue().split(",").length, body.size());
     get.releaseConnection();
   }