You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by bostko <gi...@git.apache.org> on 2016/08/02 13:52:17 UTC
[GitHub] brooklyn-library pull request #55: AbstractControllerImpl: expose http url b...
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-library/pull/55
AbstractControllerImpl: expose http url by default
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/brooklyn-library http_controller_url
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-library/pull/55.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #55
----
commit 1b0d3ed7ee4da3d760380b1b99a618d171db181b
Author: Valentin Aitken <bo...@gmail.com>
Date: 2016-08-02T13:34:58Z
AbstractControllerImpl: expose http url by default
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library pull request #55: AbstractControllerImpl: expose http url b...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/55#discussion_r73174941
--- Diff: software/webapp/src/main/java/org/apache/brooklyn/entity/proxy/AbstractControllerImpl.java ---
@@ -287,7 +287,7 @@ protected String inferUrl(boolean requireManagementAccessible) {
}
protected String inferUrl() {
- return inferUrl(false);
+ return inferUrl(true);
--- End diff --
This doesn't feel right - it will mean that "main.uri" will have the publicly mapped address (e.g. if running in vCloud Director behind a DNAT rule then it will show the dnat'ed port).
That contradicts the proposal in dev@brooklyn (email subject "Working with Multiple Networks - Apache Brooklyn Feature Proposal", link to proposal is
https://docs.google.com/document/d/1IrWLWunWSl_ScwY3MRICped8eJMjQEH1FbWZJcoK0Iw). That proposal says the main.uri should be the subnet address.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library issue #55: AbstractControllerImpl: expose http url by defau...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-library/pull/55
bump @bostko
Is this still an issue? Can you answer Aled's question from above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library issue #55: AbstractControllerImpl: expose http url by defau...
Posted by bostko <gi...@git.apache.org>.
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-library/pull/55
This PR should be revisited. Closing for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library pull request #55: AbstractControllerImpl: expose http url b...
Posted by bostko <gi...@git.apache.org>.
Github user bostko closed the pull request at:
https://github.com/apache/brooklyn-library/pull/55
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---