[jira] [Commented] (REEF-1525) Fix HelloHttpYarn Example

["Boris Shulman (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/REEF-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15419333#comment-15419333 ] 

Boris Shulman commented on REEF-1525:
-------------------------------------

From what I see the problem is that we bind .set(DriverConfiguration.ON_CLIENT_CLOSED, HttpShellJobDriver.HttpClientCloseHandler.class) and it also referenced by HttpServerReefEventHandler whichis referenced from http server which is referenced from url tracker, creating a loop. So it looks like we cannot bind client close handlers when using reef-webserver from yarn.

[~markus.weimer] [~juliaw] Do you think we can just remove this binding from the hellohttp examples?

> Fix HelloHttpYarn Example
> -------------------------
>
>                 Key: REEF-1525
>                 URL: https://issues.apache.org/jira/browse/REEF-1525
>             Project: REEF
>          Issue Type: Bug
>            Reporter: Boris Shulman
>            Assignee: Boris Shulman
>
> This example is broken throwing loopy constructor exception:
> Runtime Error: Detected loopy constructor involving [ org.apache.reef.examples.hellohttp.HttpShellJobDriver$HttpClientClos
> eHandlerorg.apache.reef.runtime.common.driver.DriverRuntimeStartHandlerorg.apache.reef.examples.hellohttp.HttpShellJobDriver$ActiveContextHandler org.apache.reef.webserver.HttpEventHandlers org.apache.reef.runtime.common.driver.DriverSingletons org.apache.reef.driver.parameters.ContextActiveHandlers org.apache.reef.driver.parameters.ClientCloseHandlers org.apache.reef.webserver.HttpServer org.apache.reef.runtime.yarn.HttpTrackingURLProvider org.apache.reef.runtime.yarn.driver.YarnContainerRequestHandler org.apache.reef.wake.time.Clock$RuntimeStartHandler org.apache.reef.webserver.HttpServerReefEventHandler org.apache.reef.runtime.yarn.driver.TrackingURLProvider org.apache.reef.runtime.yarn.driver.YarnContainerRequestHandlerImpl org.apache.reef.examples.hellohttp.HttpShellJobDriver org.apache.reef.runtime.yarn.driver.YarnContainerManager org.apache.reef.webserver.HttpServerImpl org.apache.reef.webserver.JettyHandler org.apache.reef.runtime.yarn.driver.YarnResourceRequestHandler org.apache.reef.driver.evaluator.EvaluatorRequestor org.apache.reef.runtime.common.driver.api.ResourceRequestHandler org.apache.reef.runtime.common.driver.EvaluatorRequestorImpl ] org.apache.reef.examples.hellohttp.HttpShellJobDriver



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)