You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "morningman (via GitHub)" <gi...@apache.org> on 2023/06/14 08:09:28 UTC

[GitHub] [doris] morningman commented on a diff in pull request #20723: [improvement](mutil-catalog) PaimonColumnValue support short and Decimal

morningman commented on code in PR #20723:
URL: https://github.com/apache/doris/pull/20723#discussion_r1229194919


##########
fe/fe-core/src/main/java/org/apache/doris/planner/external/paimon/PaimonScanNode.java:
##########
@@ -95,7 +95,7 @@ public static void setPaimonParams(TFileRangeDesc rangeDesc, PaimonSplit paimonS
         for (SlotDescriptor slot : source.getDesc().getSlots()) {

Review Comment:
   Add example in code to describe the format, or it is hard to understand.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org