[jira] [Reopened] (CASSANDRA-4099) IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress

["Jonathan Ellis (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CASSANDRA-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis reopened CASSANDRA-4099:
---------------------------------------


I think this is still broken.  if A forwards a message from B to C, then {{Gossiper.instance.setVersion(from, version)}} C will mark B's version (B == from) to the version that A sent.  But A sends its own version, not B's.  (Which is correct for the purpose of message forwarding, since A re-serializes instead of passing what B sent verbatim.)

I don't think we can accommodate both message forwarding, and broadcast address != socket address, without a protocol change to include a "here is my reply-to broadcast_address" piece of information when the connection is first established, distinct from Message.from.
                
> IncomingTCPConnection recognizes from by doing socket.getInetAddress() instead of BroadCastAddress
> --------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-4099
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4099
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Vijay
>            Assignee: Vijay
>            Priority: Minor
>             Fix For: 1.0.9, 1.1.0
>
>         Attachments: 0001-CASSANDRA-4099-v2.patch, 0001-CASSANDRA-4099-v3.patch, 0001-CASSANDRA-4099-v4.patch, 0001-CASSANDRA-4099.patch
>
>
> change "this.from = socket.getInetAddress()" to understand the broad cast IP, but the problem is we dont know until the first packet is received, this ticket is to work around the problem until it reads the first packet.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira