You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by nabhanelrahman <gi...@git.apache.org> on 2016/06/24 22:42:53 UTC
[GitHub] storm pull request #1518: re-submitting STORM-1930: Kafka New Client API - S...
GitHub user nabhanelrahman opened a pull request:
https://github.com/apache/storm/pull/1518
re-submitting STORM-1930: Kafka New Client API - Support for Topic Wildcards
contributer @hmcl has refactored my pull request #1474 and submitted the pull request #1516. pull request #1516 refined #1474 with better class names and object structure so it is more intuitive for the use. This pull request is a joint effort made by me and @hmcl
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/publica-project/storm Apache_master_STORM-1930_KafkaWildcards
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1518.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1518
----
commit ce32dce45fa4080efaac9b9330116546617bdca6
Author: nabhanelrahman <na...@publica-project.com>
Date: 2016-06-24T21:18:40Z
re-submitting pull request https://github.com/apache/storm/pull/1516
contributer @hmcl has refactored original request
https://github.com/apache/storm/pull/1474 with cleaner naming
conventions.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1518: re-submitting STORM-1930: Kafka New Client API - Support ...
Posted by nabhanelrahman <gi...@git.apache.org>.
Github user nabhanelrahman commented on the issue:
https://github.com/apache/storm/pull/1518
@hmcl, just following up; it this PR ready to merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1518: re-submitting STORM-1930: Kafka New Client API - Support ...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/1518
@nabhanelrahman this JIRA is merged via another PR thats open at that time. Please go ahead close this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1518: re-submitting STORM-1930: Kafka New Client API - S...
Posted by nabhanelrahman <gi...@git.apache.org>.
Github user nabhanelrahman closed the pull request at:
https://github.com/apache/storm/pull/1518
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1518: re-submitting STORM-1930: Kafka New Client API - Support ...
Posted by nabhanelrahman <gi...@git.apache.org>.
Github user nabhanelrahman commented on the issue:
https://github.com/apache/storm/pull/1518
@hmcl, can you review, it looks like their are some conflicts in the merge, but I don't have write access
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---